You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by we...@apache.org on 2018/09/27 12:19:46 UTC
[arrow] 07/24: PARQUET-892: Specify public link targets for
parquet_static so that transitive dependencies are linked in executables
This is an automated email from the ASF dual-hosted git repository.
wesm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
commit 22a96d9a69fb8786ee101606fa29b4905a61077c
Author: Wes McKinney <we...@twosigma.com>
AuthorDate: Thu Feb 23 09:22:06 2017 +0100
PARQUET-892: Specify public link targets for parquet_static so that transitive dependencies are linked in executables
Author: Wes McKinney <we...@twosigma.com>
Closes #259 from wesm/PARQUET-892 and squashes the following commits:
1e932c4 [Wes McKinney] Specify public link targets for parquet_static so that transitive dependencies are linked in executables
Change-Id: Ib0bea0cd272919dffa82aa1c12d7658ea15d9cb5
---
cpp/examples/parquet/CMakeLists.txt | 7 +------
cpp/tools/parquet/CMakeLists.txt | 13 +++----------
2 files changed, 4 insertions(+), 16 deletions(-)
diff --git a/cpp/examples/parquet/CMakeLists.txt b/cpp/examples/parquet/CMakeLists.txt
index 204cc27..721fa9a 100644
--- a/cpp/examples/parquet/CMakeLists.txt
+++ b/cpp/examples/parquet/CMakeLists.txt
@@ -15,12 +15,7 @@
# specific language governing permissions and limitations
# under the License.
-SET(LINK_LIBS
- snappystatic
- thriftstatic)
-
if (PARQUET_BUILD_EXECUTABLES)
add_executable(reader-writer reader-writer.cc)
- target_link_libraries(reader-writer ${LINK_LIBS}
- parquet_static)
+ target_link_libraries(reader-writer parquet_static)
endif()
diff --git a/cpp/tools/parquet/CMakeLists.txt b/cpp/tools/parquet/CMakeLists.txt
index 5c4eaa8..d473d08 100644
--- a/cpp/tools/parquet/CMakeLists.txt
+++ b/cpp/tools/parquet/CMakeLists.txt
@@ -15,20 +15,13 @@
# specific language governing permissions and limitations
# under the License.
-SET(LINK_LIBS
- snappystatic
- thriftstatic)
-
if (PARQUET_BUILD_EXECUTABLES)
add_executable(parquet-dump-schema parquet-dump-schema.cc)
- target_link_libraries(parquet-dump-schema ${LINK_LIBS}
- parquet_static)
+ target_link_libraries(parquet-dump-schema parquet_static)
add_executable(parquet_reader parquet_reader.cc)
- target_link_libraries(parquet_reader ${LINK_LIBS}
- parquet_static)
+ target_link_libraries(parquet_reader parquet_static)
add_executable(parquet-scan parquet-scan.cc)
- target_link_libraries(parquet-scan ${LINK_LIBS}
- parquet_static)
+ target_link_libraries(parquet-scan parquet_static)
endif()