[GitHub] thrift pull request #1386: Upgrade netcore project to netstandard 2.0 & 1.6 ...

[gideonkorir <gi...@git.apache.org>]

GitHub user gideonkorir opened a pull request:

    https://github.com/apache/thrift/pull/1386

    Upgrade netcore project to netstandard 2.0 & 1.6 + new csproj format

    This PR doesn't modify the existing code hence no new tests. I simply upgraded the projects from the obsolete xproj to csproj format and added support for both netstandard 1.6 and 2.0; project now needs dotnet sdk 2.0 to build. I also build a sample at [net core sample](https://github.com/gideonkorir/thriftnetcoresample) that I modified from the ```csharp``` tutorial.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gideonkorir/thrift upgradenetcore

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1386.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1386
    
----
commit b13010c1e9281039d0f8f190c9b627aefd769874
Author: Korir <gi...@gmail.com>
Date:   2017-10-04T17:30:41Z

    Upgrade netcore project to netstandard 2.0 & 1.6 + new csproj format

----


---

[GitHub] thrift pull request #1386: Thift THRIFT-4350 - Upgrade netcore project to ne...

[gideonkorir <gi...@git.apache.org>]

Github user gideonkorir closed the pull request at:

    https://github.com/apache/thrift/pull/1386


---

[GitHub] thrift issue #1386: Thift THRIFT-4350 - Upgrade netcore project to netstanda...

[gideonkorir <gi...@git.apache.org>]

Github user gideonkorir commented on the issue:

    https://github.com/apache/thrift/pull/1386
  
    Closing this in favor of [jeking3 pr](https://github.com/apache/thrift/pull/1379/commits/23bbb439a11e90fe4ac9c6fa9037520cc45b0fe2)


---