You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Ian Boston (JIRA)" <ji...@apache.org> on 2010/07/02 23:42:50 UTC
[jira] Created: (SLING-1583) Recent changes to content loader
swallow "name" property in nodes, which was previously used only for
Princiapls, breaks existing code.
Recent changes to content loader swallow "name" property in nodes, which was previously used only for Princiapls, breaks existing code.
---------------------------------------------------------------------------------------------------------------------------------------
Key: SLING-1583
URL: https://issues.apache.org/jira/browse/SLING-1583
Project: Sling
Issue Type: Bug
Components: JCR
Affects Versions: JCR ContentLoader 2.0.8
Reporter: Ian Boston
Assignee: Ian Boston
Fix For: JCR ContentLoader 2.0.8
Name should be changed to something that wont be used in a node property, eg :name and added to the ignore list for node properties.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-1583) Recent changes to content loader
swallow "name" property in nodes, which was previously used only for
Princiapls, breaks existing code.
Posted by "Justin Edelson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Edelson closed SLING-1583.
---------------------------------
> Recent changes to content loader swallow "name" property in nodes, which was previously used only for Princiapls, breaks existing code.
> ---------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-1583
> URL: https://issues.apache.org/jira/browse/SLING-1583
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Affects Versions: JCR ContentLoader 2.1.0
> Reporter: Ian Boston
> Assignee: Ian Boston
> Fix For: JCR ContentLoader 2.1.0
>
>
> Name should be changed to something that wont be used in a node property, eg :name and added to the ignore list for node properties.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (SLING-1583) Recent changes to content loader swallow "name" property in nodes, which was previously used only for Princiapls, breaks existing code.
Posted by Ian Boston <ia...@gmail.com>.
Eric
Thanks for fixing this properly, and so quickly, my patch was just a
hack to get out of a hole by comparison.
I've had a look at your commit and I can't see any problems in this
area.
Thanks
Ian
Sent from my iPhone
On 3 Jul 2010, at 00:33, "Eric Norman (JIRA)" <ji...@apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/SLING-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12884857#action_12884857
> ]
>
> Eric Norman commented on SLING-1583:
> ------------------------------------
>
> Sorry about that. I just resolved the remaining part of SLING-1172
> which now removes the need for that "name" property in the JSON.
> The unit tests pass locally, but please review to ensure your use
> case still functions properly.
>
>> Recent changes to content loader swallow "name" property in nodes,
>> which was previously used only for Princiapls, breaks existing code.
>> ---
>> ---
>> ---
>> ---
>> ---
>> ---
>> ---
>> ---
>> ---
>> ---
>> ---
>> ---
>> ---
>> ---
>> ---
>> ---
>> ---
>> ---
>> ---
>> ---
>> ---
>> ---
>> ---------------------------------------------------------------------
>>
>> Key: SLING-1583
>> URL: https://issues.apache.org/jira/browse/SLING-1583
>> Project: Sling
>> Issue Type: Bug
>> Components: JCR
>> Affects Versions: JCR ContentLoader 2.0.8
>> Reporter: Ian Boston
>> Assignee: Ian Boston
>> Fix For: JCR ContentLoader 2.0.8
>>
>>
>> Name should be changed to something that wont be used in a node
>> property, eg :name and added to the ignore list for node properties.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
[jira] Commented: (SLING-1583) Recent changes to content loader
swallow "name" property in nodes, which was previously used only for
Princiapls, breaks existing code.
Posted by "Eric Norman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12884857#action_12884857 ]
Eric Norman commented on SLING-1583:
------------------------------------
Sorry about that. I just resolved the remaining part of SLING-1172 which now removes the need for that "name" property in the JSON. The unit tests pass locally, but please review to ensure your use case still functions properly.
> Recent changes to content loader swallow "name" property in nodes, which was previously used only for Princiapls, breaks existing code.
> ---------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-1583
> URL: https://issues.apache.org/jira/browse/SLING-1583
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Affects Versions: JCR ContentLoader 2.0.8
> Reporter: Ian Boston
> Assignee: Ian Boston
> Fix For: JCR ContentLoader 2.0.8
>
>
> Name should be changed to something that wont be used in a node property, eg :name and added to the ignore list for node properties.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1583) Recent changes to content loader
swallow "name" property in nodes, which was previously used only for
Princiapls, breaks existing code.
Posted by "Ian Boston (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ian Boston resolved SLING-1583.
-------------------------------
Resolution: Fixed
Fixed, to give the node a name other than the key or file name use :name.
This will not be used as a property.
This only applies to the json format
> Recent changes to content loader swallow "name" property in nodes, which was previously used only for Princiapls, breaks existing code.
> ---------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SLING-1583
> URL: https://issues.apache.org/jira/browse/SLING-1583
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Affects Versions: JCR ContentLoader 2.0.8
> Reporter: Ian Boston
> Assignee: Ian Boston
> Fix For: JCR ContentLoader 2.0.8
>
>
> Name should be changed to something that wont be used in a node property, eg :name and added to the ignore list for node properties.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.