[GitHub] incubator-brooklyn pull request: Feature/async ssh

[grkvlt <gi...@git.apache.org>]

Github user grkvlt commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/358#discussion_r21097265
  
    --- Diff: core/src/main/java/brooklyn/util/internal/ssh/ShellAbstractTool.java ---
    @@ -262,7 +264,112 @@ public ToolAbstractExecScript(Map<String,?> props) {
                 return cmds.build();
             }
     
    +        protected String getSummary() {
    +            String summary = getOptionalVal(props, PROP_SUMMARY);
    +            return (summary != null) ? summary : scriptPath; 
    --- End diff --
    
    Could have used an `Optional.fromNullable(summary).or(scriptPath)` perhaps. Not sure how much more readable that is?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---