You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/08/23 04:24:00 UTC

[jira] [Commented] (FLINK-10201) The batchTestUtil was mistakenly used in some stream sql tests

    [ https://issues.apache.org/jira/browse/FLINK-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589679#comment-16589679 ] 

ASF GitHub Bot commented on FLINK-10201:
----------------------------------------

xccui opened a new pull request #6605: [FLINK-10201] [table] [test] The batchTestUtil was mistakenly used in some stream sql tests
URL: https://github.com/apache/flink/pull/6605
 
 
   ## What is the purpose of the change
   
   This PR fixes two improper test cases that mistakenly use batchTestUtil for stream sql.
   
   ## Brief change log
   
   Replaces the `batchTestUtil` with `streamTestUti`l in `SetOperatorsTest.testValuesWithCast()` and `CorrelateTest.testLeftOuterJoinAsSubQuery()`.
   
   ## Verifying this change
   
   This change is already covered by existing tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> The batchTestUtil was mistakenly used in some stream sql tests
> --------------------------------------------------------------
>
>                 Key: FLINK-10201
>                 URL: https://issues.apache.org/jira/browse/FLINK-10201
>             Project: Flink
>          Issue Type: Test
>          Components: Table API &amp; SQL
>            Reporter: Xingcan Cui
>            Assignee: Xingcan Cui
>            Priority: Minor
>              Labels: pull-request-available
>
> The {{batchTestUtil}} was mistakenly used in stream sql tests {{SetOperatorsTest.testValuesWithCast()}} and {{CorrelateTest.testLeftOuterJoinAsSubQuery()}}. That should be fixed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)