You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/04/21 17:05:21 UTC
Review Request 58622: Document that master message validation is best
effort.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58622/
-----------------------------------------------------------
Review request for mesos and Neil Conway.
Bugs: MESOS-7372
https://issues.apache.org/jira/browse/MESOS-7372
Repository: mesos
Description
-------
Document that master message validation is best effort.
Diffs
-----
src/master/validation.hpp d96287de73ddb30ae2ed841c1b910b0ac6cfa74e
Diff: https://reviews.apache.org/r/58622/diff/1/
Testing
-------
None (no code changes).
Thanks,
James Peach
Re: Review Request 58622: Document that master message validation is
best effort.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58622/
-----------------------------------------------------------
(Updated April 25, 2017, 4:03 p.m.)
Review request for mesos and Neil Conway.
Bugs: MESOS-7372
https://issues.apache.org/jira/browse/MESOS-7372
Repository: mesos
Description
-------
Document that master message validation is best effort.
Diffs (updated)
-----
src/master/validation.hpp d96287de73ddb30ae2ed841c1b910b0ac6cfa74e
Diff: https://reviews.apache.org/r/58622/diff/2/
Changes: https://reviews.apache.org/r/58622/diff/1-2/
Testing
-------
None (no code changes).
Thanks,
James Peach
Re: Review Request 58622: Document that master message validation is
best effort.
Posted by James Peach <jp...@apache.org>.
> On April 24, 2017, 3:56 p.m., Neil Conway wrote:
> > src/master/validation.hpp
> > Lines 65 (patched)
> > <https://reviews.apache.org/r/58622/diff/1/?file=1697510#file1697510line65>
> >
> > Can we link to a JIRA here?
>
> James Peach wrote:
> Did you have a specific JIRA in mind? I think MESOS-6903 is intended for this?
>
> Neil Conway wrote:
> I didn't have anything specifically in mind, and MESOS-6903 seems too generic, but when we say "the longer term remedy ...", it would be good to have a corresponding JIRA. Maybe create a new JIRA and mark it as "related" to 6903?
I opened [MESOS-7424](https://issues.apache.org/jira/browse/MESOS-7424).
- James
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58622/#review172797
-----------------------------------------------------------
On April 25, 2017, 4:03 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58622/
> -----------------------------------------------------------
>
> (Updated April 25, 2017, 4:03 p.m.)
>
>
> Review request for mesos and Neil Conway.
>
>
> Bugs: MESOS-7372
> https://issues.apache.org/jira/browse/MESOS-7372
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Document that master message validation is best effort.
>
>
> Diffs
> -----
>
> src/master/validation.hpp d96287de73ddb30ae2ed841c1b910b0ac6cfa74e
>
>
> Diff: https://reviews.apache.org/r/58622/diff/2/
>
>
> Testing
> -------
>
> None (no code changes).
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 58622: Document that master message validation is
best effort.
Posted by Neil Conway <ne...@gmail.com>.
> On April 24, 2017, 3:56 p.m., Neil Conway wrote:
> > src/master/validation.hpp
> > Lines 65 (patched)
> > <https://reviews.apache.org/r/58622/diff/1/?file=1697510#file1697510line65>
> >
> > Can we link to a JIRA here?
>
> James Peach wrote:
> Did you have a specific JIRA in mind? I think MESOS-6903 is intended for this?
I didn't have anything specifically in mind, and MESOS-6903 seems too generic, but when we say "the longer term remedy ...", it would be good to have a corresponding JIRA. Maybe create a new JIRA and mark it as "related" to 6903?
- Neil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58622/#review172797
-----------------------------------------------------------
On April 21, 2017, 5:05 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58622/
> -----------------------------------------------------------
>
> (Updated April 21, 2017, 5:05 p.m.)
>
>
> Review request for mesos and Neil Conway.
>
>
> Bugs: MESOS-7372
> https://issues.apache.org/jira/browse/MESOS-7372
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Document that master message validation is best effort.
>
>
> Diffs
> -----
>
> src/master/validation.hpp d96287de73ddb30ae2ed841c1b910b0ac6cfa74e
>
>
> Diff: https://reviews.apache.org/r/58622/diff/1/
>
>
> Testing
> -------
>
> None (no code changes).
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 58622: Document that master message validation is
best effort.
Posted by James Peach <jp...@apache.org>.
> On April 24, 2017, 3:56 p.m., Neil Conway wrote:
> > src/master/validation.hpp
> > Lines 65 (patched)
> > <https://reviews.apache.org/r/58622/diff/1/?file=1697510#file1697510line65>
> >
> > Can we link to a JIRA here?
Did you have a specific JIRA in mind? I think MESOS-6903 is intended for this?
- James
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58622/#review172797
-----------------------------------------------------------
On April 21, 2017, 5:05 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58622/
> -----------------------------------------------------------
>
> (Updated April 21, 2017, 5:05 p.m.)
>
>
> Review request for mesos and Neil Conway.
>
>
> Bugs: MESOS-7372
> https://issues.apache.org/jira/browse/MESOS-7372
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Document that master message validation is best effort.
>
>
> Diffs
> -----
>
> src/master/validation.hpp d96287de73ddb30ae2ed841c1b910b0ac6cfa74e
>
>
> Diff: https://reviews.apache.org/r/58622/diff/1/
>
>
> Testing
> -------
>
> None (no code changes).
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 58622: Document that master message validation is
best effort.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58622/#review172797
-----------------------------------------------------------
Fix it, then Ship it!
Can you also add a brief comment to the validation calls in `master.cpp`?
src/master/validation.hpp
Lines 65 (patched)
<https://reviews.apache.org/r/58622/#comment245844>
Can we link to a JIRA here?
- Neil Conway
On April 21, 2017, 5:05 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58622/
> -----------------------------------------------------------
>
> (Updated April 21, 2017, 5:05 p.m.)
>
>
> Review request for mesos and Neil Conway.
>
>
> Bugs: MESOS-7372
> https://issues.apache.org/jira/browse/MESOS-7372
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Document that master message validation is best effort.
>
>
> Diffs
> -----
>
> src/master/validation.hpp d96287de73ddb30ae2ed841c1b910b0ac6cfa74e
>
>
> Diff: https://reviews.apache.org/r/58622/diff/1/
>
>
> Testing
> -------
>
> None (no code changes).
>
>
> Thanks,
>
> James Peach
>
>