You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Isabel Jimenez <co...@isabeljimenez.com> on 2015/08/12 20:07:11 UTC
Review Request 37405: Adding HTTP Method check to the scheduler
endpoint
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37405/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-2497
https://issues.apache.org/jira/browse/MESOS-2497
Repository: mesos
Description
-------
Adding HTTP Method check to the scheduler HTTP API endpoint so it accepts only POST
Diffs
-----
src/master/http.cpp 579c009
src/tests/http_api_tests.cpp aef3c4b
Diff: https://reviews.apache.org/r/37405/diff/
Testing
-------
make check
Thanks,
Isabel Jimenez
Re: Review Request 37405: Adding HTTP Method check to the scheduler
endpoint
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37405/#review95315
-----------------------------------------------------------
Ship it!
- Ben Mahler
On Aug. 12, 2015, 8:35 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37405/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2015, 8:35 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2497
> https://issues.apache.org/jira/browse/MESOS-2497
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adding HTTP Method check to the scheduler HTTP API endpoint so it accepts only POST
>
>
> Diffs
> -----
>
> src/master/http.cpp 579c009
> src/tests/http_api_tests.cpp aef3c4b
>
> Diff: https://reviews.apache.org/r/37405/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 37405: Adding HTTP Method check to the scheduler
endpoint
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37405/#review95183
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37403, 37405]
All tests passed.
- Mesos ReviewBot
On Aug. 12, 2015, 8:35 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37405/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2015, 8:35 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2497
> https://issues.apache.org/jira/browse/MESOS-2497
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adding HTTP Method check to the scheduler HTTP API endpoint so it accepts only POST
>
>
> Diffs
> -----
>
> src/master/http.cpp 579c009
> src/tests/http_api_tests.cpp aef3c4b
>
> Diff: https://reviews.apache.org/r/37405/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 37405: Adding HTTP Method check to the scheduler
endpoint
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37405/
-----------------------------------------------------------
(Updated Aug. 12, 2015, 8:35 p.m.)
Review request for mesos and Ben Mahler.
Bugs: MESOS-2497
https://issues.apache.org/jira/browse/MESOS-2497
Repository: mesos
Description
-------
Adding HTTP Method check to the scheduler HTTP API endpoint so it accepts only POST
Diffs (updated)
-----
src/master/http.cpp 579c009
src/tests/http_api_tests.cpp aef3c4b
Diff: https://reviews.apache.org/r/37405/diff/
Testing
-------
make check
Thanks,
Isabel Jimenez
Re: Review Request 37405: Adding HTTP Method check to the scheduler
endpoint
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37405/#review95144
-----------------------------------------------------------
Ship it!
LGTM !
src/tests/http_api_tests.cpp (line 601)
<https://reviews.apache.org/r/37405/#comment149978>
Nit: new line here
- Anand Mazumdar
On Aug. 12, 2015, 6:07 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37405/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2015, 6:07 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2497
> https://issues.apache.org/jira/browse/MESOS-2497
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adding HTTP Method check to the scheduler HTTP API endpoint so it accepts only POST
>
>
> Diffs
> -----
>
> src/master/http.cpp 579c009
> src/tests/http_api_tests.cpp aef3c4b
>
> Diff: https://reviews.apache.org/r/37405/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Isabel Jimenez
>
>