You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/05/15 13:38:51 UTC
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #505: Add: DelegateMetadataReport & RemoteMetadataService
AlexStocks commented on a change in pull request #505:
URL: https://github.com/apache/dubbo-go/pull/505#discussion_r425806822
##########
File path: config/instance/metedata_report.go
##########
@@ -28,14 +28,31 @@ import (
)
var (
- instance report.MetadataReport
- once sync.Once
+ instance report.MetadataReport
+ reportUrl common.URL
+ once sync.Once
)
-// GetMetadataReportInstance ...
-func GetMetadataReportInstance(url *common.URL) report.MetadataReport {
+// InitMetadataReportInstance will create the metadata report instance by the specified metadata report url
+func InitMetadataReportInstance(url *common.URL) report.MetadataReport {
Review comment:
is NewMetadataReportInstance better?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org