[GitHub] [superset] wiktor2200 commented on a diff in pull request #20567: feat(helm): add liveness and readiness for deployment webserver

[GitBox <gi...@apache.org>]

wiktor2200 commented on code in PR #20567:
URL: https://github.com/apache/superset/pull/20567#discussion_r938700695


##########
helm/superset/templates/deployment.yaml:
##########
@@ -120,6 +120,24 @@ spec:
             - name: http
               containerPort: {{ .Values.service.port }}
               protocol: TCP
+          livenessProbe:
+            httpGet:
+              path: /health
+              port: http
+            initialDelaySeconds: {{ .Values.supersetNode.livenessProbe.initialDelaySeconds }}
+            timeoutSeconds: {{ .Values.supersetNode.livenessProbe.timeoutSeconds }}
+            failureThreshold: {{ .Values.supersetNode.livenessProbe.failureThreshold }}
+            periodSeconds: {{ .Values.supersetNode.livenessProbe.periodSeconds }}
+            successThreshold: {{ .Values.supersetNode.livenessProbe.successThreshold }}
+          readinessProbe:
+            httpGet:
+              path: /health
+              port: http
+            initialDelaySeconds: {{ .supersetNode.Values.readinessProbe.initialDelaySeconds }}

Review Comment:
   wrong order in var
   ```suggestion
               initialDelaySeconds: {{ .Values.supersetNode.readinessProbe.initialDelaySeconds }}
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org