[GitHub] [hbase] mnpoonia commented on a change in pull request #2899: HBASE-25523 Region normalizer chore thread is getting killed

[GitBox <gi...@apache.org>]

mnpoonia commented on a change in pull request #2899:
URL: https://github.com/apache/hbase/pull/2899#discussion_r562471287



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java
##########
@@ -222,8 +223,12 @@ public void setMasterRpcServices(MasterRpcServices masterRpcServices) {
   private long getRegionSize(HRegionInfo hri) {
     ServerName sn = masterServices.getAssignmentManager().getRegionStates().
       getRegionServerOfRegion(hri);
-    RegionLoad regionLoad = masterServices.getServerManager().getLoad(sn).
-      getRegionsLoad().get(hri.getRegionName());
+    ServerLoad load = masterServices.getServerManager().getLoad(sn);
+    if (load == null) {
+      LOG.debug(hri.getRegionNameAsString() + " was not found on any server");

Review comment:
       @virajjasani - Yes these changes will have to be done for branch-2 and master also. 
   
   > A tighter check here is isRegionOnline(), first check if the region is online (which ensures the region is not in transition and is assigned), we can even loop a few times to avoid any transient RITs.
   
   @bharathv - I am currently looking at the Merge procedure code will get back to you. But my understanding was if a region is in transition than merge will fail so we will catch that as an exception and move ahead to other regions. But i will look again and confirm this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org