You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/30 07:37:01 UTC

[GitHub] [spark] LuciferYang opened a new pull request, #38043: [SPARK-40607][CORE][DSTREAM][GRAPHX][K8S][MESOS][ML][MLLIB][PYTHON][R][SQL][SS][YARN] Remove redundant string interpolator operations

LuciferYang opened a new pull request, #38043:
URL: https://github.com/apache/spark/pull/38043

   ### What changes were proposed in this pull request?
   This pr remove redundant string interpolator operations in Spark code.
   
   
   ### Why are the changes needed?
   Clean up unnecessary function calls
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   Pass Github Actions


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang commented on pull request #38043: [SPARK-40607][CORE][SQL][MLLIB][SS] Remove redundant string interpolator operations

Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38043:
URL: https://github.com/apache/spark/pull/38043#issuecomment-1269246306

   thanks @srowen 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang closed pull request #38043: [SPARK-40607][CORE][DSTREAM][GRAPHX][K8S][MESOS][ML][MLLIB][PYTHON][R][SQL][SS][YARN] Remove redundant string interpolator operations

Posted by GitBox <gi...@apache.org>.
LuciferYang closed pull request #38043: [SPARK-40607][CORE][DSTREAM][GRAPHX][K8S][MESOS][ML][MLLIB][PYTHON][R][SQL][SS][YARN] Remove redundant string interpolator operations
URL: https://github.com/apache/spark/pull/38043


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #38043: [SPARK-40607][CORE][SQL][MLLIB][SS] Remove redundant string interpolator operations

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38043:
URL: https://github.com/apache/spark/pull/38043#issuecomment-1275492453

   Hey, let's avoid making such changes. I think this kind of stuff is to have a rule and sweep away which is actually rejected in https://github.com/apache/spark/pull/15960.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang commented on pull request #38043: [SPARK-40607][CORE][SQL][SS] Remove redundant string interpolator operations

Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38043:
URL: https://github.com/apache/spark/pull/38043#issuecomment-1261977394

   The amount of change is relatively large. Is it worth doing this?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang commented on pull request #38043: [SPARK-40607][CORE][DSTREAM][GRAPHX][K8S][MESOS][ML][MLLIB][PYTHON][R][SQL][SS][YARN] Remove redundant string interpolator operations

Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38043:
URL: https://github.com/apache/spark/pull/38043#issuecomment-1265601426

   I think the part related to codegen may be worth changing, the part related to logs and exceptions is not so important. Let me revert the part that I don't think is important first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang commented on pull request #38043: [SPARK-40607][CORE][SQL][MLLIB][SS] Remove redundant string interpolator operations

Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38043:
URL: https://github.com/apache/spark/pull/38043#issuecomment-1275551760

   @HyukjinKwon Need to revert? Or do need to backport to other branches? Or keep the status quo?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang commented on pull request #38043: [SPARK-40607][CORE][SQL][SS] Remove redundant string interpolator operations

Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38043:
URL: https://github.com/apache/spark/pull/38043#issuecomment-1261980814

   This pr not include `examples` and `test`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang commented on pull request #38043: [SPARK-40607][CORE][DSTREAM][GRAPHX][K8S][MESOS][ML][MLLIB][PYTHON][R][SQL][SS][YARN] Remove redundant string interpolator operations

Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38043:
URL: https://github.com/apache/spark/pull/38043#issuecomment-1265626178

   Set to draft before change completed
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on pull request #38043: [SPARK-40607][CORE][DSTREAM][GRAPHX][K8S][MESOS][ML][MLLIB][PYTHON][R][SQL][SS][YARN] Remove redundant string interpolator operations

Posted by GitBox <gi...@apache.org>.
srowen commented on PR #38043:
URL: https://github.com/apache/spark/pull/38043#issuecomment-1265587818

   Yeah it's just so much code churn and potential for merge conflicts for very little gain. Are there any of these that seem to be in a hot code path?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on pull request #38043: [SPARK-40607][CORE][SQL][MLLIB][SS] Remove redundant string interpolator operations

Posted by GitBox <gi...@apache.org>.
srowen commented on PR #38043:
URL: https://github.com/apache/spark/pull/38043#issuecomment-1275494315

   Yeah, this was much cut down to instances where it might matter. It's trivial though


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen closed pull request #38043: [SPARK-40607][CORE][SQL][MLLIB][SS] Remove redundant string interpolator operations

Posted by GitBox <gi...@apache.org>.
srowen closed pull request #38043: [SPARK-40607][CORE][SQL][MLLIB][SS] Remove redundant string interpolator operations
URL: https://github.com/apache/spark/pull/38043


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] srowen commented on pull request #38043: [SPARK-40607][CORE][SQL][MLLIB][SS] Remove redundant string interpolator operations

Posted by GitBox <gi...@apache.org>.
srowen commented on PR #38043:
URL: https://github.com/apache/spark/pull/38043#issuecomment-1269085473

   Merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang commented on pull request #38043: [SPARK-40607][CORE][DSTREAM][GRAPHX][K8S][MESOS][ML][MLLIB][PYTHON][R][SQL][SS][YARN] Remove redundant string interpolator operations

Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38043:
URL: https://github.com/apache/spark/pull/38043#issuecomment-1263175506

   The changed code is mainly divided into 3 categories: logs, exceptions, and others, log and exception related codes account for the majority
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang commented on pull request #38043: [SPARK-40607][CORE][DSTREAM][GRAPHX][K8S][MESOS][ML][MLLIB][PYTHON][R][SQL][SS][YARN] Remove redundant string interpolator operations

Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38043:
URL: https://github.com/apache/spark/pull/38043#issuecomment-1263217975

   > The changed code is mainly divided into 3 categories: logs, exceptions, and others, log and exception related codes account for the majority
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang commented on pull request #38043: [SPARK-40607][CORE][SQL][MLLIB][SS] Remove redundant string interpolator operations

Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #38043:
URL: https://github.com/apache/spark/pull/38043#issuecomment-1275503552

   > Hey, let's avoid making such changes. I think this kind of stuff is to have a rule and sweep away which is actually rejected in #15960.
   
   Okay, I see ~ thanks ~
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org