You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuweni.apache.org by GitBox <gi...@apache.org> on 2021/04/01 00:48:20 UTC
[GitHub] [incubator-tuweni] atoulme opened a new pull request #203: Fix IDE warnings on gradle import
atoulme opened a new pull request #203:
URL: https://github.com/apache/incubator-tuweni/pull/203
<!-- Thanks for sending a pull request! Please check out our contribution guidelines: -->
<!-- https://github.com/apache/incubator-tuweni/blob/master/CONTRIBUTING.md -->
## PR description
Fix some warnings that pop up in Intellij.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #203: Fix IDE warnings on gradle import
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #203:
URL: https://github.com/apache/incubator-tuweni/pull/203#issuecomment-811562865
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/203?src=pr&el=h1) Report
> Merging [#203](https://codecov.io/gh/apache/incubator-tuweni/pull/203?src=pr&el=desc) (10cd991) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/e51155bf94059bc33fe3f051bf81f51e304ac510?el=desc) (e51155b) will **decrease** coverage by `0.26%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/203?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #203 +/- ##
============================================
- Coverage 64.57% 64.31% -0.27%
- Complexity 4172 4190 +18
============================================
Files 385 390 +5
Lines 20186 20419 +233
Branches 2622 2653 +31
============================================
+ Hits 13035 13132 +97
- Misses 5695 5821 +126
- Partials 1456 1466 +10
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `46.57% <ø> (+0.03%)` | `0.00 <ø> (ø)` | |
| unit | `59.52% <ø> (-0.22%)` | `0.00 <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/203?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/tuweni/concurrent/coroutines/AsyncCompletion.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/203/diff?src=pr&el=tree#diff-Y29uY3VycmVudC1jb3JvdXRpbmVzL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9jb25jdXJyZW50L2Nvcm91dGluZXMvQXN5bmNDb21wbGV0aW9uLmt0) | `69.64% <0.00%> (-3.58%)` | `0.00% <0.00%> (ø%)` | |
| [...otlin/org/apache/tuweni/devp2p/DiscoveryService.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/203/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRGlzY292ZXJ5U2VydmljZS5rdA==) | `48.93% <0.00%> (-0.95%)` | `0.00% <0.00%> (ø%)` | |
| [.../org/apache/tuweni/stratum/server/StratumServer.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/203/diff?src=pr&el=tree#diff-c3RyYXR1bS9zZXJ2ZXIvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL3N0cmF0dW0vc2VydmVyL1N0cmF0dW1TZXJ2ZXIua3Q=) | `50.00% <0.00%> (ø)` | `6.00% <0.00%> (?%)` | |
| [...ain/kotlin/org/apache/tuweni/stratum/server/PoW.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/203/diff?src=pr&el=tree#diff-c3RyYXR1bS9zZXJ2ZXIvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL3N0cmF0dW0vc2VydmVyL1BvVy5rdA==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [.../apache/tuweni/stratum/server/StratumConnection.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/203/diff?src=pr&el=tree#diff-c3RyYXR1bS9zZXJ2ZXIvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL3N0cmF0dW0vc2VydmVyL1N0cmF0dW1Db25uZWN0aW9uLmt0) | `75.67% <0.00%> (ø)` | `12.00% <0.00%> (?%)` | |
| [...rg/apache/tuweni/stratum/server/StratumProtocol.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/203/diff?src=pr&el=tree#diff-c3RyYXR1bS9zZXJ2ZXIvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL3N0cmF0dW0vc2VydmVyL1N0cmF0dW1Qcm90b2NvbC5rdA==) | `30.06% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...kotlin/org/apache/tuweni/stratum/server/JsonRpc.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/203/diff?src=pr&el=tree#diff-c3RyYXR1bS9zZXJ2ZXIvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvdHV3ZW5pL3N0cmF0dW0vc2VydmVyL0pzb25ScGMua3Q=) | `63.63% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [.../org/apache/tuweni/devp2p/v5/DiscoveryV5Service.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/203/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvRGlzY292ZXJ5VjVTZXJ2aWNlLmt0) | `71.42% <0.00%> (+0.79%)` | `0.00% <0.00%> (ø%)` | |
| [...lin/org/apache/tuweni/devp2p/EthereumNodeRecord.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/203/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvRXRoZXJldW1Ob2RlUmVjb3JkLmt0) | `82.90% <0.00%> (+3.41%)` | `14.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/203?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/203?src=pr&el=footer). Last update [e51155b...10cd991](https://codecov.io/gh/apache/incubator-tuweni/pull/203?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] commented on pull request #203: Fix IDE warnings on gradle import
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #203:
URL: https://github.com/apache/incubator-tuweni/pull/203#issuecomment-811562865
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/203?src=pr&el=h1) Report
> Merging [#203](https://codecov.io/gh/apache/incubator-tuweni/pull/203?src=pr&el=desc) (10cd991) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/e51155bf94059bc33fe3f051bf81f51e304ac510?el=desc) (e51155b) will **decrease** coverage by `5.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/203?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #203 +/- ##
============================================
- Coverage 64.57% 59.52% -5.06%
+ Complexity 4172 3886 -286
============================================
Files 385 365 -20
Lines 20186 20038 -148
Branches 2622 2646 +24
============================================
- Hits 13035 11927 -1108
- Misses 5695 6765 +1070
+ Partials 1456 1346 -110
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| integration | `?` | `?` | |
| unit | `59.52% <ø> (-0.22%)` | `0.00 <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/203?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/tuweni/rlpx/wire/SubProtocol.java](https://codecov.io/gh/apache/incubator-tuweni/pull/203/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/rlpx/wire/SubProtocolIdentifier.java](https://codecov.io/gh/apache/incubator-tuweni/pull/203/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9TdWJQcm90b2NvbElkZW50aWZpZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apache/tuweni/scuttlebutt/rpc/RPCRequestBody.java](https://codecov.io/gh/apache/incubator-tuweni/pull/203/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RCb2R5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [.../apache/tuweni/scuttlebutt/rpc/RPCRequestType.java](https://codecov.io/gh/apache/incubator-tuweni/pull/203/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...apache/tuweni/scuttlebutt/rpc/RPCAsyncRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/203/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ0FzeW5jUmVxdWVzdC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...pache/tuweni/scuttlebutt/rpc/RPCStreamRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/203/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1N0cmVhbVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../rpc/mux/exceptions/RPCRequestFailedException.java](https://codecov.io/gh/apache/incubator-tuweni/pull/203/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL211eC9leGNlcHRpb25zL1JQQ1JlcXVlc3RGYWlsZWRFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...tt/discovery/ScuttlebuttLocalDiscoveryService.java](https://codecov.io/gh/apache/incubator-tuweni/pull/203/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtZGlzY292ZXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvZGlzY292ZXJ5L1NjdXR0bGVidXR0TG9jYWxEaXNjb3ZlcnlTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-82.54%)` | `0.00% <0.00%> (-18.00%)` | |
| [...a/org/apache/tuweni/plumtree/vertx/SocketPeer.java](https://codecov.io/gh/apache/incubator-tuweni/pull/203/diff?src=pr&el=tree#diff-cGx1bXRyZWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9wbHVtdHJlZS92ZXJ0eC9Tb2NrZXRQZWVyLmphdmE=) | `0.00% <0.00%> (-80.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...org/apache/tuweni/rlpx/vertx/VertxRLPxService.java](https://codecov.io/gh/apache/incubator-tuweni/pull/203/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvdmVydHgvVmVydHhSTFB4U2VydmljZS5qYXZh) | `0.00% <0.00%> (-75.74%)` | `0.00% <0.00%> (-31.00%)` | |
| ... and [74 more](https://codecov.io/gh/apache/incubator-tuweni/pull/203/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/203?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/203?src=pr&el=footer). Last update [e51155b...10cd991](https://codecov.io/gh/apache/incubator-tuweni/pull/203?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] atoulme merged pull request #203: Fix IDE warnings on gradle import
Posted by GitBox <gi...@apache.org>.
atoulme merged pull request #203:
URL: https://github.com/apache/incubator-tuweni/pull/203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org