You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/30 20:11:10 UTC
[GitHub] [airflow] mik-laj opened a new pull request #9078: Don't create empty modules for plugins
mik-laj opened a new pull request #9078:
URL: https://github.com/apache/airflow/pull/9078
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [X] Unit tests coverage for changes (not needed for documentation changes)
- [X] Target Github ISSUE in description if exists
- [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [X] Relevant documentation is updated including usage instructions.
- [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #9078: Don't create empty modules for plugins
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #9078:
URL: https://github.com/apache/airflow/pull/9078
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #9078: Don't create empty modules for plugins
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #9078:
URL: https://github.com/apache/airflow/pull/9078#issuecomment-636381764
We create modules that do not contain any content. They are only added to sys.modules, but they cannot be used in any way. I care about it because it makes it difficult to understand the status of the plugins when you execute the [`airflow plugins` command](https://github.com/apache/airflow/pull/9001)
Now when you run the following command
```
AIRFLOW__CORE__PLUGINS_FOLDER=$PWD/airflow/contrib/plugins/ airflow plugins
```
you will see the output below.
```
operators_modules = []
sensors_modules = []
hooks_modules = []
macros_modules = []
executors_modules = []
```
Before
```
operators_modules = [<module 'airflow.operators.metastore_browser'>]
sensors_modules = [<module 'airflow.sensors.metastore_browser'>]
hooks_modules = [<module 'airflow.hooks.metastore_browser'>]
macros_modules = [<module 'airflow.macros.metastore_browser'>]
executors_modules = [<module 'airflow.executors.metastore_browser'>]
```
So thanks to this change you will be able to check which plugins affect which area of the application.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #9078: Don't create empty modules for plugins
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #9078:
URL: https://github.com/apache/airflow/pull/9078#issuecomment-636379607
Some explanation pls :)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org