You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Bogdan Sava <bo...@ing.com> on 2018/05/14 13:12:31 UTC
Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67083/
-----------------------------------------------------------
(Updated May 14, 2018, 1:12 p.m.)
Review request for atlas, Daniela Otelea, David Radley, Graham Wallis, Mandy Chessell, and Ruxandra Rosu.
Repository: atlas
Description
-------
Create configuration for OMAG API in Atlas
Diffs
-----
om-fwk-ocf/pom.xml 8b1cefd
omag-api/pom.xml 2338286
omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerAdministration.java dd19018
omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerCategory.java PRE-CREATION
omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminRESTServices.java PRE-CREATION
omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminResource.java ebc9f2a
omag-server/src/main/java/org/apache/atlas/omag/application/AssetConsumerOMASResource.java PRE-CREATION
omag-server/src/main/java/org/apache/atlas/omag/application/ConnectedAssetOMASResource.java PRE-CREATION
omag-server/src/main/java/org/apache/atlas/omag/application/OMAGApplication.java 88397de
omag-server/src/main/java/org/apache/atlas/omag/application/OMAGServerAdminResource.java PRE-CREATION
omag-server/src/main/java/org/apache/atlas/omag/application/OMRSRepositoryResource.java PRE-CREATION
omag-server/src/main/resources/application.properties PRE-CREATION
omas-assetconsumer/pom.xml 29935e7
omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/client/AssetConsumer.java 80a98f5
omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/publisher/AssetConsumerPublisher.java
omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerRESTServices.java 967be5a
omas-connectedasset/README.md 2f431df
omas-connectedasset/pom.xml 219c972
omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/ConnectedAssetRESTServices.java 8ae6c37
omrs/pom.xml 50b9898
omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 7ae87c6
omrs/src/main/java/org/apache/atlas/omrs/rest/server/OMRSRepositoryRESTServices.java 5948482
omrs/src/test/java/org/apache/atlas/omrs/archivemanager/opentypes/TestOpenMetadataTypesArchive.java 3f85317
omrs/src/test/java/org/apache/atlas/omrs/archivemanager/store/TestOMRSArchiveBuilder.java ccf0de6
webapp/src/main/webapp/WEB-INF/applicationContext.xml 2ecd8d1
webapp/src/main/webapp/WEB-INF/web.xml 23dc063
Diff: https://reviews.apache.org/r/67083/diff/1/
Testing
-------
Create configuration for OMAG API in Atlas using Spring MVC Dispatcher servlet.
Change base URL for the API to "/open-metadata/access-services"
Clean maven unused dependenies
File Attachments
----------------
Added apache licence to a properties file
https://reviews.apache.org/media/uploaded/files/2018/05/11/77fbc4f6-b16a-42f9-983c-261f70f3ca9f__0002-ATLAS-2665-Added-apache-licence-to-properties-file.patch
0003-ATLAS-2665-comments-fixed.patch
https://reviews.apache.org/media/uploaded/files/2018/05/11/004f018b-1ee5-4da1-91d4-b50f4913298d__0003-ATLAS-2665-comments-fixed.patch
Thanks,
Bogdan Sava
Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas
Posted by Mandy Chessell <ma...@uk.ibm.com>.
> On May 15, 2018, 3:53 p.m., David Radley wrote:
> > omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerAdministration.java
> > Line 180 (original), 181 (patched)
> > <https://reviews.apache.org/r/67083/diff/3/?file=2023008#file2023008line188>
> >
> > you have remove the throws clause in the latest patch but the javadoc is left in. I suggest leaving in the throws clause. I think they are there to indicate these are the exceptions that any validation code we add in the future might throw
The Javadoc does not have the @throws tag in it any more. The documentation you see describes the different responses supported by the VoidResponse structure. The Javadoc in the patch is correct.
- Mandy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67083/#review203130
-----------------------------------------------------------
On May 15, 2018, 1:35 p.m., Bogdan Sava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67083/
> -----------------------------------------------------------
>
> (Updated May 15, 2018, 1:35 p.m.)
>
>
> Review request for atlas, Daniela Otelea, David Radley, Graham Wallis, Mandy Chessell, and Ruxandra Rosu.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Create configuration for OMAG API in Atlas
>
>
> Diffs
> -----
>
> om-fwk-ocf/pom.xml 8b1cefd
> omag-api/pom.xml 2338286
> omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerAdministration.java dd19018
> omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerCategory.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminRESTServices.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminResource.java ebc9f2a
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/OMAGServerAdminResource.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceDescription.java 1a15215
> omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceRegistration.java c2950c4
> omag-server/pom.xml 527c5c3
> omag-server/src/main/java/org/apache/atlas/omag/application/OMAGApplication.java 88397de
> omag-server/src/main/resources/application.properties PRE-CREATION
> omas-assetconsumer/pom.xml 29935e7
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/client/AssetConsumer.java 80a98f5
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/publisher/AssetConsumerPublisher.java
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerRESTServices.java 967be5a
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/spring/AssetConsumerOMASResource.java PRE-CREATION
> omas-connectedasset/README.md 2f431df
> omas-connectedasset/pom.xml 219c972
> omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/ConnectedAssetRESTServices.java 8ae6c37
> omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/spring/ConnectedAssetOMASResource.java PRE-CREATION
> omrs/pom.xml 50b9898
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 7ae87c6
> omrs/src/main/java/org/apache/atlas/omrs/rest/server/OMRSRepositoryRESTServices.java 5948482
> omrs/src/main/java/org/apache/atlas/omrs/rest/server/spring/OMRSRepositoryResource.java PRE-CREATION
> omrs/src/test/java/org/apache/atlas/omrs/archivemanager/opentypes/TestOpenMetadataTypesArchive.java 3f85317
> omrs/src/test/java/org/apache/atlas/omrs/archivemanager/store/TestOMRSArchiveBuilder.java ccf0de6
> webapp/pom.xml 03b8408
> webapp/src/main/webapp/WEB-INF/applicationContext.xml 2ecd8d1
> webapp/src/main/webapp/WEB-INF/openMetadataContext.xml PRE-CREATION
> webapp/src/main/webapp/WEB-INF/web.xml 23dc063
>
>
> Diff: https://reviews.apache.org/r/67083/diff/3/
>
>
> Testing
> -------
>
> Create configuration for OMAG API in Atlas using Spring MVC Dispatcher servlet.
>
>
> Change base URL for the API to "/open-metadata/access-services"
>
>
> Clean maven unused dependenies
>
> The Jira issue is https://issues.apache.org/jira/browse/ATLAS-2665
>
>
> File Attachments
> ----------------
>
> Added apache licence to a properties file
> https://reviews.apache.org/media/uploaded/files/2018/05/11/77fbc4f6-b16a-42f9-983c-261f70f3ca9f__0002-ATLAS-2665-Added-apache-licence-to-properties-file.patch
> 0003-ATLAS-2665-comments-fixed.patch
> https://reviews.apache.org/media/uploaded/files/2018/05/11/004f018b-1ee5-4da1-91d4-b50f4913298d__0003-ATLAS-2665-comments-fixed.patch
> ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
> https://reviews.apache.org/media/uploaded/files/2018/05/14/160f8499-661d-4fa9-8ce1-afe4bd88b723__ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
>
>
> Thanks,
>
> Bogdan Sava
>
>
Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas
Posted by Mandy Chessell <ma...@uk.ibm.com>.
> On May 15, 2018, 3:53 p.m., David Radley wrote:
> > omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerRESTServices.java
> > Line 230 (original), 211 (patched)
> > <https://reviews.apache.org/r/67083/diff/3/?file=2023021#file2023021line230>
> >
> > this change have removed the PathVariable and RequestParam annotations, it looks like we have lost inforration about which parameters are PathVariables and which are RequestParams
>
> Mandy Chessell wrote:
> It is correct that the annotations have been removed from this file - the annotation should be in the Resource file
The patch is correct without changes
- Mandy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67083/#review203130
-----------------------------------------------------------
On May 15, 2018, 1:35 p.m., Bogdan Sava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67083/
> -----------------------------------------------------------
>
> (Updated May 15, 2018, 1:35 p.m.)
>
>
> Review request for atlas, Daniela Otelea, David Radley, Graham Wallis, Mandy Chessell, and Ruxandra Rosu.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Create configuration for OMAG API in Atlas
>
>
> Diffs
> -----
>
> om-fwk-ocf/pom.xml 8b1cefd
> omag-api/pom.xml 2338286
> omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerAdministration.java dd19018
> omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerCategory.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminRESTServices.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminResource.java ebc9f2a
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/OMAGServerAdminResource.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceDescription.java 1a15215
> omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceRegistration.java c2950c4
> omag-server/pom.xml 527c5c3
> omag-server/src/main/java/org/apache/atlas/omag/application/OMAGApplication.java 88397de
> omag-server/src/main/resources/application.properties PRE-CREATION
> omas-assetconsumer/pom.xml 29935e7
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/client/AssetConsumer.java 80a98f5
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/publisher/AssetConsumerPublisher.java
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerRESTServices.java 967be5a
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/spring/AssetConsumerOMASResource.java PRE-CREATION
> omas-connectedasset/README.md 2f431df
> omas-connectedasset/pom.xml 219c972
> omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/ConnectedAssetRESTServices.java 8ae6c37
> omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/spring/ConnectedAssetOMASResource.java PRE-CREATION
> omrs/pom.xml 50b9898
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 7ae87c6
> omrs/src/main/java/org/apache/atlas/omrs/rest/server/OMRSRepositoryRESTServices.java 5948482
> omrs/src/main/java/org/apache/atlas/omrs/rest/server/spring/OMRSRepositoryResource.java PRE-CREATION
> omrs/src/test/java/org/apache/atlas/omrs/archivemanager/opentypes/TestOpenMetadataTypesArchive.java 3f85317
> omrs/src/test/java/org/apache/atlas/omrs/archivemanager/store/TestOMRSArchiveBuilder.java ccf0de6
> webapp/pom.xml 03b8408
> webapp/src/main/webapp/WEB-INF/applicationContext.xml 2ecd8d1
> webapp/src/main/webapp/WEB-INF/openMetadataContext.xml PRE-CREATION
> webapp/src/main/webapp/WEB-INF/web.xml 23dc063
>
>
> Diff: https://reviews.apache.org/r/67083/diff/3/
>
>
> Testing
> -------
>
> Create configuration for OMAG API in Atlas using Spring MVC Dispatcher servlet.
>
>
> Change base URL for the API to "/open-metadata/access-services"
>
>
> Clean maven unused dependenies
>
> The Jira issue is https://issues.apache.org/jira/browse/ATLAS-2665
>
>
> File Attachments
> ----------------
>
> Added apache licence to a properties file
> https://reviews.apache.org/media/uploaded/files/2018/05/11/77fbc4f6-b16a-42f9-983c-261f70f3ca9f__0002-ATLAS-2665-Added-apache-licence-to-properties-file.patch
> 0003-ATLAS-2665-comments-fixed.patch
> https://reviews.apache.org/media/uploaded/files/2018/05/11/004f018b-1ee5-4da1-91d4-b50f4913298d__0003-ATLAS-2665-comments-fixed.patch
> ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
> https://reviews.apache.org/media/uploaded/files/2018/05/14/160f8499-661d-4fa9-8ce1-afe4bd88b723__ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
>
>
> Thanks,
>
> Bogdan Sava
>
>
Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas
Posted by Mandy Chessell <ma...@uk.ibm.com>.
> On May 15, 2018, 3:53 p.m., David Radley wrote:
> > omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminRESTServices.java
> > Lines 1143 (patched)
> > <https://reviews.apache.org/r/67083/diff/3/?file=2023010#file2023010line1143>
> >
> > javadoc of exceptions mismatches the code. It is important this matches as it will be the basis of the the swagger. This is the same for many methods
The Javadoc is correct in the patch. Notice there is no @throws tag. The Javadoc lists the possible responses (including exceptions) that can be returned in the response structure.
- Mandy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67083/#review203130
-----------------------------------------------------------
On May 15, 2018, 1:35 p.m., Bogdan Sava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67083/
> -----------------------------------------------------------
>
> (Updated May 15, 2018, 1:35 p.m.)
>
>
> Review request for atlas, Daniela Otelea, David Radley, Graham Wallis, Mandy Chessell, and Ruxandra Rosu.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Create configuration for OMAG API in Atlas
>
>
> Diffs
> -----
>
> om-fwk-ocf/pom.xml 8b1cefd
> omag-api/pom.xml 2338286
> omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerAdministration.java dd19018
> omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerCategory.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminRESTServices.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminResource.java ebc9f2a
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/OMAGServerAdminResource.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceDescription.java 1a15215
> omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceRegistration.java c2950c4
> omag-server/pom.xml 527c5c3
> omag-server/src/main/java/org/apache/atlas/omag/application/OMAGApplication.java 88397de
> omag-server/src/main/resources/application.properties PRE-CREATION
> omas-assetconsumer/pom.xml 29935e7
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/client/AssetConsumer.java 80a98f5
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/publisher/AssetConsumerPublisher.java
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerRESTServices.java 967be5a
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/spring/AssetConsumerOMASResource.java PRE-CREATION
> omas-connectedasset/README.md 2f431df
> omas-connectedasset/pom.xml 219c972
> omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/ConnectedAssetRESTServices.java 8ae6c37
> omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/spring/ConnectedAssetOMASResource.java PRE-CREATION
> omrs/pom.xml 50b9898
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 7ae87c6
> omrs/src/main/java/org/apache/atlas/omrs/rest/server/OMRSRepositoryRESTServices.java 5948482
> omrs/src/main/java/org/apache/atlas/omrs/rest/server/spring/OMRSRepositoryResource.java PRE-CREATION
> omrs/src/test/java/org/apache/atlas/omrs/archivemanager/opentypes/TestOpenMetadataTypesArchive.java 3f85317
> omrs/src/test/java/org/apache/atlas/omrs/archivemanager/store/TestOMRSArchiveBuilder.java ccf0de6
> webapp/pom.xml 03b8408
> webapp/src/main/webapp/WEB-INF/applicationContext.xml 2ecd8d1
> webapp/src/main/webapp/WEB-INF/openMetadataContext.xml PRE-CREATION
> webapp/src/main/webapp/WEB-INF/web.xml 23dc063
>
>
> Diff: https://reviews.apache.org/r/67083/diff/3/
>
>
> Testing
> -------
>
> Create configuration for OMAG API in Atlas using Spring MVC Dispatcher servlet.
>
>
> Change base URL for the API to "/open-metadata/access-services"
>
>
> Clean maven unused dependenies
>
> The Jira issue is https://issues.apache.org/jira/browse/ATLAS-2665
>
>
> File Attachments
> ----------------
>
> Added apache licence to a properties file
> https://reviews.apache.org/media/uploaded/files/2018/05/11/77fbc4f6-b16a-42f9-983c-261f70f3ca9f__0002-ATLAS-2665-Added-apache-licence-to-properties-file.patch
> 0003-ATLAS-2665-comments-fixed.patch
> https://reviews.apache.org/media/uploaded/files/2018/05/11/004f018b-1ee5-4da1-91d4-b50f4913298d__0003-ATLAS-2665-comments-fixed.patch
> ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
> https://reviews.apache.org/media/uploaded/files/2018/05/14/160f8499-661d-4fa9-8ce1-afe4bd88b723__ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
>
>
> Thanks,
>
> Bogdan Sava
>
>
Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas
Posted by Mandy Chessell <ma...@uk.ibm.com>.
> On May 15, 2018, 3:53 p.m., David Radley wrote:
> > omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerRESTServices.java
> > Line 230 (original), 211 (patched)
> > <https://reviews.apache.org/r/67083/diff/3/?file=2023021#file2023021line230>
> >
> > this change have removed the PathVariable and RequestParam annotations, it looks like we have lost inforration about which parameters are PathVariables and which are RequestParams
It is correct that the annotations have been removed from this file - the annotation should be in the Resource file
- Mandy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67083/#review203130
-----------------------------------------------------------
On May 15, 2018, 1:35 p.m., Bogdan Sava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67083/
> -----------------------------------------------------------
>
> (Updated May 15, 2018, 1:35 p.m.)
>
>
> Review request for atlas, Daniela Otelea, David Radley, Graham Wallis, Mandy Chessell, and Ruxandra Rosu.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Create configuration for OMAG API in Atlas
>
>
> Diffs
> -----
>
> om-fwk-ocf/pom.xml 8b1cefd
> omag-api/pom.xml 2338286
> omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerAdministration.java dd19018
> omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerCategory.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminRESTServices.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminResource.java ebc9f2a
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/OMAGServerAdminResource.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceDescription.java 1a15215
> omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceRegistration.java c2950c4
> omag-server/pom.xml 527c5c3
> omag-server/src/main/java/org/apache/atlas/omag/application/OMAGApplication.java 88397de
> omag-server/src/main/resources/application.properties PRE-CREATION
> omas-assetconsumer/pom.xml 29935e7
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/client/AssetConsumer.java 80a98f5
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/publisher/AssetConsumerPublisher.java
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerRESTServices.java 967be5a
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/spring/AssetConsumerOMASResource.java PRE-CREATION
> omas-connectedasset/README.md 2f431df
> omas-connectedasset/pom.xml 219c972
> omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/ConnectedAssetRESTServices.java 8ae6c37
> omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/spring/ConnectedAssetOMASResource.java PRE-CREATION
> omrs/pom.xml 50b9898
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 7ae87c6
> omrs/src/main/java/org/apache/atlas/omrs/rest/server/OMRSRepositoryRESTServices.java 5948482
> omrs/src/main/java/org/apache/atlas/omrs/rest/server/spring/OMRSRepositoryResource.java PRE-CREATION
> omrs/src/test/java/org/apache/atlas/omrs/archivemanager/opentypes/TestOpenMetadataTypesArchive.java 3f85317
> omrs/src/test/java/org/apache/atlas/omrs/archivemanager/store/TestOMRSArchiveBuilder.java ccf0de6
> webapp/pom.xml 03b8408
> webapp/src/main/webapp/WEB-INF/applicationContext.xml 2ecd8d1
> webapp/src/main/webapp/WEB-INF/openMetadataContext.xml PRE-CREATION
> webapp/src/main/webapp/WEB-INF/web.xml 23dc063
>
>
> Diff: https://reviews.apache.org/r/67083/diff/3/
>
>
> Testing
> -------
>
> Create configuration for OMAG API in Atlas using Spring MVC Dispatcher servlet.
>
>
> Change base URL for the API to "/open-metadata/access-services"
>
>
> Clean maven unused dependenies
>
> The Jira issue is https://issues.apache.org/jira/browse/ATLAS-2665
>
>
> File Attachments
> ----------------
>
> Added apache licence to a properties file
> https://reviews.apache.org/media/uploaded/files/2018/05/11/77fbc4f6-b16a-42f9-983c-261f70f3ca9f__0002-ATLAS-2665-Added-apache-licence-to-properties-file.patch
> 0003-ATLAS-2665-comments-fixed.patch
> https://reviews.apache.org/media/uploaded/files/2018/05/11/004f018b-1ee5-4da1-91d4-b50f4913298d__0003-ATLAS-2665-comments-fixed.patch
> ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
> https://reviews.apache.org/media/uploaded/files/2018/05/14/160f8499-661d-4fa9-8ce1-afe4bd88b723__ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
>
>
> Thanks,
>
> Bogdan Sava
>
>
Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas
Posted by David Radley <da...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67083/#review203130
-----------------------------------------------------------
omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerAdministration.java
Line 180 (original), 181 (patched)
<https://reviews.apache.org/r/67083/#comment285212>
you have remove the throws clause in the latest patch but the javadoc is left in. I suggest leaving in the throws clause. I think they are there to indicate these are the exceptions that any validation code we add in the future might throw
omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminRESTServices.java
Lines 1143 (patched)
<https://reviews.apache.org/r/67083/#comment285213>
javadoc of exceptions mismatches the code. It is important this matches as it will be the basis of the the swagger. This is the same for many methods
omag-server/src/main/java/org/apache/atlas/omag/application/OMAGApplication.java
Line 28 (original), 27 (patched)
<https://reviews.apache.org/r/67083/#comment285210>
what about omrs?
omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerRESTServices.java
Line 230 (original), 211 (patched)
<https://reviews.apache.org/r/67083/#comment285211>
this change have removed the PathVariable and RequestParam annotations, it looks like we have lost inforration about which parameters are PathVariables and which are RequestParams
omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java
Line 306 (original), 306 (patched)
<https://reviews.apache.org/r/67083/#comment285214>
shouldn't this url include the open-metadata segment?
webapp/src/main/webapp/WEB-INF/openMetadataContext.xml
Lines 2 (patched)
<https://reviews.apache.org/r/67083/#comment285216>
this licenses has bad characters that are casing git rebase errors when I apply the patch.
- David Radley
On May 15, 2018, 1:35 p.m., Bogdan Sava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67083/
> -----------------------------------------------------------
>
> (Updated May 15, 2018, 1:35 p.m.)
>
>
> Review request for atlas, Daniela Otelea, David Radley, Graham Wallis, Mandy Chessell, and Ruxandra Rosu.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Create configuration for OMAG API in Atlas
>
>
> Diffs
> -----
>
> om-fwk-ocf/pom.xml 8b1cefd
> omag-api/pom.xml 2338286
> omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerAdministration.java dd19018
> omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerCategory.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminRESTServices.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminResource.java ebc9f2a
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/OMAGServerAdminResource.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceDescription.java 1a15215
> omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceRegistration.java c2950c4
> omag-server/pom.xml 527c5c3
> omag-server/src/main/java/org/apache/atlas/omag/application/OMAGApplication.java 88397de
> omag-server/src/main/resources/application.properties PRE-CREATION
> omas-assetconsumer/pom.xml 29935e7
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/client/AssetConsumer.java 80a98f5
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/publisher/AssetConsumerPublisher.java
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerRESTServices.java 967be5a
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/spring/AssetConsumerOMASResource.java PRE-CREATION
> omas-connectedasset/README.md 2f431df
> omas-connectedasset/pom.xml 219c972
> omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/ConnectedAssetRESTServices.java 8ae6c37
> omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/spring/ConnectedAssetOMASResource.java PRE-CREATION
> omrs/pom.xml 50b9898
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 7ae87c6
> omrs/src/main/java/org/apache/atlas/omrs/rest/server/OMRSRepositoryRESTServices.java 5948482
> omrs/src/main/java/org/apache/atlas/omrs/rest/server/spring/OMRSRepositoryResource.java PRE-CREATION
> omrs/src/test/java/org/apache/atlas/omrs/archivemanager/opentypes/TestOpenMetadataTypesArchive.java 3f85317
> omrs/src/test/java/org/apache/atlas/omrs/archivemanager/store/TestOMRSArchiveBuilder.java ccf0de6
> webapp/pom.xml 03b8408
> webapp/src/main/webapp/WEB-INF/applicationContext.xml 2ecd8d1
> webapp/src/main/webapp/WEB-INF/openMetadataContext.xml PRE-CREATION
> webapp/src/main/webapp/WEB-INF/web.xml 23dc063
>
>
> Diff: https://reviews.apache.org/r/67083/diff/3/
>
>
> Testing
> -------
>
> Create configuration for OMAG API in Atlas using Spring MVC Dispatcher servlet.
>
>
> Change base URL for the API to "/open-metadata/access-services"
>
>
> Clean maven unused dependenies
>
> The Jira issue is https://issues.apache.org/jira/browse/ATLAS-2665
>
>
> File Attachments
> ----------------
>
> Added apache licence to a properties file
> https://reviews.apache.org/media/uploaded/files/2018/05/11/77fbc4f6-b16a-42f9-983c-261f70f3ca9f__0002-ATLAS-2665-Added-apache-licence-to-properties-file.patch
> 0003-ATLAS-2665-comments-fixed.patch
> https://reviews.apache.org/media/uploaded/files/2018/05/11/004f018b-1ee5-4da1-91d4-b50f4913298d__0003-ATLAS-2665-comments-fixed.patch
> ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
> https://reviews.apache.org/media/uploaded/files/2018/05/14/160f8499-661d-4fa9-8ce1-afe4bd88b723__ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
>
>
> Thanks,
>
> Bogdan Sava
>
>
Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas
Posted by Mandy Chessell <ma...@uk.ibm.com>.
Hello Graham, Bogdan
We still need two interfaces for the OMAG Admin - one for the OMAG Server
and one for Atlas Server. The Atlas Server one should turn on the Atlas
Graph repository connector once open metadata is enabled. There should
not be an API call to do this. The OMAG Server should support none,
in-memory and repository proxy modes for the local repository.
All the best
Mandy
___________________________________________
Mandy Chessell CBE FREng CEng FBCS
IBM Distinguished Engineer
Master Inventor
Member of the IBM Academy of Technology
Visiting Professor, Department of Computer Science, University of
Sheffield
Email: mandy_chessell@uk.ibm.com
LinkedIn: http://www.linkedin.com/pub/mandy-chessell/22/897/a49
Assistant: Janet Brooks - jsbrooks12@uk.ibm.com
From: Graham Wallis <gr...@uk.ibm.com>
To: Mandy Chessell <ma...@uk.ibm.com>, Graham Wallis
<gr...@uk.ibm.com>, Daniela Otelea
<da...@ing.com>, Ruxandra Rosu
<ru...@ing.com>, David Radley <da...@apache.org>
Cc: Bogdan Sava <bo...@ing.com>, atlas
<de...@atlas.incubator.apache.org>
Date: 16/05/2018 14:52
Subject: Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in
Atlas
Sent by: Graham Wallis <no...@reviews.apache.org>
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67083/
Hi Bogdan
I just raised 3 issues - but they are all related. The key one is that I
need to be able to set repository mode to LOCAL_GRAPH_REPOSITORY (for
running in Atlas).
This method was removed when there were two versions of the REST wrapper
(one for inside Atlas, another for the OMAG Server). Now we have one
wrapper I need a way of setting the local graph mode.
The other two issues are just to accommodate the addition of the above and
make them consistent.
- Graham Wallis
On May 15th, 2018, 1:35 p.m. UTC, Bogdan Sava wrote:
Review request for atlas, Daniela Otelea, David Radley, Graham Wallis,
Mandy Chessell, and Ruxandra Rosu.
By Bogdan Sava.
Updated May 15, 2018, 1:35 p.m.
Repository: atlas
Description
Create configuration for OMAG API in Atlas
Testing
Create configuration for OMAG API in Atlas using Spring MVC Dispatcher
servlet.
Change base URL for the API to "/open-metadata/access-services"
Clean maven unused dependenies
The Jira issue is https://issues.apache.org/jira/browse/ATLAS-2665
Diffs
om-fwk-ocf/pom.xml (8b1cefd)
omag-api/pom.xml (2338286)
omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerAdministration.java
(dd19018)
omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerCategory.java
(PRE-CREATION)
omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminRESTServices.java
(PRE-CREATION)
omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminResource.java
(ebc9f2a)
omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/OMAGServerAdminResource.java
(PRE-CREATION)
omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceDescription.java
(1a15215)
omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceRegistration.java
(c2950c4)
omag-server/pom.xml (527c5c3)
omag-server/src/main/java/org/apache/atlas/omag/application/OMAGApplication.java
(88397de)
omag-server/src/main/resources/application.properties (PRE-CREATION)
omas-assetconsumer/pom.xml (29935e7)
omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/client/AssetConsumer.java
(80a98f5)
omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/publisher/AssetConsumerPublisher.java
()
omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerRESTServices.java
(967be5a)
omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/spring/AssetConsumerOMASResource.java
(PRE-CREATION)
omas-connectedasset/README.md (2f431df)
omas-connectedasset/pom.xml (219c972)
omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/ConnectedAssetRESTServices.java
(8ae6c37)
omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/spring/ConnectedAssetOMASResource.java
(PRE-CREATION)
omrs/pom.xml (50b9898)
omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java
(7ae87c6)
omrs/src/main/java/org/apache/atlas/omrs/rest/server/OMRSRepositoryRESTServices.java
(5948482)
omrs/src/main/java/org/apache/atlas/omrs/rest/server/spring/OMRSRepositoryResource.java
(PRE-CREATION)
omrs/src/test/java/org/apache/atlas/omrs/archivemanager/opentypes/TestOpenMetadataTypesArchive.java
(3f85317)
omrs/src/test/java/org/apache/atlas/omrs/archivemanager/store/TestOMRSArchiveBuilder.java
(ccf0de6)
webapp/pom.xml (03b8408)
webapp/src/main/webapp/WEB-INF/applicationContext.xml (2ecd8d1)
webapp/src/main/webapp/WEB-INF/openMetadataContext.xml (PRE-CREATION)
webapp/src/main/webapp/WEB-INF/web.xml (23dc063)
View Diff
File Attachments
Added apache licence to a properties file
0003-ATLAS-2665-comments-fixed.patch
ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas
Posted by Graham Wallis <gr...@uk.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67083/#review203220
-----------------------------------------------------------
Hi Bogdan
I just raised 3 issues - but they are all related. The key one is that I need to be able to set repository mode to LOCAL_GRAPH_REPOSITORY (for running in Atlas).
This method was removed when there were two versions of the REST wrapper (one for inside Atlas, another for the OMAG Server). Now we have one wrapper I need a way of setting the local graph mode.
The other two issues are just to accommodate the addition of the above and make them consistent.
- Graham Wallis
On May 15, 2018, 1:35 p.m., Bogdan Sava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67083/
> -----------------------------------------------------------
>
> (Updated May 15, 2018, 1:35 p.m.)
>
>
> Review request for atlas, Daniela Otelea, David Radley, Graham Wallis, Mandy Chessell, and Ruxandra Rosu.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Create configuration for OMAG API in Atlas
>
>
> Diffs
> -----
>
> om-fwk-ocf/pom.xml 8b1cefd
> omag-api/pom.xml 2338286
> omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerAdministration.java dd19018
> omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerCategory.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminRESTServices.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminResource.java ebc9f2a
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/OMAGServerAdminResource.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceDescription.java 1a15215
> omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceRegistration.java c2950c4
> omag-server/pom.xml 527c5c3
> omag-server/src/main/java/org/apache/atlas/omag/application/OMAGApplication.java 88397de
> omag-server/src/main/resources/application.properties PRE-CREATION
> omas-assetconsumer/pom.xml 29935e7
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/client/AssetConsumer.java 80a98f5
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/publisher/AssetConsumerPublisher.java
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerRESTServices.java 967be5a
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/spring/AssetConsumerOMASResource.java PRE-CREATION
> omas-connectedasset/README.md 2f431df
> omas-connectedasset/pom.xml 219c972
> omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/ConnectedAssetRESTServices.java 8ae6c37
> omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/spring/ConnectedAssetOMASResource.java PRE-CREATION
> omrs/pom.xml 50b9898
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 7ae87c6
> omrs/src/main/java/org/apache/atlas/omrs/rest/server/OMRSRepositoryRESTServices.java 5948482
> omrs/src/main/java/org/apache/atlas/omrs/rest/server/spring/OMRSRepositoryResource.java PRE-CREATION
> omrs/src/test/java/org/apache/atlas/omrs/archivemanager/opentypes/TestOpenMetadataTypesArchive.java 3f85317
> omrs/src/test/java/org/apache/atlas/omrs/archivemanager/store/TestOMRSArchiveBuilder.java ccf0de6
> webapp/pom.xml 03b8408
> webapp/src/main/webapp/WEB-INF/applicationContext.xml 2ecd8d1
> webapp/src/main/webapp/WEB-INF/openMetadataContext.xml PRE-CREATION
> webapp/src/main/webapp/WEB-INF/web.xml 23dc063
>
>
> Diff: https://reviews.apache.org/r/67083/diff/3/
>
>
> Testing
> -------
>
> Create configuration for OMAG API in Atlas using Spring MVC Dispatcher servlet.
>
>
> Change base URL for the API to "/open-metadata/access-services"
>
>
> Clean maven unused dependenies
>
> The Jira issue is https://issues.apache.org/jira/browse/ATLAS-2665
>
>
> File Attachments
> ----------------
>
> Added apache licence to a properties file
> https://reviews.apache.org/media/uploaded/files/2018/05/11/77fbc4f6-b16a-42f9-983c-261f70f3ca9f__0002-ATLAS-2665-Added-apache-licence-to-properties-file.patch
> 0003-ATLAS-2665-comments-fixed.patch
> https://reviews.apache.org/media/uploaded/files/2018/05/11/004f018b-1ee5-4da1-91d4-b50f4913298d__0003-ATLAS-2665-comments-fixed.patch
> ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
> https://reviews.apache.org/media/uploaded/files/2018/05/14/160f8499-661d-4fa9-8ce1-afe4bd88b723__ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
>
>
> Thanks,
>
> Bogdan Sava
>
>
Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas
Posted by Mandy Chessell <ma...@uk.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67083/#review203261
-----------------------------------------------------------
omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/OMAGServerAdminResource.java
Lines 363 (patched)
<https://reviews.apache.org/r/67083/#comment285363>
This should be access-services because it supplies the configuration for all access services
- Mandy Chessell
On May 16, 2018, 3:49 p.m., Bogdan Sava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67083/
> -----------------------------------------------------------
>
> (Updated May 16, 2018, 3:49 p.m.)
>
>
> Review request for atlas, Daniela Otelea, David Radley, Graham Wallis, Mandy Chessell, and Ruxandra Rosu.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Create configuration for OMAG API in Atlas
>
>
> Diffs
> -----
>
> om-fwk-ocf/pom.xml 8b1cefd
> omag-api/pom.xml 2338286
> omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerAdministration.java dd19018
> omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerCategory.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminRESTServices.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminResource.java ebc9f2a
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/OMAGServerAdminResource.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceDescription.java 1a15215
> omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceRegistration.java c2950c4
> omag-server/pom.xml 527c5c3
> omag-server/src/main/java/org/apache/atlas/omag/application/OMAGApplication.java 88397de
> omag-server/src/main/resources/application.properties PRE-CREATION
> omas-assetconsumer/pom.xml 29935e7
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/client/AssetConsumer.java 80a98f5
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/publisher/AssetConsumerPublisher.java
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerRESTServices.java 967be5a
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/spring/AssetConsumerOMASResource.java PRE-CREATION
> omas-connectedasset/README.md 2f431df
> omas-connectedasset/pom.xml 219c972
> omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/ConnectedAssetRESTServices.java 8ae6c37
> omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/spring/ConnectedAssetOMASResource.java PRE-CREATION
> omrs/pom.xml 50b9898
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 7ae87c6
> omrs/src/main/java/org/apache/atlas/omrs/rest/server/OMRSRepositoryRESTServices.java 5948482
> omrs/src/main/java/org/apache/atlas/omrs/rest/server/spring/OMRSRepositoryResource.java PRE-CREATION
> omrs/src/test/java/org/apache/atlas/omrs/archivemanager/opentypes/TestOpenMetadataTypesArchive.java 3f85317
> omrs/src/test/java/org/apache/atlas/omrs/archivemanager/store/TestOMRSArchiveBuilder.java ccf0de6
> webapp/pom.xml 03b8408
> webapp/src/main/webapp/WEB-INF/applicationContext.xml 2ecd8d1
> webapp/src/main/webapp/WEB-INF/openMetadataContext.xml PRE-CREATION
> webapp/src/main/webapp/WEB-INF/web.xml 23dc063
>
>
> Diff: https://reviews.apache.org/r/67083/diff/4/
>
>
> Testing
> -------
>
> Create configuration for OMAG API in Atlas using Spring MVC Dispatcher servlet.
>
>
> Change base URL for the API to "/open-metadata/access-services"
>
>
> Clean maven unused dependenies
>
> The Jira issue is https://issues.apache.org/jira/browse/ATLAS-2665
>
>
> File Attachments
> ----------------
>
> Added apache licence to a properties file
> https://reviews.apache.org/media/uploaded/files/2018/05/11/77fbc4f6-b16a-42f9-983c-261f70f3ca9f__0002-ATLAS-2665-Added-apache-licence-to-properties-file.patch
> 0003-ATLAS-2665-comments-fixed.patch
> https://reviews.apache.org/media/uploaded/files/2018/05/11/004f018b-1ee5-4da1-91d4-b50f4913298d__0003-ATLAS-2665-comments-fixed.patch
> ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
> https://reviews.apache.org/media/uploaded/files/2018/05/14/160f8499-661d-4fa9-8ce1-afe4bd88b723__ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
>
>
> Thanks,
>
> Bogdan Sava
>
>
Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas
Posted by Mandy Chessell <ma...@uk.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67083/#review203260
-----------------------------------------------------------
omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/OMAGServerAdminResource.java
Lines 187 (patched)
<https://reviews.apache.org/r/67083/#comment285362>
This should be /access-services/mode since it affects all access services
- Mandy Chessell
On May 16, 2018, 3:49 p.m., Bogdan Sava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67083/
> -----------------------------------------------------------
>
> (Updated May 16, 2018, 3:49 p.m.)
>
>
> Review request for atlas, Daniela Otelea, David Radley, Graham Wallis, Mandy Chessell, and Ruxandra Rosu.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Create configuration for OMAG API in Atlas
>
>
> Diffs
> -----
>
> om-fwk-ocf/pom.xml 8b1cefd
> omag-api/pom.xml 2338286
> omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerAdministration.java dd19018
> omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerCategory.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminRESTServices.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminResource.java ebc9f2a
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/OMAGServerAdminResource.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceDescription.java 1a15215
> omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceRegistration.java c2950c4
> omag-server/pom.xml 527c5c3
> omag-server/src/main/java/org/apache/atlas/omag/application/OMAGApplication.java 88397de
> omag-server/src/main/resources/application.properties PRE-CREATION
> omas-assetconsumer/pom.xml 29935e7
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/client/AssetConsumer.java 80a98f5
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/publisher/AssetConsumerPublisher.java
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerRESTServices.java 967be5a
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/spring/AssetConsumerOMASResource.java PRE-CREATION
> omas-connectedasset/README.md 2f431df
> omas-connectedasset/pom.xml 219c972
> omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/ConnectedAssetRESTServices.java 8ae6c37
> omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/spring/ConnectedAssetOMASResource.java PRE-CREATION
> omrs/pom.xml 50b9898
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 7ae87c6
> omrs/src/main/java/org/apache/atlas/omrs/rest/server/OMRSRepositoryRESTServices.java 5948482
> omrs/src/main/java/org/apache/atlas/omrs/rest/server/spring/OMRSRepositoryResource.java PRE-CREATION
> omrs/src/test/java/org/apache/atlas/omrs/archivemanager/opentypes/TestOpenMetadataTypesArchive.java 3f85317
> omrs/src/test/java/org/apache/atlas/omrs/archivemanager/store/TestOMRSArchiveBuilder.java ccf0de6
> webapp/pom.xml 03b8408
> webapp/src/main/webapp/WEB-INF/applicationContext.xml 2ecd8d1
> webapp/src/main/webapp/WEB-INF/openMetadataContext.xml PRE-CREATION
> webapp/src/main/webapp/WEB-INF/web.xml 23dc063
>
>
> Diff: https://reviews.apache.org/r/67083/diff/4/
>
>
> Testing
> -------
>
> Create configuration for OMAG API in Atlas using Spring MVC Dispatcher servlet.
>
>
> Change base URL for the API to "/open-metadata/access-services"
>
>
> Clean maven unused dependenies
>
> The Jira issue is https://issues.apache.org/jira/browse/ATLAS-2665
>
>
> File Attachments
> ----------------
>
> Added apache licence to a properties file
> https://reviews.apache.org/media/uploaded/files/2018/05/11/77fbc4f6-b16a-42f9-983c-261f70f3ca9f__0002-ATLAS-2665-Added-apache-licence-to-properties-file.patch
> 0003-ATLAS-2665-comments-fixed.patch
> https://reviews.apache.org/media/uploaded/files/2018/05/11/004f018b-1ee5-4da1-91d4-b50f4913298d__0003-ATLAS-2665-comments-fixed.patch
> ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
> https://reviews.apache.org/media/uploaded/files/2018/05/14/160f8499-661d-4fa9-8ce1-afe4bd88b723__ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
>
>
> Thanks,
>
> Bogdan Sava
>
>
Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas
Posted by Bogdan Sava <bo...@ing.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67083/
-----------------------------------------------------------
(Updated May 17, 2018, 2:56 p.m.)
Review request for atlas, Daniela Otelea, David Radley, Graham Wallis, Mandy Chessell, and Ruxandra Rosu.
Repository: atlas
Description
-------
Create configuration for OMAG API in Atlas
Diffs (updated)
-----
om-fwk-ocf/pom.xml 8b1cefd
omag-api/pom.xml 2338286
omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerAdministration.java dd19018
omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerCategory.java PRE-CREATION
omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminRESTServices.java PRE-CREATION
omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminResource.java ebc9f2a
omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/OMAGServerAdminResource.java PRE-CREATION
omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceDescription.java 1a15215
omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceRegistration.java c2950c4
omag-server/pom.xml 527c5c3
omag-server/src/main/java/org/apache/atlas/omag/application/OMAGApplication.java 88397de
omag-server/src/main/resources/application.properties PRE-CREATION
omas-assetconsumer/pom.xml 29935e7
omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/client/AssetConsumer.java 80a98f5
omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/publisher/AssetConsumerPublisher.java
omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerRESTServices.java 967be5a
omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/spring/AssetConsumerOMASResource.java PRE-CREATION
omas-connectedasset/README.md 2f431df
omas-connectedasset/pom.xml 219c972
omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/ConnectedAssetRESTServices.java 8ae6c37
omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/spring/ConnectedAssetOMASResource.java PRE-CREATION
omrs/pom.xml 50b9898
omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 7ae87c6
omrs/src/main/java/org/apache/atlas/omrs/rest/server/OMRSRepositoryRESTServices.java 5948482
omrs/src/main/java/org/apache/atlas/omrs/rest/server/spring/OMRSRepositoryResource.java PRE-CREATION
omrs/src/test/java/org/apache/atlas/omrs/archivemanager/opentypes/TestOpenMetadataTypesArchive.java 3f85317
omrs/src/test/java/org/apache/atlas/omrs/archivemanager/store/TestOMRSArchiveBuilder.java ccf0de6
webapp/pom.xml 03b8408
webapp/src/main/webapp/WEB-INF/applicationContext.xml 2ecd8d1
webapp/src/main/webapp/WEB-INF/openMetadataContext.xml PRE-CREATION
webapp/src/main/webapp/WEB-INF/web.xml 23dc063
Diff: https://reviews.apache.org/r/67083/diff/6/
Changes: https://reviews.apache.org/r/67083/diff/5-6/
Testing
-------
Create configuration for OMAG API in Atlas using Spring MVC Dispatcher servlet.
Change base URL for the API to "/open-metadata/access-services"
Clean maven unused dependenies
The Jira issue is https://issues.apache.org/jira/browse/ATLAS-2665
File Attachments
----------------
Added apache licence to a properties file
https://reviews.apache.org/media/uploaded/files/2018/05/11/77fbc4f6-b16a-42f9-983c-261f70f3ca9f__0002-ATLAS-2665-Added-apache-licence-to-properties-file.patch
0003-ATLAS-2665-comments-fixed.patch
https://reviews.apache.org/media/uploaded/files/2018/05/11/004f018b-1ee5-4da1-91d4-b50f4913298d__0003-ATLAS-2665-comments-fixed.patch
ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
https://reviews.apache.org/media/uploaded/files/2018/05/14/160f8499-661d-4fa9-8ce1-afe4bd88b723__ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
Thanks,
Bogdan Sava
Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas
Posted by David Radley <da...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67083/#review203328
-----------------------------------------------------------
omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java
Line 55 (original), 55 (patched)
<https://reviews.apache.org/r/67083/#comment285453>
This should be plural to be consistent with access-services. there are a few otehr instances of this in the patch
omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java
Line 291 (original), 291 (patched)
<https://reviews.apache.org/r/67083/#comment285454>
this is not what the code does. For this example wouldn't the code would produce urls starting with.
ocalhost:8080/open-metadata/localServerName/open-metadata/repository-service/
omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java
Line 306 (original), 306 (patched)
<https://reviews.apache.org/r/67083/#comment285455>
should be repository-services to be consistant
omrs/src/main/java/org/apache/atlas/omrs/rest/server/OMRSRepositoryRESTServices.java
Line 202 (original), 201 (patched)
<https://reviews.apache.org/r/67083/#comment285456>
Are we missing the /users/ before the {userId} in the path? The same for the rest of this file.
omrs/src/main/java/org/apache/atlas/omrs/rest/server/spring/OMRSRepositoryResource.java
Lines 84 (patched)
<https://reviews.apache.org/r/67083/#comment285457>
plural for consistancy ?
webapp/src/main/webapp/WEB-INF/openMetadataContext.xml
Lines 3 (patched)
<https://reviews.apache.org/r/67083/#comment285452>
Bad end of line character on this and the next 6 lines
- David Radley
On May 17, 2018, 12:10 p.m., Bogdan Sava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67083/
> -----------------------------------------------------------
>
> (Updated May 17, 2018, 12:10 p.m.)
>
>
> Review request for atlas, Daniela Otelea, David Radley, Graham Wallis, Mandy Chessell, and Ruxandra Rosu.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Create configuration for OMAG API in Atlas
>
>
> Diffs
> -----
>
> om-fwk-ocf/pom.xml 8b1cefd
> omag-api/pom.xml 2338286
> omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerAdministration.java dd19018
> omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerCategory.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminRESTServices.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminResource.java ebc9f2a
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/OMAGServerAdminResource.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceDescription.java 1a15215
> omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceRegistration.java c2950c4
> omag-server/pom.xml 527c5c3
> omag-server/src/main/java/org/apache/atlas/omag/application/OMAGApplication.java 88397de
> omag-server/src/main/resources/application.properties PRE-CREATION
> omas-assetconsumer/pom.xml 29935e7
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/client/AssetConsumer.java 80a98f5
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/publisher/AssetConsumerPublisher.java
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerRESTServices.java 967be5a
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/spring/AssetConsumerOMASResource.java PRE-CREATION
> omas-connectedasset/README.md 2f431df
> omas-connectedasset/pom.xml 219c972
> omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/ConnectedAssetRESTServices.java 8ae6c37
> omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/spring/ConnectedAssetOMASResource.java PRE-CREATION
> omrs/pom.xml 50b9898
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 7ae87c6
> omrs/src/main/java/org/apache/atlas/omrs/rest/server/OMRSRepositoryRESTServices.java 5948482
> omrs/src/main/java/org/apache/atlas/omrs/rest/server/spring/OMRSRepositoryResource.java PRE-CREATION
> omrs/src/test/java/org/apache/atlas/omrs/archivemanager/opentypes/TestOpenMetadataTypesArchive.java 3f85317
> omrs/src/test/java/org/apache/atlas/omrs/archivemanager/store/TestOMRSArchiveBuilder.java ccf0de6
> webapp/pom.xml 03b8408
> webapp/src/main/webapp/WEB-INF/applicationContext.xml 2ecd8d1
> webapp/src/main/webapp/WEB-INF/openMetadataContext.xml PRE-CREATION
> webapp/src/main/webapp/WEB-INF/web.xml 23dc063
>
>
> Diff: https://reviews.apache.org/r/67083/diff/5/
>
>
> Testing
> -------
>
> Create configuration for OMAG API in Atlas using Spring MVC Dispatcher servlet.
>
>
> Change base URL for the API to "/open-metadata/access-services"
>
>
> Clean maven unused dependenies
>
> The Jira issue is https://issues.apache.org/jira/browse/ATLAS-2665
>
>
> File Attachments
> ----------------
>
> Added apache licence to a properties file
> https://reviews.apache.org/media/uploaded/files/2018/05/11/77fbc4f6-b16a-42f9-983c-261f70f3ca9f__0002-ATLAS-2665-Added-apache-licence-to-properties-file.patch
> 0003-ATLAS-2665-comments-fixed.patch
> https://reviews.apache.org/media/uploaded/files/2018/05/11/004f018b-1ee5-4da1-91d4-b50f4913298d__0003-ATLAS-2665-comments-fixed.patch
> ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
> https://reviews.apache.org/media/uploaded/files/2018/05/14/160f8499-661d-4fa9-8ce1-afe4bd88b723__ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
>
>
> Thanks,
>
> Bogdan Sava
>
>
Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas
Posted by Bogdan Sava <bo...@ing.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67083/
-----------------------------------------------------------
(Updated May 17, 2018, 12:10 p.m.)
Review request for atlas, Daniela Otelea, David Radley, Graham Wallis, Mandy Chessell, and Ruxandra Rosu.
Repository: atlas
Description
-------
Create configuration for OMAG API in Atlas
Diffs (updated)
-----
om-fwk-ocf/pom.xml 8b1cefd
omag-api/pom.xml 2338286
omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerAdministration.java dd19018
omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerCategory.java PRE-CREATION
omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminRESTServices.java PRE-CREATION
omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminResource.java ebc9f2a
omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/OMAGServerAdminResource.java PRE-CREATION
omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceDescription.java 1a15215
omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceRegistration.java c2950c4
omag-server/pom.xml 527c5c3
omag-server/src/main/java/org/apache/atlas/omag/application/OMAGApplication.java 88397de
omag-server/src/main/resources/application.properties PRE-CREATION
omas-assetconsumer/pom.xml 29935e7
omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/client/AssetConsumer.java 80a98f5
omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/publisher/AssetConsumerPublisher.java
omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerRESTServices.java 967be5a
omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/spring/AssetConsumerOMASResource.java PRE-CREATION
omas-connectedasset/README.md 2f431df
omas-connectedasset/pom.xml 219c972
omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/ConnectedAssetRESTServices.java 8ae6c37
omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/spring/ConnectedAssetOMASResource.java PRE-CREATION
omrs/pom.xml 50b9898
omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 7ae87c6
omrs/src/main/java/org/apache/atlas/omrs/rest/server/OMRSRepositoryRESTServices.java 5948482
omrs/src/main/java/org/apache/atlas/omrs/rest/server/spring/OMRSRepositoryResource.java PRE-CREATION
omrs/src/test/java/org/apache/atlas/omrs/archivemanager/opentypes/TestOpenMetadataTypesArchive.java 3f85317
omrs/src/test/java/org/apache/atlas/omrs/archivemanager/store/TestOMRSArchiveBuilder.java ccf0de6
webapp/pom.xml 03b8408
webapp/src/main/webapp/WEB-INF/applicationContext.xml 2ecd8d1
webapp/src/main/webapp/WEB-INF/openMetadataContext.xml PRE-CREATION
webapp/src/main/webapp/WEB-INF/web.xml 23dc063
Diff: https://reviews.apache.org/r/67083/diff/5/
Changes: https://reviews.apache.org/r/67083/diff/4-5/
Testing
-------
Create configuration for OMAG API in Atlas using Spring MVC Dispatcher servlet.
Change base URL for the API to "/open-metadata/access-services"
Clean maven unused dependenies
The Jira issue is https://issues.apache.org/jira/browse/ATLAS-2665
File Attachments
----------------
Added apache licence to a properties file
https://reviews.apache.org/media/uploaded/files/2018/05/11/77fbc4f6-b16a-42f9-983c-261f70f3ca9f__0002-ATLAS-2665-Added-apache-licence-to-properties-file.patch
0003-ATLAS-2665-comments-fixed.patch
https://reviews.apache.org/media/uploaded/files/2018/05/11/004f018b-1ee5-4da1-91d4-b50f4913298d__0003-ATLAS-2665-comments-fixed.patch
ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
https://reviews.apache.org/media/uploaded/files/2018/05/14/160f8499-661d-4fa9-8ce1-afe4bd88b723__ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
Thanks,
Bogdan Sava
Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas
Posted by Mandy Chessell <ma...@uk.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67083/#review203262
-----------------------------------------------------------
omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/OMAGServerAdminResource.java
Lines 336 (patched)
<https://reviews.apache.org/r/67083/#comment285364>
If we are using plurals then why is this not "cohorts"?
omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/OMAGServerAdminResource.java
Lines 425 (patched)
<https://reviews.apache.org/r/67083/#comment285365>
Should this be "cohorts"?
- Mandy Chessell
On May 16, 2018, 3:49 p.m., Bogdan Sava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67083/
> -----------------------------------------------------------
>
> (Updated May 16, 2018, 3:49 p.m.)
>
>
> Review request for atlas, Daniela Otelea, David Radley, Graham Wallis, Mandy Chessell, and Ruxandra Rosu.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Create configuration for OMAG API in Atlas
>
>
> Diffs
> -----
>
> om-fwk-ocf/pom.xml 8b1cefd
> omag-api/pom.xml 2338286
> omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerAdministration.java dd19018
> omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerCategory.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminRESTServices.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminResource.java ebc9f2a
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/OMAGServerAdminResource.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceDescription.java 1a15215
> omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceRegistration.java c2950c4
> omag-server/pom.xml 527c5c3
> omag-server/src/main/java/org/apache/atlas/omag/application/OMAGApplication.java 88397de
> omag-server/src/main/resources/application.properties PRE-CREATION
> omas-assetconsumer/pom.xml 29935e7
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/client/AssetConsumer.java 80a98f5
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/publisher/AssetConsumerPublisher.java
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerRESTServices.java 967be5a
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/spring/AssetConsumerOMASResource.java PRE-CREATION
> omas-connectedasset/README.md 2f431df
> omas-connectedasset/pom.xml 219c972
> omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/ConnectedAssetRESTServices.java 8ae6c37
> omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/spring/ConnectedAssetOMASResource.java PRE-CREATION
> omrs/pom.xml 50b9898
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 7ae87c6
> omrs/src/main/java/org/apache/atlas/omrs/rest/server/OMRSRepositoryRESTServices.java 5948482
> omrs/src/main/java/org/apache/atlas/omrs/rest/server/spring/OMRSRepositoryResource.java PRE-CREATION
> omrs/src/test/java/org/apache/atlas/omrs/archivemanager/opentypes/TestOpenMetadataTypesArchive.java 3f85317
> omrs/src/test/java/org/apache/atlas/omrs/archivemanager/store/TestOMRSArchiveBuilder.java ccf0de6
> webapp/pom.xml 03b8408
> webapp/src/main/webapp/WEB-INF/applicationContext.xml 2ecd8d1
> webapp/src/main/webapp/WEB-INF/openMetadataContext.xml PRE-CREATION
> webapp/src/main/webapp/WEB-INF/web.xml 23dc063
>
>
> Diff: https://reviews.apache.org/r/67083/diff/4/
>
>
> Testing
> -------
>
> Create configuration for OMAG API in Atlas using Spring MVC Dispatcher servlet.
>
>
> Change base URL for the API to "/open-metadata/access-services"
>
>
> Clean maven unused dependenies
>
> The Jira issue is https://issues.apache.org/jira/browse/ATLAS-2665
>
>
> File Attachments
> ----------------
>
> Added apache licence to a properties file
> https://reviews.apache.org/media/uploaded/files/2018/05/11/77fbc4f6-b16a-42f9-983c-261f70f3ca9f__0002-ATLAS-2665-Added-apache-licence-to-properties-file.patch
> 0003-ATLAS-2665-comments-fixed.patch
> https://reviews.apache.org/media/uploaded/files/2018/05/11/004f018b-1ee5-4da1-91d4-b50f4913298d__0003-ATLAS-2665-comments-fixed.patch
> ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
> https://reviews.apache.org/media/uploaded/files/2018/05/14/160f8499-661d-4fa9-8ce1-afe4bd88b723__ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
>
>
> Thanks,
>
> Bogdan Sava
>
>
Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas
Posted by Bogdan Sava <bo...@ing.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67083/
-----------------------------------------------------------
(Updated May 16, 2018, 3:49 p.m.)
Review request for atlas, Daniela Otelea, David Radley, Graham Wallis, Mandy Chessell, and Ruxandra Rosu.
Repository: atlas
Description
-------
Create configuration for OMAG API in Atlas
Diffs (updated)
-----
om-fwk-ocf/pom.xml 8b1cefd
omag-api/pom.xml 2338286
omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerAdministration.java dd19018
omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerCategory.java PRE-CREATION
omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminRESTServices.java PRE-CREATION
omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminResource.java ebc9f2a
omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/OMAGServerAdminResource.java PRE-CREATION
omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceDescription.java 1a15215
omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceRegistration.java c2950c4
omag-server/pom.xml 527c5c3
omag-server/src/main/java/org/apache/atlas/omag/application/OMAGApplication.java 88397de
omag-server/src/main/resources/application.properties PRE-CREATION
omas-assetconsumer/pom.xml 29935e7
omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/client/AssetConsumer.java 80a98f5
omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/publisher/AssetConsumerPublisher.java
omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerRESTServices.java 967be5a
omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/spring/AssetConsumerOMASResource.java PRE-CREATION
omas-connectedasset/README.md 2f431df
omas-connectedasset/pom.xml 219c972
omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/ConnectedAssetRESTServices.java 8ae6c37
omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/spring/ConnectedAssetOMASResource.java PRE-CREATION
omrs/pom.xml 50b9898
omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 7ae87c6
omrs/src/main/java/org/apache/atlas/omrs/rest/server/OMRSRepositoryRESTServices.java 5948482
omrs/src/main/java/org/apache/atlas/omrs/rest/server/spring/OMRSRepositoryResource.java PRE-CREATION
omrs/src/test/java/org/apache/atlas/omrs/archivemanager/opentypes/TestOpenMetadataTypesArchive.java 3f85317
omrs/src/test/java/org/apache/atlas/omrs/archivemanager/store/TestOMRSArchiveBuilder.java ccf0de6
webapp/pom.xml 03b8408
webapp/src/main/webapp/WEB-INF/applicationContext.xml 2ecd8d1
webapp/src/main/webapp/WEB-INF/openMetadataContext.xml PRE-CREATION
webapp/src/main/webapp/WEB-INF/web.xml 23dc063
Diff: https://reviews.apache.org/r/67083/diff/4/
Changes: https://reviews.apache.org/r/67083/diff/3-4/
Testing
-------
Create configuration for OMAG API in Atlas using Spring MVC Dispatcher servlet.
Change base URL for the API to "/open-metadata/access-services"
Clean maven unused dependenies
The Jira issue is https://issues.apache.org/jira/browse/ATLAS-2665
File Attachments
----------------
Added apache licence to a properties file
https://reviews.apache.org/media/uploaded/files/2018/05/11/77fbc4f6-b16a-42f9-983c-261f70f3ca9f__0002-ATLAS-2665-Added-apache-licence-to-properties-file.patch
0003-ATLAS-2665-comments-fixed.patch
https://reviews.apache.org/media/uploaded/files/2018/05/11/004f018b-1ee5-4da1-91d4-b50f4913298d__0003-ATLAS-2665-comments-fixed.patch
ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
https://reviews.apache.org/media/uploaded/files/2018/05/14/160f8499-661d-4fa9-8ce1-afe4bd88b723__ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
Thanks,
Bogdan Sava
Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas
Posted by Bogdan Sava <bo...@ing.com>.
> On May 16, 2018, 1:48 p.m., Graham Wallis wrote:
> > omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/OMAGServerAdminResource.java
> > Lines 231 (patched)
> > <https://reviews.apache.org/r/67083/diff/3/?file=2023012#file2023012line231>
> >
> > We also need a method for the LOCAL_GRAPH_REPOSITORY.
> >
> > The URI should be "/local-repository/mode/local-graph-repository"
> >
> > The method should be "setGraphLocalRepository" (even though that sounds a bit weird it would be consistent with the others - change then all to setLocalRepositoryXXX() if you prefer).
> >
> > The body of the method should be:
> > return adminAPI.setLocalRepositoryMode(userId, serverName, LocalRepositoryMode.LOCAL_GRAPH_REPOSITORY);
>
> Mandy Chessell wrote:
> The setting of the local graph repository should not be an external callable API. It is only valid in the Atlas server - and in which case it should always be set as soon as the open metadata function is turned on - basically we still need 2 APIs administration.
I am looking to create a configuration bean fo this
- Bogdan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67083/#review203219
-----------------------------------------------------------
On May 17, 2018, 2:56 p.m., Bogdan Sava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67083/
> -----------------------------------------------------------
>
> (Updated May 17, 2018, 2:56 p.m.)
>
>
> Review request for atlas, Daniela Otelea, David Radley, Graham Wallis, Mandy Chessell, and Ruxandra Rosu.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Create configuration for OMAG API in Atlas
>
>
> Diffs
> -----
>
> om-fwk-ocf/pom.xml 8b1cefd
> omag-api/pom.xml 2338286
> omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerAdministration.java dd19018
> omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerCategory.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminRESTServices.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminResource.java ebc9f2a
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/OMAGServerAdminResource.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceDescription.java 1a15215
> omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceRegistration.java c2950c4
> omag-server/pom.xml 527c5c3
> omag-server/src/main/java/org/apache/atlas/omag/application/OMAGApplication.java 88397de
> omag-server/src/main/resources/application.properties PRE-CREATION
> omas-assetconsumer/pom.xml 29935e7
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/client/AssetConsumer.java 80a98f5
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/publisher/AssetConsumerPublisher.java
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerRESTServices.java 967be5a
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/spring/AssetConsumerOMASResource.java PRE-CREATION
> omas-connectedasset/README.md 2f431df
> omas-connectedasset/pom.xml 219c972
> omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/ConnectedAssetRESTServices.java 8ae6c37
> omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/spring/ConnectedAssetOMASResource.java PRE-CREATION
> omrs/pom.xml 50b9898
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 7ae87c6
> omrs/src/main/java/org/apache/atlas/omrs/rest/server/OMRSRepositoryRESTServices.java 5948482
> omrs/src/main/java/org/apache/atlas/omrs/rest/server/spring/OMRSRepositoryResource.java PRE-CREATION
> omrs/src/test/java/org/apache/atlas/omrs/archivemanager/opentypes/TestOpenMetadataTypesArchive.java 3f85317
> omrs/src/test/java/org/apache/atlas/omrs/archivemanager/store/TestOMRSArchiveBuilder.java ccf0de6
> webapp/pom.xml 03b8408
> webapp/src/main/webapp/WEB-INF/applicationContext.xml 2ecd8d1
> webapp/src/main/webapp/WEB-INF/openMetadataContext.xml PRE-CREATION
> webapp/src/main/webapp/WEB-INF/web.xml 23dc063
>
>
> Diff: https://reviews.apache.org/r/67083/diff/6/
>
>
> Testing
> -------
>
> Create configuration for OMAG API in Atlas using Spring MVC Dispatcher servlet.
>
>
> Change base URL for the API to "/open-metadata/access-services"
>
>
> Clean maven unused dependenies
>
> The Jira issue is https://issues.apache.org/jira/browse/ATLAS-2665
>
>
> File Attachments
> ----------------
>
> Added apache licence to a properties file
> https://reviews.apache.org/media/uploaded/files/2018/05/11/77fbc4f6-b16a-42f9-983c-261f70f3ca9f__0002-ATLAS-2665-Added-apache-licence-to-properties-file.patch
> 0003-ATLAS-2665-comments-fixed.patch
> https://reviews.apache.org/media/uploaded/files/2018/05/11/004f018b-1ee5-4da1-91d4-b50f4913298d__0003-ATLAS-2665-comments-fixed.patch
> ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
> https://reviews.apache.org/media/uploaded/files/2018/05/14/160f8499-661d-4fa9-8ce1-afe4bd88b723__ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
>
>
> Thanks,
>
> Bogdan Sava
>
>
Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas
Posted by Mandy Chessell <ma...@uk.ibm.com>.
> On May 16, 2018, 1:48 p.m., Graham Wallis wrote:
> > omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/OMAGServerAdminResource.java
> > Lines 231 (patched)
> > <https://reviews.apache.org/r/67083/diff/3/?file=2023012#file2023012line231>
> >
> > We also need a method for the LOCAL_GRAPH_REPOSITORY.
> >
> > The URI should be "/local-repository/mode/local-graph-repository"
> >
> > The method should be "setGraphLocalRepository" (even though that sounds a bit weird it would be consistent with the others - change then all to setLocalRepositoryXXX() if you prefer).
> >
> > The body of the method should be:
> > return adminAPI.setLocalRepositoryMode(userId, serverName, LocalRepositoryMode.LOCAL_GRAPH_REPOSITORY);
The setting of the local graph repository should not be an external callable API. It is only valid in the Atlas server - and in which case it should always be set as soon as the open metadata function is turned on - basically we still need 2 APIs administration.
- Mandy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67083/#review203219
-----------------------------------------------------------
On May 15, 2018, 1:35 p.m., Bogdan Sava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67083/
> -----------------------------------------------------------
>
> (Updated May 15, 2018, 1:35 p.m.)
>
>
> Review request for atlas, Daniela Otelea, David Radley, Graham Wallis, Mandy Chessell, and Ruxandra Rosu.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Create configuration for OMAG API in Atlas
>
>
> Diffs
> -----
>
> om-fwk-ocf/pom.xml 8b1cefd
> omag-api/pom.xml 2338286
> omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerAdministration.java dd19018
> omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerCategory.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminRESTServices.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminResource.java ebc9f2a
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/OMAGServerAdminResource.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceDescription.java 1a15215
> omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceRegistration.java c2950c4
> omag-server/pom.xml 527c5c3
> omag-server/src/main/java/org/apache/atlas/omag/application/OMAGApplication.java 88397de
> omag-server/src/main/resources/application.properties PRE-CREATION
> omas-assetconsumer/pom.xml 29935e7
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/client/AssetConsumer.java 80a98f5
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/publisher/AssetConsumerPublisher.java
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerRESTServices.java 967be5a
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/spring/AssetConsumerOMASResource.java PRE-CREATION
> omas-connectedasset/README.md 2f431df
> omas-connectedasset/pom.xml 219c972
> omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/ConnectedAssetRESTServices.java 8ae6c37
> omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/spring/ConnectedAssetOMASResource.java PRE-CREATION
> omrs/pom.xml 50b9898
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 7ae87c6
> omrs/src/main/java/org/apache/atlas/omrs/rest/server/OMRSRepositoryRESTServices.java 5948482
> omrs/src/main/java/org/apache/atlas/omrs/rest/server/spring/OMRSRepositoryResource.java PRE-CREATION
> omrs/src/test/java/org/apache/atlas/omrs/archivemanager/opentypes/TestOpenMetadataTypesArchive.java 3f85317
> omrs/src/test/java/org/apache/atlas/omrs/archivemanager/store/TestOMRSArchiveBuilder.java ccf0de6
> webapp/pom.xml 03b8408
> webapp/src/main/webapp/WEB-INF/applicationContext.xml 2ecd8d1
> webapp/src/main/webapp/WEB-INF/openMetadataContext.xml PRE-CREATION
> webapp/src/main/webapp/WEB-INF/web.xml 23dc063
>
>
> Diff: https://reviews.apache.org/r/67083/diff/3/
>
>
> Testing
> -------
>
> Create configuration for OMAG API in Atlas using Spring MVC Dispatcher servlet.
>
>
> Change base URL for the API to "/open-metadata/access-services"
>
>
> Clean maven unused dependenies
>
> The Jira issue is https://issues.apache.org/jira/browse/ATLAS-2665
>
>
> File Attachments
> ----------------
>
> Added apache licence to a properties file
> https://reviews.apache.org/media/uploaded/files/2018/05/11/77fbc4f6-b16a-42f9-983c-261f70f3ca9f__0002-ATLAS-2665-Added-apache-licence-to-properties-file.patch
> 0003-ATLAS-2665-comments-fixed.patch
> https://reviews.apache.org/media/uploaded/files/2018/05/11/004f018b-1ee5-4da1-91d4-b50f4913298d__0003-ATLAS-2665-comments-fixed.patch
> ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
> https://reviews.apache.org/media/uploaded/files/2018/05/14/160f8499-661d-4fa9-8ce1-afe4bd88b723__ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
>
>
> Thanks,
>
> Bogdan Sava
>
>
Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas
Posted by Graham Wallis <gr...@uk.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67083/#review203219
-----------------------------------------------------------
omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/OMAGServerAdminResource.java
Lines 206 (patched)
<https://reviews.apache.org/r/67083/#comment285310>
To be consistent with the other modes the URI should be "/local-repository/mode/in-memory-repository"
omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/OMAGServerAdminResource.java
Lines 225 (patched)
<https://reviews.apache.org/r/67083/#comment285311>
The method should be called "setNoLocalRepository"
omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/OMAGServerAdminResource.java
Lines 231 (patched)
<https://reviews.apache.org/r/67083/#comment285312>
We also need a method for the LOCAL_GRAPH_REPOSITORY.
The URI should be "/local-repository/mode/local-graph-repository"
The method should be "setGraphLocalRepository" (even though that sounds a bit weird it would be consistent with the others - change then all to setLocalRepositoryXXX() if you prefer).
The body of the method should be:
return adminAPI.setLocalRepositoryMode(userId, serverName, LocalRepositoryMode.LOCAL_GRAPH_REPOSITORY);
- Graham Wallis
On May 15, 2018, 1:35 p.m., Bogdan Sava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67083/
> -----------------------------------------------------------
>
> (Updated May 15, 2018, 1:35 p.m.)
>
>
> Review request for atlas, Daniela Otelea, David Radley, Graham Wallis, Mandy Chessell, and Ruxandra Rosu.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Create configuration for OMAG API in Atlas
>
>
> Diffs
> -----
>
> om-fwk-ocf/pom.xml 8b1cefd
> omag-api/pom.xml 2338286
> omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerAdministration.java dd19018
> omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerCategory.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminRESTServices.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminResource.java ebc9f2a
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/OMAGServerAdminResource.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceDescription.java 1a15215
> omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceRegistration.java c2950c4
> omag-server/pom.xml 527c5c3
> omag-server/src/main/java/org/apache/atlas/omag/application/OMAGApplication.java 88397de
> omag-server/src/main/resources/application.properties PRE-CREATION
> omas-assetconsumer/pom.xml 29935e7
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/client/AssetConsumer.java 80a98f5
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/publisher/AssetConsumerPublisher.java
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerRESTServices.java 967be5a
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/spring/AssetConsumerOMASResource.java PRE-CREATION
> omas-connectedasset/README.md 2f431df
> omas-connectedasset/pom.xml 219c972
> omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/ConnectedAssetRESTServices.java 8ae6c37
> omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/spring/ConnectedAssetOMASResource.java PRE-CREATION
> omrs/pom.xml 50b9898
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 7ae87c6
> omrs/src/main/java/org/apache/atlas/omrs/rest/server/OMRSRepositoryRESTServices.java 5948482
> omrs/src/main/java/org/apache/atlas/omrs/rest/server/spring/OMRSRepositoryResource.java PRE-CREATION
> omrs/src/test/java/org/apache/atlas/omrs/archivemanager/opentypes/TestOpenMetadataTypesArchive.java 3f85317
> omrs/src/test/java/org/apache/atlas/omrs/archivemanager/store/TestOMRSArchiveBuilder.java ccf0de6
> webapp/pom.xml 03b8408
> webapp/src/main/webapp/WEB-INF/applicationContext.xml 2ecd8d1
> webapp/src/main/webapp/WEB-INF/openMetadataContext.xml PRE-CREATION
> webapp/src/main/webapp/WEB-INF/web.xml 23dc063
>
>
> Diff: https://reviews.apache.org/r/67083/diff/3/
>
>
> Testing
> -------
>
> Create configuration for OMAG API in Atlas using Spring MVC Dispatcher servlet.
>
>
> Change base URL for the API to "/open-metadata/access-services"
>
>
> Clean maven unused dependenies
>
> The Jira issue is https://issues.apache.org/jira/browse/ATLAS-2665
>
>
> File Attachments
> ----------------
>
> Added apache licence to a properties file
> https://reviews.apache.org/media/uploaded/files/2018/05/11/77fbc4f6-b16a-42f9-983c-261f70f3ca9f__0002-ATLAS-2665-Added-apache-licence-to-properties-file.patch
> 0003-ATLAS-2665-comments-fixed.patch
> https://reviews.apache.org/media/uploaded/files/2018/05/11/004f018b-1ee5-4da1-91d4-b50f4913298d__0003-ATLAS-2665-comments-fixed.patch
> ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
> https://reviews.apache.org/media/uploaded/files/2018/05/14/160f8499-661d-4fa9-8ce1-afe4bd88b723__ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
>
>
> Thanks,
>
> Bogdan Sava
>
>
Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas
Posted by David Radley <da...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67083/#review203132
-----------------------------------------------------------
omag-api/pom.xml
Line 42 (original), 42 (patched)
<https://reviews.apache.org/r/67083/#comment285217>
Atlas (built with embedded hbase) fails to start with this in the application.log:
2018-05-15 16:56:33,093 INFO - [main:] ~ Loading atlas-application.properties from file:/Users/david/atlasreview/distro/target/apache-atlas-1.0.0-SNAPSHOT-bin/apache-atlas-1.0.0-SNAPSHOT/conf/atlas-application.properties (ApplicationProperties:98)
2018-05-15 16:56:33,100 INFO - [main:] ~ Property (set to default) atlas.graph.cache.db-cache = true (ApplicationProperties:242)
2018-05-15 16:56:33,100 INFO - [main:] ~ Property (set to default) atlas.graph.cache.db-cache-clean-wait = 20 (ApplicationProperties:242)
2018-05-15 16:56:33,102 INFO - [main:] ~ Property (set to default) atlas.graph.cache.db-cache-size = 0.5 (ApplicationProperties:242)
2018-05-15 16:56:33,102 INFO - [main:] ~ Property (set to default) atlas.graph.cache.tx-cache.size = 15000 (ApplicationProperties:242)
2018-05-15 16:56:33,102 INFO - [main:] ~ Property (set to default) atlas.graph.cache.tx-dirty-size = 120 (ApplicationProperties:242)
2018-05-15 16:56:33,116 INFO - [main:] ~
########################################################################################
Atlas Server (STARTUP)
project.name: apache-atlas
project.description: Metadata Management and Data Governance Platform over Hadoop
build.user: david
build.epoch: 1526398417725
project.version: 1.0.0-SNAPSHOT
build.version: 1.0.0-SNAPSHOT-r7e70b1e76324305fb1cd50302206c9d135b2be53
vc.revision: 7e70b1e76324305fb1cd50302206c9d135b2be53
vc.source.url: scm:git:git://git.apache.org/atlas.git/atlas-webapp
######################################################################################## (Atlas:215)
2018-05-15 16:56:33,117 INFO - [main:] ~ >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> (Atlas:216)
2018-05-15 16:56:33,117 INFO - [main:] ~ Server starting with TLS ? false on port 21000 (Atlas:217)
2018-05-15 16:56:33,117 INFO - [main:] ~ <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< (Atlas:218)
2018-05-15 16:56:33,694 INFO - [main:] ~ No authentication method configured. Defaulting to simple authentication (LoginProcessor:102)
2018-05-15 16:56:33,806 INFO - [main:] ~ Logged in user david (auth:SIMPLE) (LoginProcessor:77)
2018-05-15 16:56:34,210 INFO - [main:] ~ Not running setup per configuration atlas.server.run.setup.on.start. (SetupSteps$SetupRequired:189)
- David Radley
On May 15, 2018, 1:35 p.m., Bogdan Sava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67083/
> -----------------------------------------------------------
>
> (Updated May 15, 2018, 1:35 p.m.)
>
>
> Review request for atlas, Daniela Otelea, David Radley, Graham Wallis, Mandy Chessell, and Ruxandra Rosu.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Create configuration for OMAG API in Atlas
>
>
> Diffs
> -----
>
> om-fwk-ocf/pom.xml 8b1cefd
> omag-api/pom.xml 2338286
> omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerAdministration.java dd19018
> omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerCategory.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminRESTServices.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminResource.java ebc9f2a
> omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/OMAGServerAdminResource.java PRE-CREATION
> omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceDescription.java 1a15215
> omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceRegistration.java c2950c4
> omag-server/pom.xml 527c5c3
> omag-server/src/main/java/org/apache/atlas/omag/application/OMAGApplication.java 88397de
> omag-server/src/main/resources/application.properties PRE-CREATION
> omas-assetconsumer/pom.xml 29935e7
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/client/AssetConsumer.java 80a98f5
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/publisher/AssetConsumerPublisher.java
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerRESTServices.java 967be5a
> omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/spring/AssetConsumerOMASResource.java PRE-CREATION
> omas-connectedasset/README.md 2f431df
> omas-connectedasset/pom.xml 219c972
> omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/ConnectedAssetRESTServices.java 8ae6c37
> omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/spring/ConnectedAssetOMASResource.java PRE-CREATION
> omrs/pom.xml 50b9898
> omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 7ae87c6
> omrs/src/main/java/org/apache/atlas/omrs/rest/server/OMRSRepositoryRESTServices.java 5948482
> omrs/src/main/java/org/apache/atlas/omrs/rest/server/spring/OMRSRepositoryResource.java PRE-CREATION
> omrs/src/test/java/org/apache/atlas/omrs/archivemanager/opentypes/TestOpenMetadataTypesArchive.java 3f85317
> omrs/src/test/java/org/apache/atlas/omrs/archivemanager/store/TestOMRSArchiveBuilder.java ccf0de6
> webapp/pom.xml 03b8408
> webapp/src/main/webapp/WEB-INF/applicationContext.xml 2ecd8d1
> webapp/src/main/webapp/WEB-INF/openMetadataContext.xml PRE-CREATION
> webapp/src/main/webapp/WEB-INF/web.xml 23dc063
>
>
> Diff: https://reviews.apache.org/r/67083/diff/3/
>
>
> Testing
> -------
>
> Create configuration for OMAG API in Atlas using Spring MVC Dispatcher servlet.
>
>
> Change base URL for the API to "/open-metadata/access-services"
>
>
> Clean maven unused dependenies
>
> The Jira issue is https://issues.apache.org/jira/browse/ATLAS-2665
>
>
> File Attachments
> ----------------
>
> Added apache licence to a properties file
> https://reviews.apache.org/media/uploaded/files/2018/05/11/77fbc4f6-b16a-42f9-983c-261f70f3ca9f__0002-ATLAS-2665-Added-apache-licence-to-properties-file.patch
> 0003-ATLAS-2665-comments-fixed.patch
> https://reviews.apache.org/media/uploaded/files/2018/05/11/004f018b-1ee5-4da1-91d4-b50f4913298d__0003-ATLAS-2665-comments-fixed.patch
> ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
> https://reviews.apache.org/media/uploaded/files/2018/05/14/160f8499-661d-4fa9-8ce1-afe4bd88b723__ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
>
>
> Thanks,
>
> Bogdan Sava
>
>
Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas
Posted by Bogdan Sava <bo...@ing.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67083/
-----------------------------------------------------------
(Updated May 15, 2018, 1:35 p.m.)
Review request for atlas, Daniela Otelea, David Radley, Graham Wallis, Mandy Chessell, and Ruxandra Rosu.
Repository: atlas
Description
-------
Create configuration for OMAG API in Atlas
Diffs (updated)
-----
om-fwk-ocf/pom.xml 8b1cefd
omag-api/pom.xml 2338286
omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerAdministration.java dd19018
omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerCategory.java PRE-CREATION
omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminRESTServices.java PRE-CREATION
omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminResource.java ebc9f2a
omag-api/src/main/java/org/apache/atlas/omag/admin/server/spring/OMAGServerAdminResource.java PRE-CREATION
omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceDescription.java 1a15215
omag-api/src/main/java/org/apache/atlas/omag/configuration/registration/AccessServiceRegistration.java c2950c4
omag-server/pom.xml 527c5c3
omag-server/src/main/java/org/apache/atlas/omag/application/OMAGApplication.java 88397de
omag-server/src/main/resources/application.properties PRE-CREATION
omas-assetconsumer/pom.xml 29935e7
omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/client/AssetConsumer.java 80a98f5
omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/publisher/AssetConsumerPublisher.java
omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerRESTServices.java 967be5a
omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/spring/AssetConsumerOMASResource.java PRE-CREATION
omas-connectedasset/README.md 2f431df
omas-connectedasset/pom.xml 219c972
omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/ConnectedAssetRESTServices.java 8ae6c37
omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/spring/ConnectedAssetOMASResource.java PRE-CREATION
omrs/pom.xml 50b9898
omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 7ae87c6
omrs/src/main/java/org/apache/atlas/omrs/rest/server/OMRSRepositoryRESTServices.java 5948482
omrs/src/main/java/org/apache/atlas/omrs/rest/server/spring/OMRSRepositoryResource.java PRE-CREATION
omrs/src/test/java/org/apache/atlas/omrs/archivemanager/opentypes/TestOpenMetadataTypesArchive.java 3f85317
omrs/src/test/java/org/apache/atlas/omrs/archivemanager/store/TestOMRSArchiveBuilder.java ccf0de6
webapp/pom.xml 03b8408
webapp/src/main/webapp/WEB-INF/applicationContext.xml 2ecd8d1
webapp/src/main/webapp/WEB-INF/openMetadataContext.xml PRE-CREATION
webapp/src/main/webapp/WEB-INF/web.xml 23dc063
Diff: https://reviews.apache.org/r/67083/diff/3/
Changes: https://reviews.apache.org/r/67083/diff/2-3/
Testing
-------
Create configuration for OMAG API in Atlas using Spring MVC Dispatcher servlet.
Change base URL for the API to "/open-metadata/access-services"
Clean maven unused dependenies
The Jira issue is https://issues.apache.org/jira/browse/ATLAS-2665
File Attachments
----------------
Added apache licence to a properties file
https://reviews.apache.org/media/uploaded/files/2018/05/11/77fbc4f6-b16a-42f9-983c-261f70f3ca9f__0002-ATLAS-2665-Added-apache-licence-to-properties-file.patch
0003-ATLAS-2665-comments-fixed.patch
https://reviews.apache.org/media/uploaded/files/2018/05/11/004f018b-1ee5-4da1-91d4-b50f4913298d__0003-ATLAS-2665-comments-fixed.patch
ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
https://reviews.apache.org/media/uploaded/files/2018/05/14/160f8499-661d-4fa9-8ce1-afe4bd88b723__ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
Thanks,
Bogdan Sava
Re: Review Request 67083: ATLAS-2665 - Add OMAG-API in Atlas
Posted by Bogdan Sava <bo...@ing.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67083/
-----------------------------------------------------------
(Updated May 14, 2018, 7 p.m.)
Review request for atlas, Daniela Otelea, David Radley, Graham Wallis, Mandy Chessell, and Ruxandra Rosu.
Repository: atlas
Description
-------
Create configuration for OMAG API in Atlas
Diffs (updated)
-----
om-fwk-ocf/pom.xml 8b1cefd
omag-api/pom.xml 2338286
omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerAdministration.java dd19018
omag-api/src/main/java/org/apache/atlas/omag/admin/OMAGServerCategory.java PRE-CREATION
omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminRESTServices.java PRE-CREATION
omag-api/src/main/java/org/apache/atlas/omag/admin/server/OMAGServerAdminResource.java ebc9f2a
omag-api/src/main/java/org/apache/atlas/omag/api/OMAGServerAdminResource.java PRE-CREATION
omag-server/pom.xml 527c5c3
omag-server/src/main/java/org/apache/atlas/omag/application/OMAGApplication.java 88397de
omag-server/src/main/resources/application.properties PRE-CREATION
omas-assetconsumer/pom.xml 29935e7
omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/api/AssetConsumerOMASResource.java PRE-CREATION
omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/client/AssetConsumer.java 80a98f5
omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/publisher/AssetConsumerPublisher.java
omas-assetconsumer/src/main/java/org/apache/atlas/omas/assetconsumer/server/AssetConsumerRESTServices.java 967be5a
omas-connectedasset/README.md 2f431df
omas-connectedasset/pom.xml 219c972
omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/api/ConnectedAssetOMASResource.java PRE-CREATION
omas-connectedasset/src/main/java/org/apache/atlas/omas/connectedasset/server/ConnectedAssetRESTServices.java 8ae6c37
omrs/pom.xml 50b9898
omrs/src/main/java/org/apache/atlas/omrs/admin/OMRSConfigurationFactory.java 7ae87c6
omrs/src/main/java/org/apache/atlas/omrs/api/OMRSRepositoryResource.java PRE-CREATION
omrs/src/main/java/org/apache/atlas/omrs/rest/server/OMRSRepositoryRESTServices.java 5948482
omrs/src/test/java/org/apache/atlas/omrs/archivemanager/opentypes/TestOpenMetadataTypesArchive.java 3f85317
omrs/src/test/java/org/apache/atlas/omrs/archivemanager/store/TestOMRSArchiveBuilder.java ccf0de6
webapp/pom.xml 03b8408
webapp/src/main/webapp/WEB-INF/applicationContext.xml 2ecd8d1
webapp/src/main/webapp/WEB-INF/openMetadataContext.xml PRE-CREATION
webapp/src/main/webapp/WEB-INF/web.xml 23dc063
Diff: https://reviews.apache.org/r/67083/diff/2/
Changes: https://reviews.apache.org/r/67083/diff/1-2/
Testing
-------
Create configuration for OMAG API in Atlas using Spring MVC Dispatcher servlet.
Change base URL for the API to "/open-metadata/access-services"
Clean maven unused dependenies
The Jira issue is https://issues.apache.org/jira/browse/ATLAS-2665
File Attachments (updated)
----------------
Added apache licence to a properties file
https://reviews.apache.org/media/uploaded/files/2018/05/11/77fbc4f6-b16a-42f9-983c-261f70f3ca9f__0002-ATLAS-2665-Added-apache-licence-to-properties-file.patch
0003-ATLAS-2665-comments-fixed.patch
https://reviews.apache.org/media/uploaded/files/2018/05/11/004f018b-1ee5-4da1-91d4-b50f4913298d__0003-ATLAS-2665-comments-fixed.patch
ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
https://reviews.apache.org/media/uploaded/files/2018/05/14/160f8499-661d-4fa9-8ce1-afe4bd88b723__ATLAS-2665-Add-OMAG-API-in-Atlas-v2.patch
Thanks,
Bogdan Sava