You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/06/24 00:22:25 UTC
[GitHub] [incubator-yunikorn-site] holdenk opened a new pull request #59: [YUNIKORN-726] Add instructions to approve cert requests
holdenk opened a new pull request #59:
URL: https://github.com/apache/incubator-yunikorn-site/pull/59
These requests may not be auto-approved in newer version of Kubernetes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-site] wilfred-s commented on pull request #59: [YUNIKORN-726] Add instructions to approve cert requests
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on pull request #59:
URL: https://github.com/apache/incubator-yunikorn-site/pull/59#issuecomment-1024194273
Based on the changes we have made there is no longer a script and we no longer need to approve any certificates.
@holdenk I think this has been made obsolete with the new deployment code of the admission controller.
I think we can close this one, please confirm if that is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-site] craigcondit commented on pull request #59: [YUNIKORN-726] Add instructions to approve cert requests
Posted by GitBox <gi...@apache.org>.
craigcondit commented on pull request #59:
URL: https://github.com/apache/incubator-yunikorn-site/pull/59#issuecomment-1026354546
Closing, as this is no longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-site] craigcondit commented on pull request #59: [YUNIKORN-726] Add instructions to approve cert requests
Posted by GitBox <gi...@apache.org>.
craigcondit commented on pull request #59:
URL: https://github.com/apache/incubator-yunikorn-site/pull/59#issuecomment-1024211981
> Based on the changes we have made there is no longer a script and we no longer need to approve any certificates.
Correct.
> @holdenk I think this has been made obsolete with the new deployment code of the admission controller.
Correct.
> I think we can close this one, please confirm if that is correct.
Yes we can close this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-site] wilfred-s commented on pull request #59: [YUNIKORN-726] Add instructions to approve cert requests
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on pull request #59:
URL: https://github.com/apache/incubator-yunikorn-site/pull/59#issuecomment-897397126
This is the line that approves the request in the [script](https://github.com/apache/incubator-yunikorn-k8shim/blob/0bd93660ec8b9b99dd28ae93ea755a52d0187741/deployments/admission-controllers/scheduler/generate-signed-ca.sh#L91)
Is this related to YUNIKORN-625 and indirectly YUNIKORN-674? If so we should work on that issue. I have mentioned in discussion before that we should use go code and not a shell script to deploy the admin controller. That would allow us to recompile the admin deployment code for specific K8s versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-site] craigcondit closed pull request #59: [YUNIKORN-726] Add instructions to approve cert requests
Posted by GitBox <gi...@apache.org>.
craigcondit closed pull request #59:
URL: https://github.com/apache/incubator-yunikorn-site/pull/59
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org