You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Alex Parvulescu (JIRA)" <ji...@apache.org> on 2016/06/23 15:09:16 UTC

[jira] [Commented] (OAK-3988) Offline compaction should avoid loading external binaries

    [ https://issues.apache.org/jira/browse/OAK-3988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346575#comment-15346575 ] 

Alex Parvulescu commented on OAK-3988:
--------------------------------------

merged to branch 1.2 with r1749914.

> Offline compaction should avoid loading external binaries
> ---------------------------------------------------------
>
>                 Key: OAK-3988
>                 URL: https://issues.apache.org/jira/browse/OAK-3988
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: segmentmk
>            Reporter: Alex Parvulescu
>            Assignee: Alex Parvulescu
>             Fix For: 1.4, 1.3.16, 1.2.17
>
>
> OAK-3965 uncovered an issue with the {{size}} calls on PropertyNodeStates when dealing with external binaries, and the fix effectively breaks offline compaction on repos with external data stores.
> The issue is twofold:
> * OAK-3965 breaks offline compaction in certain setups
> * the current code puts all the nodes with an external binary in the compaction map, skipping the size filter
> I think the offline compactor should basically ignore the external binaries in checking if a node meets the compaction map criteria or not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)