You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/04/03 00:35:36 UTC
[GitHub] [druid] suneet-s opened a new pull request #9605: Fix potential
integer overflow in BufferArrayGrouper
suneet-s opened a new pull request #9605: Fix potential integer overflow in BufferArrayGrouper
URL: https://github.com/apache/druid/pull/9605
This change fixes a potential integer overflow in BufferArrayGrouper that
was flagged by LGTM. It also adds a check that the vectorized arrays are
initialized before aggregateVector is called.
The changes in HashTableUtils should not have any effect since the numbers
being multiplied are small, but the change will remove the warnings from
being flagged in LGTM.
For this to happen, the number of rows needs to be >= Int.MAX/4
I can't tell by reading the code whether the VectorCursorGranularizer
actually produces a situation like this in a production cluster.
<hr>
This PR has:
- [ ] been self-reviewed.
- [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] lgtm-com[bot] commented on issue #9605: Fix potential
integer overflow in BufferArrayGrouper#aggregateVector
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on issue #9605: Fix potential integer overflow in BufferArrayGrouper#aggregateVector
URL: https://github.com/apache/druid/pull/9605#issuecomment-609938351
This pull request **fixes 7 alerts** when merging 774799007422112aa43ca7cbd614457c826df46b into 40e84a171b8be8e87db20b0c5c189aef1b860f41 - [view on LGTM.com](https://lgtm.com/projects/g/apache/druid/rev/pr-72332c1187097fcdaedbbfc6de499a413bcd5f2c)
**fixed alerts:**
* 7 for Result of multiplication cast to wider type
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] lgtm-com[bot] commented on issue #9605: Fix potential
integer overflow in BufferArrayGrouper#aggregateVector
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on issue #9605: Fix potential integer overflow in BufferArrayGrouper#aggregateVector
URL: https://github.com/apache/druid/pull/9605#issuecomment-611613315
This pull request **fixes 7 alerts** when merging 5c8ed3cb1a5df84a484ace25c6c474c1a6d97a25 into a6790ff22a9d883d789f3b5de0da02b9d8d19b69 - [view on LGTM.com](https://lgtm.com/projects/g/apache/druid/rev/pr-9ce6d8be570389ab3f35c496a6742c26f0a76d69)
**fixed alerts:**
* 7 for Result of multiplication cast to wider type
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm merged pull request #9605: Fix potential integer
overflow in BufferArrayGrouper#aggregateVector
Posted by GitBox <gi...@apache.org>.
gianm merged pull request #9605: Fix potential integer overflow in BufferArrayGrouper#aggregateVector
URL: https://github.com/apache/druid/pull/9605
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org