You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@avro.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/11/16 15:43:00 UTC

[jira] [Updated] (AVRO-3905) [Rust] Fix clippy error with Rust 1.74.0

     [ https://issues.apache.org/jira/browse/AVRO-3905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ASF GitHub Bot updated AVRO-3905:
---------------------------------
    Labels: pull-request-available  (was: )

> [Rust] Fix clippy error with Rust 1.74.0
> ----------------------------------------
>
>                 Key: AVRO-3905
>                 URL: https://issues.apache.org/jira/browse/AVRO-3905
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: rust
>            Reporter: Martin Tzvetanov Grigorov
>            Assignee: Martin Tzvetanov Grigorov
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The newly released 1.74.0 suggests the following improvement in the test code:
>  
> {code:java}
>     Checking zstd v0.12.4
>     Checking hello-wasm v0.1.0 (/home/martin/git/apache/avro/lang/rust/wasm-demo)
> error: this loop never actually loops
>   --> avro_derive/tests/derive.rs:72:9
>    |
> 72 | /         for res in reader {
> 73 | |             match res {
> 74 | |                 Ok(value) => {
> 75 | |                     return from_value::<T>(&value).unwrap();
> ...  |
> 78 | |             }
> 79 | |         }
>    | |_________^
>    |
>    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop
>    = note: `-D clippy::never-loop` implied by `-D clippy::all`
>    = help: to override `-D clippy::all` add `#[allow(clippy::never_loop)]`
> help: if you need the first element of the iterator, try writing
>    |
> 72 |         if let Some(res) = reader.next() {
>    |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>  {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)