[jira] [Comment Edited] (HBASE-15969) add precommit check for commit message formating

["Andrew Purtell (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-15969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15318723#comment-15318723 ] 

Andrew Purtell edited comment on HBASE-15969 at 6/7/16 3:48 PM:
----------------------------------------------------------------

bq. Do we want to expressly prohibit signed-off-by lines on the contributor-attribution-in-message form?

No, I think it's fine to be permissive. 
Edit: Actually if the consensus is we always want signed-off-by lines or even GPG signing of commits, that's fine by me


was (Author: apurtell):
bq. Do we want to expressly prohibit signed-off-by lines on the contributor-attribution-in-message form?

No, I think it's fine to be permissive. 

> add precommit check for commit message formating
> ------------------------------------------------
>
>                 Key: HBASE-15969
>                 URL: https://issues.apache.org/jira/browse/HBASE-15969
>             Project: HBase
>          Issue Type: Improvement
>          Components: build
>            Reporter: Sean Busbey
>
> add a precommit check that sees if commit messages are of the form:
> {code}
> HBASE-XXXXX Single line summary of issues, pref under 76 col
> Optional extended description that might contain pre-existing signed-off by
> entries if e.g. it's a version posted by a reviewer as an update.
> Signed-off-by: Jane Reviewer <jr...@example.com>
> {code}
> Open to other things we can easily check for via regex (please add in comments).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)