You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by ch...@apache.org on 2020/06/02 12:37:23 UTC
[flink] branch release-1.10 updated (6f247b4 -> fc2d419)
This is an automated email from the ASF dual-hosted git repository.
chesnay pushed a change to branch release-1.10
in repository https://gitbox.apache.org/repos/asf/flink.git.
from 6f247b4 Revert "[FLINK-17558][runtime] Add Executors#newCachedThreadPool"
new 7677674 [FLINK-18008][runtime] HistoryServer logs environment info
new fc2d419 [FLINK-18010][runtime] Expand HistoryServer logging
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../flink/runtime/webmonitor/history/HistoryServer.java | 3 +++
.../webmonitor/history/HistoryServerArchiveFetcher.java | 11 ++++++++++-
2 files changed, 13 insertions(+), 1 deletion(-)
[flink] 02/02: [FLINK-18010][runtime] Expand HistoryServer logging
Posted by ch...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
chesnay pushed a commit to branch release-1.10
in repository https://gitbox.apache.org/repos/asf/flink.git
commit fc2d4192080e79f6c8a980e1fddd5367212654ca
Author: Chesnay Schepler <ch...@apache.org>
AuthorDate: Thu May 28 15:37:26 2020 +0200
[FLINK-18010][runtime] Expand HistoryServer logging
---
.../webmonitor/history/HistoryServerArchiveFetcher.java | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java
index fd6069a..5a41173 100644
--- a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java
+++ b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java
@@ -186,11 +186,13 @@ class HistoryServerArchiveFetcher {
@Override
public void run() {
try {
+ LOG.debug("Starting archive fetching.");
List<ArchiveEvent> events = new ArrayList<>();
Set<String> jobsToRemove = new HashSet<>(cachedArchives);
for (HistoryServer.RefreshLocation refreshLocation : refreshDirs) {
Path refreshDir = refreshLocation.getPath();
FileSystem refreshFS = refreshLocation.getFs();
+ LOG.debug("Checking archive directory {}.", refreshDir);
// contents of /:refreshDir
FileStatus[] jobArchives;
@@ -214,7 +216,11 @@ class HistoryServerArchiveFetcher {
continue;
}
jobsToRemove.remove(jobID);
- if (!cachedArchives.contains(jobID)) {
+
+ if (cachedArchives.contains(jobID)) {
+ LOG.trace("Ignoring archive {} because it was already fetched.", jobArchivePath);
+ } else {
+ LOG.info("Processing archive {}.", jobArchivePath);
try {
for (ArchivedJson archive : FsJobArchivist.getArchivedJsons(jobArchive.getPath())) {
String path = archive.getPath();
@@ -224,6 +230,7 @@ class HistoryServerArchiveFetcher {
if (path.equals(JobsOverviewHeaders.URL)) {
target = new File(webOverviewDir, jobID + JSON_FILE_ENDING);
} else if (path.equals("/joboverview")) { // legacy path
+ LOG.debug("Migrating legacy archive {}", jobArchivePath);
json = convertLegacyJobOverview(json);
target = new File(webOverviewDir, jobID + JSON_FILE_ENDING);
} else {
@@ -253,6 +260,7 @@ class HistoryServerArchiveFetcher {
}
events.add(new ArchiveEvent(jobID, ArchiveEventType.CREATED));
cachedArchives.add(jobID);
+ LOG.info("Processing archive {} finished.", jobArchivePath);
} catch (IOException e) {
LOG.error("Failure while fetching/processing job archive for job {}.", jobID, e);
// Make sure we do not include this job in the overview
@@ -281,6 +289,7 @@ class HistoryServerArchiveFetcher {
updateJobOverview(webOverviewDir, webDir);
}
events.forEach(jobArchiveEventListener::accept);
+ LOG.debug("Finished archive fetching.");
} catch (Exception e) {
LOG.error("Critical failure while fetching/processing job archives.", e);
}
[flink] 01/02: [FLINK-18008][runtime] HistoryServer logs
environment info
Posted by ch...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
chesnay pushed a commit to branch release-1.10
in repository https://gitbox.apache.org/repos/asf/flink.git
commit 7677674dd2dab41c989b8a66e230b4ca68629eac
Author: Chesnay Schepler <ch...@apache.org>
AuthorDate: Thu May 28 15:10:28 2020 +0200
[FLINK-18008][runtime] HistoryServer logs environment info
---
.../org/apache/flink/runtime/webmonitor/history/HistoryServer.java | 3 +++
1 file changed, 3 insertions(+)
diff --git a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServer.java b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServer.java
index 3dd2d47..dda88ca 100644
--- a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServer.java
+++ b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServer.java
@@ -33,6 +33,7 @@ import org.apache.flink.runtime.rest.handler.router.Router;
import org.apache.flink.runtime.rest.messages.DashboardConfiguration;
import org.apache.flink.runtime.security.SecurityConfiguration;
import org.apache.flink.runtime.security.SecurityUtils;
+import org.apache.flink.runtime.util.EnvironmentInformation;
import org.apache.flink.runtime.webmonitor.WebMonitorUtils;
import org.apache.flink.runtime.webmonitor.utils.WebFrontendBootstrap;
import org.apache.flink.util.ExceptionUtils;
@@ -104,6 +105,8 @@ public class HistoryServer {
private final Thread shutdownHook;
public static void main(String[] args) throws Exception {
+ EnvironmentInformation.logEnvironmentInfo(LOG, "HistoryServer", args);
+
ParameterTool pt = ParameterTool.fromArgs(args);
String configDir = pt.getRequired("configDir");