You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2018/07/18 01:19:47 UTC
Review Request 67955: Added some new generic flag parsers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67955/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
Added some new generic flag parsers.
Diffs
-----
3rdparty/stout/include/stout/flags/parse.hpp 4566b798b8b66d47779a28cabdea06f588012686
Diff: https://reviews.apache.org/r/67955/diff/1/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 67955: Added some new generic flag parsers.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67955/#review210339
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On July 18, 2018, 1:19 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67955/
> -----------------------------------------------------------
>
> (Updated July 18, 2018, 1:19 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added some new generic flag parsers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/flags/parse.hpp 4566b798b8b66d47779a28cabdea06f588012686
>
>
> Diff: https://reviews.apache.org/r/67955/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 67955: Added some new generic flag parsers.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On July 19, 2018, 6:51 p.m., Kevin Klues wrote:
> > 3rdparty/stout/include/stout/flags/parse.hpp
> > Lines 249-251 (patched)
> > <https://reviews.apache.org/r/67955/diff/1/?file=2061303#file2061303line249>
> >
> > This comment is wrong. It's not for unsigned ints, it's for strings.
Okay I'll fix it, any reason I can't ship it once I change the comment?
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67955/#review206242
-----------------------------------------------------------
On July 18, 2018, 1:19 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67955/
> -----------------------------------------------------------
>
> (Updated July 18, 2018, 1:19 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added some new generic flag parsers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/flags/parse.hpp 4566b798b8b66d47779a28cabdea06f588012686
>
>
> Diff: https://reviews.apache.org/r/67955/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 67955: Added some new generic flag parsers.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67955/#review206242
-----------------------------------------------------------
3rdparty/stout/include/stout/flags/parse.hpp
Lines 249-251 (patched)
<https://reviews.apache.org/r/67955/#comment289147>
This comment is wrong. It's not for unsigned ints, it's for strings.
- Kevin Klues
On July 18, 2018, 1:19 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67955/
> -----------------------------------------------------------
>
> (Updated July 18, 2018, 1:19 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added some new generic flag parsers.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/flags/parse.hpp 4566b798b8b66d47779a28cabdea06f588012686
>
>
> Diff: https://reviews.apache.org/r/67955/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>