You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-commits@lucene.apache.org by yo...@apache.org on 2007/10/18 03:40:58 UTC

svn commit: r585775 - /lucene/solr/trunk/src/java/org/apache/solr/request/PHPResponseWriter.java

Author: yonik
Date: Wed Oct 17 18:40:57 2007
New Revision: 585775

URL: http://svn.apache.org/viewvc?rev=585775&view=rev
Log:
don't buffer string escaping for php response writer either: SOLR-377

Modified:
    lucene/solr/trunk/src/java/org/apache/solr/request/PHPResponseWriter.java

Modified: lucene/solr/trunk/src/java/org/apache/solr/request/PHPResponseWriter.java
URL: http://svn.apache.org/viewvc/lucene/solr/trunk/src/java/org/apache/solr/request/PHPResponseWriter.java?rev=585775&r1=585774&r2=585775&view=diff
==============================================================================
--- lucene/solr/trunk/src/java/org/apache/solr/request/PHPResponseWriter.java (original)
+++ lucene/solr/trunk/src/java/org/apache/solr/request/PHPResponseWriter.java Wed Oct 17 18:40:57 2007
@@ -77,25 +77,24 @@
   @Override
   protected void writeKey(String fname, boolean needsEscaping) throws IOException {
     writeStr(null, fname, needsEscaping);
-    writer.write("=>");
+    writer.write('=');
+    writer.write('>');
   }
 
   @Override
   public void writeStr(String name, String val, boolean needsEscaping) throws IOException {
     if (needsEscaping) {
-      StringBuilder sb = new StringBuilder(val.length());
-      sb.append('\'');
+      writer.write('\'');
       for (int i=0; i<val.length(); i++) {
         char ch = val.charAt(i);
         switch (ch) {
           case '\'':
-          case '\\': sb.append('\\'); sb.append(ch); break;
+          case '\\': writer.write('\\'); writer.write(ch); break;
           default:
-            sb.append(ch);
+            writer.write(ch);
         }
       }
-      sb.append('\'');
-      writer.append(sb);
+      writer.write('\'');
     } else {
       writer.write('\'');
       writer.write(val);