You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/02/20 07:48:35 UTC

[GitHub] sijie commented on issue #1254: Use advertisedAddress for bookies in pulsar standalone

sijie commented on issue #1254: Use advertisedAddress for bookies in pulsar standalone
URL: https://github.com/apache/incubator-pulsar/pull/1254#issuecomment-366892738
 
 
   @rdhabalia 
   
   I think the idea here is : if advertisedAddress is not specified, both zookeeper and bookie use `127.0.0.1` which it was using before; if advertisedAddress is specified (e.g. for testing in docker environment), all three components (zk, bk and broker) use the advertisedAddress. so I don't think we should use InetAddress.getLocalHost().getHostName() which would resolve to other ip address than `127.0.0.1`.
   
   Hope this make sense to you.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services