You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "cloud-fan (via GitHub)" <gi...@apache.org> on 2026/08/18 19:16:49 UTC
[PR] [SPARK-58021][CONNECT][FOLLOWUP] Strip launcher-owned binding address from seed configuration [spark]
cloud-fan opened a new pull request, #58088:
URL: https://github.com/apache/spark/pull/58088
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'common/utils/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Followup to https://github.com/apache/spark/pull/57684.
Add `spark.connect.grpc.binding.address` to the settings removed by
`_strip_launcher_conf` before writing local Connect server seed properties.
### Why are the changes needed?
The local server launcher sets the binding address explicitly on its command line. Removing the
same setting from seed properties keeps all launcher-owned settings centralized and avoids carrying
a competing value in the generated properties file.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
No new test was added because this completes the existing launcher-owned configuration allowlist;
the behavior is covered by the existing seed-configuration tests from the original change.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex (GPT-5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58021][CONNECT][FOLLOWUP] Strip launcher-owned binding address from seed configuration [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #58088:
URL: https://github.com/apache/spark/pull/58088#issuecomment-5391653229
thanks for the review, merging to master/4.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58021][CONNECT][FOLLOWUP] Strip launcher-owned binding address from seed configuration [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #58088:
URL: https://github.com/apache/spark/pull/58088#issuecomment-5391666689
**Merge Summary:**
- merged into master https://github.com/apache/spark/commit/7b2c5329d22ca2df799f2910edaf23b0a97f3593
- merged into branch-4.x https://github.com/apache/spark/commit/3754626a322966e833cae8633acaca18709e2358
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58021][CONNECT][FOLLOWUP] Strip launcher-owned binding address from seed configuration [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #58088:
URL: https://github.com/apache/spark/pull/58088#issuecomment-5333151729
cc @ericm-db @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58021][CONNECT][FOLLOWUP] Strip launcher-owned binding address from seed configuration [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #58088:
URL: https://github.com/apache/spark/pull/58088#issuecomment-5336284919
Thank you @cloud-fan!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58021][CONNECT][FOLLOWUP] Strip launcher-owned binding address from seed configuration [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #58088: [SPARK-58021][CONNECT][FOLLOWUP] Strip launcher-owned binding address from seed configuration
URL: https://github.com/apache/spark/pull/58088
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org