You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2024/04/03 15:35:44 UTC

[PR] fix(r): Fix tests for platforms where arrow dataset and/or zip is not available [arrow-nanoarrow]

paleolimbot opened a new pull request, #415:
URL: https://github.com/apache/arrow-nanoarrow/pull/415

   The `utils::zip()` function is not all that reliable; however, we only use it to create test data anyway.
   
   While running the tests, I also noticed that one of the IPC skips that checks for Arrow dataset does so incorrectly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(r): Fix tests for platforms where arrow dataset and/or zip is not available [arrow-nanoarrow]

Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot merged PR #415:
URL: https://github.com/apache/arrow-nanoarrow/pull/415


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(r): Fix tests for platforms where arrow dataset and/or zip is not available [arrow-nanoarrow]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #415:
URL: https://github.com/apache/arrow-nanoarrow/pull/415#issuecomment-2034956854

   ## [Codecov](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/415?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 88.76%. Comparing base [(`9935713`)](https://app.codecov.io/gh/apache/arrow-nanoarrow/commit/9935713a4a853e8cdcd32ec42b983df04093ae23?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`bb8a5f4`)](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/415?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@           Coverage Diff           @@
   ##             main     #415   +/-   ##
   =======================================
     Coverage   88.76%   88.76%           
   =======================================
     Files          82       82           
     Lines       14633    14633           
   =======================================
     Hits        12989    12989           
     Misses       1644     1644           
   ```
   
   
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/415?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org