You are viewing a plain text version of this content. The canonical link for it is here.
Posted to c-dev@axis.apache.org by "nadir amra (JIRA)" <ax...@ws.apache.org> on 2006/12/26 03:29:21 UTC
[jira] Commented: (AXISCPP-1011) faultactor is facultative in
SoapFaults
[ http://issues.apache.org/jira/browse/AXISCPP-1011?page=comments#action_12460840 ]
nadir amra commented on AXISCPP-1011:
-------------------------------------
Fault detail is also optional....
> faultactor is facultative in SoapFaults
> ---------------------------------------
>
> Key: AXISCPP-1011
> URL: http://issues.apache.org/jira/browse/AXISCPP-1011
> Project: Axis-C++
> Issue Type: Bug
> Components: SOAP
> Affects Versions: current (nightly)
> Environment: WIN2KSP4 VC6SP6 JDK1.5.0_07
> Reporter: Franz Fehringer
> Assigned To: nadir amra
>
> In handling SoapFaults, faultactor is retrieved unconditionally (next()) where it should (being facultative) be checked for presence first (peek()).
> $ pwd
> /cd/d/Quellen/SVN/axis/c/src/soap
> Index: SoapDeSerializer.cpp
> ===================================================================
> --- SoapDeSerializer.cpp (Revision 480584)
> +++ SoapDeSerializer.cpp (Arbeitskopie)
> @@ -401,7 +401,8 @@
> char *pcDetail;
> char *pcFaultCode;
> char *pcFaultstring;
> - char *pcFaultactor;
> + char *pcFaultactor = "";
> + char* pcName;
> if (0 == strcmp ("Fault", pName))
> {
> if (0 != strcmp (m_pNode->m_pchNameOrValue, pName))
> @@ -431,10 +432,14 @@
> if ( pcFaultstring )
> delete [] pcFaultstring;
>
> - pcFaultactor = getElementAsString ("faultactor", 0);
> - pFault->setFaultactor (pcFaultactor == NULL ? "" : pcFaultactor);
> - if ( pcFaultactor )
> - delete [] pcFaultactor;
> + pName = peekNextElementName();
> + if (strcmp(pName, "faultactor") == 0)
> + {
> + pcFaultactor = getElementAsString ("faultactor", 0);
> + pFault->setFaultactor (pcFaultactor == NULL ? "" : pcFaultactor);
> + if ( pcFaultactor )
> + delete [] pcFaultactor;
> + }
>
> // FJP Changed the namespace from null to a single space (an impossible
> // value) to help method know
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org