[GitHub] [solr] dsmiley commented on a change in pull request #349: Dependency tune-up of solr-core

[GitBox <gi...@apache.org>]

dsmiley commented on a change in pull request #349:
URL: https://github.com/apache/solr/pull/349#discussion_r731106076



##########
File path: solr/core/build.gradle
##########
@@ -20,144 +20,158 @@ apply plugin: 'java-library'
 
 description = 'Apache Solr Core'
 
+configurations.all {

Review comment:
       I strongly disagree for logging libs in particular.  Logging dependencies are a PITA and should be made globally -- we want these libs but not these others).  It doesn't matter which of our dependencies is depending on whichever logging libs that they maybe shouldn't be doing so in the first place (it's a widespread issue).
   I think annotation libs are similar, if we know some are needless.  Who cares who is depending on them if we know we don't want them.
   If some day one of us wonders, say, who is depending on this funny-sounding 'animal-sniffer-annotations' lib any way?  Comment-out the global exclusion then generate the dependency tree to see.
   
   For that avatica-metrics lib:  It's annoying to exclude the same lib from multiple places, but okay I'll do it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org