You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "yashmayya (via GitHub)" <gi...@apache.org> on 2023/07/18 10:20:31 UTC
[GitHub] [kafka] yashmayya opened a new pull request, #14036: MINOR: Fix Javadocs for SourceTaskContext::transactionContext and SinkTaskContext::errantRecordReporter to use NoSuchMethodError instead of NoSuchMethodException
yashmayya opened a new pull request, #14036:
URL: https://github.com/apache/kafka/pull/14036
- `NoSuchMethodError` is thrown if an application tries to call a specified method of a class (either static or instance), and that class no longer has a definition of that method. Normally, this error is caught by the compiler; this error can only occur at run time if the definition of a class has incompatibly changed.
- `NoSuchMethodException` is thrown when trying to reflectively access a method that does not exist.
- Both the `SourceTaskContext::transactionContext` and `SinkTaskContext::errantRecordReporter` methods use `NoSuchMethodError` in the example code block (which is the correct `Throwable` to use in this situation) but incorrectly specify `NoSuchMethodException` in their Javadocs.
https://github.com/apache/kafka/blob/a1f6ab69387deb10988461152a0087f0cd2827c4/connect/api/src/main/java/org/apache/kafka/connect/sink/SinkTaskContext.java#L110-L117
https://github.com/apache/kafka/blob/a1f6ab69387deb10988461152a0087f0cd2827c4/connect/api/src/main/java/org/apache/kafka/connect/source/SourceTaskContext.java#L51-L58
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] yashmayya commented on pull request #14036: MINOR: Fix Javadocs for SourceTaskContext::transactionContext and SinkTaskContext::errantRecordReporter to use NoSuchMethodError instead of NoSuchMethodException
Posted by "yashmayya (via GitHub)" <gi...@apache.org>.
yashmayya commented on PR #14036:
URL: https://github.com/apache/kafka/pull/14036#issuecomment-1639951663
Hi @gharris1727, I noticed this small discrepancy after our related discussion [here](https://github.com/apache/kafka/pull/14024#discussion_r1265731323). Could you please take a look whenever you get a chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] gharris1727 merged pull request #14036: MINOR: Fix Javadocs for SourceTaskContext::transactionContext and SinkTaskContext::errantRecordReporter to use NoSuchMethodError instead of NoSuchMethodException
Posted by "gharris1727 (via GitHub)" <gi...@apache.org>.
gharris1727 merged PR #14036:
URL: https://github.com/apache/kafka/pull/14036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] yashmayya commented on pull request #14036: MINOR: Fix Javadocs for SourceTaskContext::transactionContext and SinkTaskContext::errantRecordReporter to use NoSuchMethodError instead of NoSuchMethodException
Posted by "yashmayya (via GitHub)" <gi...@apache.org>.
yashmayya commented on PR #14036:
URL: https://github.com/apache/kafka/pull/14036#issuecomment-1642557203
Thanks Greg!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org