You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/07/30 14:42:06 UTC

[GitHub] [calcite] JulianFeinauer opened a new pull request #1343: 1935 mr prepare pr

JulianFeinauer opened a new pull request #1343: 1935 mr prepare pr
URL: https://github.com/apache/calcite/pull/1343
 
 
   I finally finished to bring the joint work on MATCH_RECOGNIZE to a state where at least two non-trivial Tests work, see [3].
   The Work is based on a lot of preliminary work of Hongze and Julian (Hyde) which was done over a period of over a year, therefore the code is rather large.
   I also decided to not squash this PR (yet) as most of the code is not from myself but from Hongze and Julian which would be lost, in case of a squash.
   As I had some issues during the implementation and found, I think, some bugs in (yet) unused parts of the code I would be very grateful for support with reviewing this PR and bringing the code base to a state where it is merge-able into master.
   
   Most of the discussions can be found in [1] and [2].
   
   The tests that work can be found in JdbcTest:
   •	testSimpleMatch
   •	testMatch
   
   The query that works now is:
   
   ```
   select *
   from "hr"."emps" match_recognize (
     order by "empid" desc
     measures "commission" as c,
       "empid" as empid
     pattern (s up)
     define up as up."commission" < prev(up."commission"))
   ```
   which covers all basic ingredients of the MATCH_RECOGNIZE clause.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services