You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Carlos Sanchez <ca...@apache.org> on 2007/08/21 19:52:25 UTC

Re: svn commit: r549521 [1/3] - in /maven/shared/trunk/maven-dependency-tree: ./ src/main/java/org/apache/maven/shared/dependency/tree/ src/main/java/org/apache/maven/shared/dependency/tree/filter/ src/main/java/org/apache/maven/shared/dependency/tre

Why DependencyNode.getDepth was deprecated? it's still useful


On 6/21/07, markh@apache.org <ma...@apache.org> wrote:
> Author: markh
> Date: Thu Jun 21 08:53:42 2007
> New Revision: 549521
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=549521
> Log:
> Major changes to maven-dependency-tree:
>
> o support for node states: included, omitted for conflict, etc.
> o node filter API and various implementations for pruning the tree
> o node visitor API and various implementations for processing the tree
> o lots of tests and Javadoc
>


-- 
I could give you my word as a Spaniard.
No good. I've known too many Spaniards.
                             -- The Princess Bride

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r549521 [1/3] - in /maven/shared/trunk/maven-dependency-tree: ./ src/main/java/org/apache/maven/shared/dependency/tree/ src/main/java/org/apache/maven/shared/dependency/tree/filter/ src/main/java/org/apache/maven/shared/dependency/tre

Posted by Mark Hobson <ma...@gmail.com>.
On 29/08/2007, Carlos Sanchez <ca...@apache.org> wrote:
> thanks, I'm going to add this to the javadoc ;)

Sure thanks, I'll try to be less succinct in future :)

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r549521 [1/3] - in /maven/shared/trunk/maven-dependency-tree: ./ src/main/java/org/apache/maven/shared/dependency/tree/ src/main/java/org/apache/maven/shared/dependency/tree/filter/ src/main/java/org/apache/maven/shared/dependency/tre

Posted by Carlos Sanchez <ca...@apache.org>.
thanks, I'm going to add this to the javadoc ;)

On 8/29/07, Mark Hobson <ma...@gmail.com> wrote:
> On 21/08/2007, Carlos Sanchez <ca...@apache.org> wrote:
> > Why DependencyNode.getDepth was deprecated? it's still useful
>
> Sorry for the delayed reply - working my way though my inbox..
>
> It was deprecated with the introduction of node visitors and filters
> since it can give misleading results.  For example, consider
> serialising a tree with a filter using a visitor: getDepth would
> return the unfiltered depth of a node, whereas the correct depth would
> be calculated by the visitor.
>
> Cheers,
>
> Mark
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>


-- 
I could give you my word as a Spaniard.
No good. I've known too many Spaniards.
                             -- The Princess Bride

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r549521 [1/3] - in /maven/shared/trunk/maven-dependency-tree: ./ src/main/java/org/apache/maven/shared/dependency/tree/ src/main/java/org/apache/maven/shared/dependency/tree/filter/ src/main/java/org/apache/maven/shared/dependency/tre

Posted by Mark Hobson <ma...@gmail.com>.
On 21/08/2007, Carlos Sanchez <ca...@apache.org> wrote:
> Why DependencyNode.getDepth was deprecated? it's still useful

Sorry for the delayed reply - working my way though my inbox..

It was deprecated with the introduction of node visitors and filters
since it can give misleading results.  For example, consider
serialising a tree with a filter using a visitor: getDepth would
return the unfiltered depth of a node, whereas the correct depth would
be calculated by the visitor.

Cheers,

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org