[jira] [Commented] (CALCITE-4285) Replace jsr305 dependency with checkerframework and errorprone_annotations

["Vladimir Sitnikov (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17207737#comment-17207737 ] 

Vladimir Sitnikov commented on CALCITE-4285:
--------------------------------------------

Unfortunately, Guava still depends on jsr305. They use {{ParametersAreNonNullByDefault }} to keep Kotlin compiler happy: https://github.com/google/guava/issues/3198#issuecomment-402283572, so we can't exclude jsr305 from the compile classpath yet :-/

> Replace jsr305 dependency with checkerframework and errorprone_annotations
> --------------------------------------------------------------------------
>
>                 Key: CALCITE-4285
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4285
>             Project: Calcite
>          Issue Type: Sub-task
>          Components: core, druid-adapter
>    Affects Versions: 1.25.0
>            Reporter: Vladimir Sitnikov
>            Assignee: Vladimir Sitnikov
>            Priority: Major
>
> jsr305 does not support type annotations, so it can't be used like {{List<@Nullable String>}}, and it results in duplicate {{@Nullable}} annotations on the classpath (checkerframework and jsr305)
> The solution is to use {{checkerframework}} for nullability, and {{errorprone}} annotations for dataflow-like checks (e.g. {{@CheckReturnValue}})



--
This message was sent by Atlassian Jira
(v8.3.4#803005)