You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/12 13:59:31 UTC
Review Request 70843: Replaced a pointer to managed
MockMasterAPISubscriberProcess with a pid.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70843/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
Replaced a pointer to managed MockMasterAPISubscriberProcess with a pid.
Diffs
-----
src/tests/master/mock_master_api_subscriber.hpp dde176a3a71e6394f4cace3d6333510a62cd2ae9
src/tests/master/mock_master_api_subscriber.cpp a1cd538447492dd58e7564b791aaafcc85d0aab2
Diff: https://reviews.apache.org/r/70843/diff/1/
Testing
-------
`./bin/mesos-tests.sh --gtest_filter="UpdateFramework*" --gtest_break_on_failure --gtest_repeat=1000`
Thanks,
Andrei Sekretenko
Re: Review Request 70843: Replaced a pointer to managed
MockMasterAPISubscriberProcess with a pid.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70843/#review215853
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On June 12, 2019, 1:59 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70843/
> -----------------------------------------------------------
>
> (Updated June 12, 2019, 1:59 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replaced a pointer to managed MockMasterAPISubscriberProcess with a pid.
>
>
> Diffs
> -----
>
> src/tests/master/mock_master_api_subscriber.hpp dde176a3a71e6394f4cace3d6333510a62cd2ae9
> src/tests/master/mock_master_api_subscriber.cpp a1cd538447492dd58e7564b791aaafcc85d0aab2
>
>
> Diff: https://reviews.apache.org/r/70843/diff/1/
>
>
> Testing
> -------
>
> `./bin/mesos-tests.sh --gtest_filter="UpdateFramework*" --gtest_break_on_failure --gtest_repeat=1000`
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 70843: Replaced a pointer to managed
MockMasterAPISubscriberProcess with a pid.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70843/#review215844
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70843]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 12, 2019, 6:59 a.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70843/
> -----------------------------------------------------------
>
> (Updated June 12, 2019, 6:59 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replaced a pointer to managed MockMasterAPISubscriberProcess with a pid.
>
>
> Diffs
> -----
>
> src/tests/master/mock_master_api_subscriber.hpp dde176a3a71e6394f4cace3d6333510a62cd2ae9
> src/tests/master/mock_master_api_subscriber.cpp a1cd538447492dd58e7564b791aaafcc85d0aab2
>
>
> Diff: https://reviews.apache.org/r/70843/diff/1/
>
>
> Testing
> -------
>
> `./bin/mesos-tests.sh --gtest_filter="UpdateFramework*" --gtest_break_on_failure --gtest_repeat=1000`
>
>
> Thanks,
>
> Andrei Sekretenko
>
>