You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by pe...@apache.org on 2010/11/05 16:50:52 UTC

svn commit: r1031643 - in /tomcat/trunk: java/org/apache/catalina/valves/mbeans-descriptors.xml webapps/docs/changelog.xml

Author: pero
Date: Fri Nov  5 15:50:51 2010
New Revision: 1031643

URL: http://svn.apache.org/viewvc?rev=1031643&view=rev
Log:
Make attribute enabled changeable via JMX at AccessLogValve

Modified:
    tomcat/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml
    tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml?rev=1031643&r1=1031642&r2=1031643&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml (original)
+++ tomcat/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml Fri Nov  5 15:50:51 2010
@@ -53,6 +53,7 @@
                
     <attribute name="enabled"
                description="Enable Access Logging"
+               is="false"
                type="boolean"/>
 
     <attribute name="fileDateFormat"
@@ -164,7 +165,7 @@
                
      <attribute name="enabled"
                description="Enable Access Logging"
-               is="true"
+               is="false"
                type="boolean"/>
 
     <attribute name="fileDateFormat"

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1031643&r1=1031642&r2=1031643&view=diff
==============================================================================
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Fri Nov  5 15:50:51 2010
@@ -91,7 +91,7 @@
         Improve debug logging for MapperListener registration. (markt)
       </add>
       <add>
-        Expose names of LifecycleListeners and ContainerListers for
+        Expose names of LifecycleListeners and ContainerListeners for
         StandardContext via JMX. (markt)
       </add>
       <add>
@@ -105,6 +105,9 @@
         Make Tomcat more tolerant of <code>null</code> when generating JMX names
         for Valves. (markt)
       </fix>
+      <fix>
+        Make AccessLogValve attribute <code>enabled</code> changeable to JMX. (pero)
+      </fix>
     </changelog>
   </subsection>
   <subsection name="Jasper">



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: svn commit: r1031643 - in /tomcat/trunk: java/org/apache/catalina/valves/mbeans-descriptors.xml webapps/docs/changelog.xml

Posted by Rainer Jung <ra...@kippdata.de>.
Hi Peter,

On 05.11.2010 16:50, pero@apache.org wrote:
> Author: pero
> Date: Fri Nov  5 15:50:51 2010
> New Revision: 1031643
>
> URL: http://svn.apache.org/viewvc?rev=1031643&view=rev
> Log:
> Make attribute enabled changeable via JMX at AccessLogValve
>
> Modified:
>      tomcat/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml
>      tomcat/trunk/webapps/docs/changelog.xml
>
> Modified: tomcat/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml
> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml?rev=1031643&r1=1031642&r2=1031643&view=diff
> ==============================================================================
> --- tomcat/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml (original)
> +++ tomcat/trunk/java/org/apache/catalina/valves/mbeans-descriptors.xml Fri Nov  5 15:50:51 2010
> @@ -53,6 +53,7 @@
>
>       <attribute name="enabled"
>                  description="Enable Access Logging"
> +               is="false"
>                  type="boolean"/>

isn't that the default? Did you notice my change r130000 a few days ago? 
Just in case you noticed the errors produced by the jmx proxy but didn't 
use the recent svn revision. I though that was already fixed after my 
change on Tuesday.

Regards,

Rainer


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org