[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4143: Use patricia trie to OnHeapTrieBasedStringDictionary

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #4143: Use patricia trie to OnHeapTrieBasedStringDictionary
URL: https://github.com/apache/incubator-pinot/pull/4143#discussion_r276903253
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/segment/index/readers/OnHeapTrieBasedDictionary.java
 ##########
 @@ -0,0 +1,33 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.core.segment.index.readers;
+
+import org.apache.pinot.core.segment.memory.PinotDataBuffer;
+
+
+/**
+ * Abstract base class for all on-heap trie dictionary implementations.
+ *
+ */
+public abstract class OnHeapTrieBasedDictionary extends ImmutableDictionaryReader {
+
+  protected OnHeapTrieBasedDictionary(PinotDataBuffer dataBuffer, int length, int numBytesPerValue, byte paddingByte) {
 
 Review comment:
   Do we need this constructor?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org