[GitHub] [incubator-seatunnel] BenJFan commented on issue #1753: [Feature][seatunnal-flink-sql] Support dynamic config for Flink SQL mode job

[GitBox <gi...@apache.org>]

BenJFan commented on issue #1753:
URL: https://github.com/apache/incubator-seatunnel/issues/1753#issuecomment-1110452487

   > @legendtkl Which env do you want to set, if you want to set the system environment, you can set these in [`seatunnel-env.sh`](https://github.com/apache/incubator-seatunnel/blob/dev/config/seatunnel-env.sh), if you want to set flink sql configuration, e.g. `table.exec.mini-batch.enabled`, `table.exec.mini-batch.size `, you can directly set in [`flink.sql.conf.template`](https://github.com/apache/incubator-seatunnel/blob/dev/config/flink.sql.conf.template)
   > 
   > Welcome to refactor this module, if you have any idea. But before your work, it's better to send your proposal to [dev@seatunnel.apache.org](mailto:dev@seatunnel.apache.org) with title [PROPOSAL] email title.
   > 
   > PS: to be honest, I want to remove the `seatunnel-core-flink-sql` module, since I think it's more convenient for the user to directly use flink sql client to submit the sql. cc @CalvinKirs @BenJFan
   
   Aggre with you.  `seatunnel-core-flink-sql` module is same as flink orginal client. We didn't do much thing on it. I think we can remove it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org