You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "gf2121 (via GitHub)" <gi...@apache.org> on 2023/09/25 08:29:12 UTC
[GitHub] [lucene] gf2121 opened a new pull request, #12586: Remove over-counting of deleted terms
gf2121 opened a new pull request, #12586:
URL: https://github.com/apache/lucene/pull/12586
`BufferedUpdates` used to count deleted terms without deduplication to respect `IndexWriterConfig.setMaxBufferedDeleteTerms`. As `IndexWriterConfig.setMaxBufferedDeleteTerms` is removed since [LUCENE-7868](https://issues.apache.org/jira/browse/LUCENE-7868), the overcounting can be avoided now.
Previous talk: https://github.com/apache/lucene/pull/12573/files#r1332924157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Remove over-counting of deleted terms [lucene]
Posted by "gf2121 (via GitHub)" <gi...@apache.org>.
gf2121 merged PR #12586:
URL: https://github.com/apache/lucene/pull/12586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] gf2121 commented on a diff in pull request #12586: Remove over-counting of deleted terms
Posted by "gf2121 (via GitHub)" <gi...@apache.org>.
gf2121 commented on code in PR #12586:
URL: https://github.com/apache/lucene/pull/12586#discussion_r1335560326
##########
lucene/core/src/java/org/apache/lucene/index/BufferedUpdates.java:
##########
@@ -284,6 +276,13 @@ <E extends Exception> void forEachOrdered(DeletedTermConsumer<E> consumer) throw
public long ramBytesUsed() {
return bytesUsed.get();
}
+
+ @Override
+ public String toString() {
Review Comment:
`DeletedTerms#toString` could be called when `VERBOSE_DELETES` enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org