You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@distributedlog.apache.org by arvindkandhare <gi...@git.apache.org> on 2017/03/08 04:11:11 UTC

[GitHub] incubator-distributedlog pull request #123: DL-193: Bumped up the Guava vers...

GitHub user arvindkandhare opened a pull request:

    https://github.com/apache/incubator-distributedlog/pull/123

    DL-193: Bumped up the Guava version

    Moving the Guava version from 16.0 to 20.0.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/arvindkandhare/incubator-distributedlog guava_version

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-distributedlog/pull/123.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #123
    
----
commit dcb8b647f2aec4cfaa2e13a872ee594999491210
Author: arvindkandhare <ar...@emc.com>
Date:   2017-03-08T04:06:27Z

    Bumped up the Guava version

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-distributedlog issue #123: DL-193: Bumped up the Guava version

Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:

    https://github.com/apache/incubator-distributedlog/pull/123
  
    LGTM +1. Thanks @arvindkandhare 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-distributedlog issue #123: DL-193: Bumped up the Guava version

Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:

    https://github.com/apache/incubator-distributedlog/pull/123
  
    gotcha. Is it possible to shade the guava in bookkeeper?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-distributedlog issue #123: DL-193: Bumped up the Guava version

Posted by arvindkandhare <gi...@git.apache.org>.
Github user arvindkandhare commented on the issue:

    https://github.com/apache/incubator-distributedlog/pull/123
  
    While the compile passes, the tests actually try to create a server process. This tries to start bookkeeper server, which has dependencies on Guava again. This means that this PR needs changes to the Bookkeeper pulled from: https://github.com/twitter/bookkeeper/. 
    As Guava has moved and changed the API quiet a bit, this is an involved changed. Another interesting point is that Apache bookkeeper uses even older version of Guava (13.0 in their master branch). So this PR should not go in before the Twitter bookkeeper moves towards this version.
    
    Do share your views on this.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-distributedlog issue #123: DL-193: Bumped up the Guava version

Posted by arvindkandhare <gi...@git.apache.org>.
Github user arvindkandhare commented on the issue:

    https://github.com/apache/incubator-distributedlog/pull/123
  
    Looking in to this. mvn compile passed for me locally. Maybe I should try running mvn clean install? Giving it a shot.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-distributedlog issue #123: DL-193: Bumped up the Guava version

Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:

    https://github.com/apache/incubator-distributedlog/pull/123
  
    Seems both travis CI and Jenkins failed with similar error
    
    `
    [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on project distributedlog-service_2.11: ExecutionException The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
    [ERROR] Command was /bin/sh -c cd /Users/travis/build/apache/incubator-distributedlog/distributedlog-service && /Library/Java/JavaVirtualMachines/jdk1.8.0_92.jdk/Contents/Home/jre/bin/java -Xmx3G -Djava.net.preferIPv4Stack=true -XX:MaxDirectMemorySize=2G -jar /Users/travis/build/apache/incubator-distributedlog/distributedlog-service/target/surefire/surefirebooter1574788574072023345.jar /Users/travis/build/apache/incubator-distributedlog/distributedlog-service/target/surefire/surefire1040382260065287155tmp /Users/travis/build/apache/incubator-distributedlog/distributedlog-service/target/surefire/surefire_871857929376723744956tmp
    `


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-distributedlog issue #123: DL-193: Bumped up the Guava version

Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the issue:

    https://github.com/apache/incubator-distributedlog/pull/123
  
    LGTM
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-distributedlog issue #123: DL-193: Bumped up the Guava version

Posted by jiazhai <gi...@git.apache.org>.
Github user jiazhai commented on the issue:

    https://github.com/apache/incubator-distributedlog/pull/123
  
    Thanks for the fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-distributedlog pull request #123: DL-193: Bumped up the Guava vers...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-distributedlog/pull/123


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-distributedlog issue #123: DL-193: Bumped up the Guava version

Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:

    https://github.com/apache/incubator-distributedlog/pull/123
  
    @arvindkandhare - I merged your change in bookkeeper and released a version - 4.3.7-TWTTR-OSS 
    
    Can you update your pull request for this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-distributedlog issue #123: DL-193: Bumped up the Guava version

Posted by sijie <gi...@git.apache.org>.
Github user sijie commented on the issue:

    https://github.com/apache/incubator-distributedlog/pull/123
  
    @arvindkandhare can you just exclude "guava" from the bookkeeper dependency and use 0.20 here? I am trying to understand if we really need a new bk version from twitter branch. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-distributedlog issue #123: DL-193: Bumped up the Guava version

Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the issue:

    https://github.com/apache/incubator-distributedlog/pull/123
  
    Couldnt figure out why our Jenkins build failed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---