You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/01 14:49:50 UTC

[GitHub] [airflow] malthe commented on a change in pull request #22685: Fix processor cleanup on DagFileProcessorManager

malthe commented on a change in pull request #22685:
URL: https://github.com/apache/airflow/pull/22685#discussion_r840663134



##########
File path: airflow/dag_processing/manager.py
##########
@@ -1073,6 +1074,14 @@ def _kill_timed_out_processors(self):
                 Stats.incr('dag_file_processor_timeouts')
                 processor.kill()
 
+                # Clean up processor references
+                self.waitables.pop(processor.waitable_handle)
+                processors_to_remove.append(file_path)
+
+        # Clean up `self._processors` after iterating over it
+        for proc in processors_to_remove:
+            self._processors.pop(proc)

Review comment:
       Or `del self._processors[proc]`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org