[GitHub] [helix] pkuwm opened a new pull request #585: Fix unit test failure for TestTaskPerformanceMetrics.

[GitBox <gi...@apache.org>]

pkuwm opened a new pull request #585: Fix unit test failure for TestTaskPerformanceMetrics.
URL: https://github.com/apache/helix/pull/585
 
 
   ### Issues
   
   - [ ] My PR addresses the following Helix issues and references them in the PR description:
   
   Fixes #584 
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   The reason is thread sleeps too long. If all the jobs are completed, no new metrics are updated. so last verification would fail because last metric value won't change.
   The PR fixes this failure by removing the hard code sleep time, verifying new metric values are updated and then moving forward.
   
   ### Tests
   
   - [ ] The following tests are written for this issue:
   
   (List the names of added unit/integration tests)
   
   - [ ] The following is the result of the "mvn test" command on the appropriate module:
   
   START testTaskPerformanceMetrics at Mon Nov 11 16:12:29 PST 2019
   END testTaskPerformanceMetrics at Mon Nov 11 16:12:31 PST 2019, took: 2012ms.
   Default Suite
   Total tests run: 1, Failures: 0, Skips: 0
   ### Commits
   
   - [ ] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation in the following wiki page:
   
   (Link the GitHub wiki you added)
   
   ### Code Quality
   
   - [ ] My diff has been formatted using helix-style.xml

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org