You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/03/06 05:15:18 UTC

[GitHub] [incubator-dolphinscheduler] zhuangchong commented on pull request #4978: the ProcessDefinitionServiceImpl defineIdList collection traversal code optimization.

zhuangchong commented on pull request #4978:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4978#issuecomment-791875667


   > This change is too little, can you find and replace the global magic number with the `Constants`?
   
   The main optimization is in collection traversal
   
   ![image](https://user-images.githubusercontent.com/37063904/110196196-e0a73b80-7e7d-11eb-91ac-fcca0c240f2d.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org