[GitHub] [superset] codyml commented on a diff in pull request #20683: feat: the samples endpoint supports filters and pagination

[GitBox <gi...@apache.org>]

codyml commented on code in PR #20683:
URL: https://github.com/apache/superset/pull/20683#discussion_r922527182


##########
superset/datasets/commands/samples.py:
##########
@@ -78,3 +116,24 @@ def validate(self) -> None:
             security_manager.raise_for_ownership(self._model)
         except SupersetSecurityException as ex:
             raise DatasetForbiddenError() from ex
+
+    @staticmethod
+    def get_limit_clause(
+        page: Optional[int], per_page: Optional[int]
+    ) -> Dict[str, int]:
+        samples_row_limit = app.config.get("SAMPLES_ROW_LIMIT", 1000)

Review Comment:
   Isn't the global samples row limit already applied at [query_object_factory.py#L64](https://github.com/apache/superset/blob/d1861c7d3c95e72336466cde17fee9ae1be9155a/superset/common/query_object_factory.py#L64)?  In either case, wouldn't we want to ignore this limit for this purpose, in case they've set it to something really low?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org