You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "dragon512 (via GitHub)" <gi...@apache.org> on 2023/11/06 19:03:37 UTC
[PR] Add logic to find nuraft [trafficserver]
dragon512 opened a new pull request, #10734:
URL: https://github.com/apache/trafficserver/pull/10734
Use standard pattern to find libraries and naming for constancy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logic to find nuraft [trafficserver]
Posted by "dragon512 (via GitHub)" <gi...@apache.org>.
dragon512 merged PR #10734:
URL: https://github.com/apache/trafficserver/pull/10734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logic to find nuraft [trafficserver]
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #10734:
URL: https://github.com/apache/trafficserver/pull/10734#issuecomment-1796147271
This will break the ability to find `NuRaftConfig.cmake` on case sensitive systems. I can submit a PR to NuRaft to change the name to `nuraft-config.cmake`.
We could just rely on the Find module, but I think in general it is a good idea not to write Find modules if we do not have to. It's code that we then have to maintain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logic to find nuraft [trafficserver]
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #10734:
URL: https://github.com/apache/trafficserver/pull/10734#issuecomment-1796348862
We will have to submit a PR to NuRaft before we can use `find_package(nuraft)` with their config; however, if we intend to maintain our own Find module, then submitting that PR may not have much value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logic to find nuraft [trafficserver]
Posted by "dragon512 (via GitHub)" <gi...@apache.org>.
dragon512 commented on PR #10734:
URL: https://github.com/apache/trafficserver/pull/10734#issuecomment-1796187703
> This will break the ability to find `NuRaftConfig.cmake` on case sensitive systems. I can submit a PR to NuRaft to change the name to `nuraft-config.cmake`.
>
> We could just rely on the Find module, but I think in general it is a good idea not to write Find modules if we do not have to. It's code that we then have to maintain.
I think you just found that everything is still working with no change on your PR ... is the correct @JosiahWI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add logic to find nuraft [trafficserver]
Posted by "dragon512 (via GitHub)" <gi...@apache.org>.
dragon512 commented on PR #10734:
URL: https://github.com/apache/trafficserver/pull/10734#issuecomment-1796507400
That is fine with me. We need this now. we can change it later if we want to after a new nuraft is made. Till then I believe it better to follow convention we have in CMake to not mix cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org