You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2023/01/12 23:09:59 UTC

[GitHub] [nuttx] lupyuen opened a new pull request, #8101: drivers/input: Add driver for Goodix GT9XX Touch Panel

lupyuen opened a new pull request, #8101:
URL: https://github.com/apache/nuttx/pull/8101

   ## Summary
   
   This PR adds the driver for Goodix GT9XX I2C Touch Panel, which will be called by PINE64 PinePhone.
   
   Our driver follows the design of the NuttX Driver for [Cypress MBR3108](https://github.com/apache/nuttx/blob/master/drivers/input/cypress_mbr3108.c). We have documented our driver here: ["NuttX Touch Panel Driver for PinePhone"](https://lupyuen.github.io/articles/touch2#appendix-nuttx-touch-panel-driver-for-pinephone)
   
   ### Modified Files
   
   `drivers/input/Kconfig`: Added option `INPUT_GT9XX` to select GT9XX Driver
   
   `drivers/input/Make.defs`: Added GT9XX Driver to Makefile
   
   ### New Files
   
   `drivers/input/gt9xx.c`, `gt9xx.h`: I2C Driver for GT9XX Touch Panel
   
   ## Impact
   
   Our driver is not called by any existing code.
   
   In the next PR, we will add this driver to the Board Bringup Function for PinePhone.
   
   ## Testing
   
   We tested our driver with the `lvgldemo widgets` command using [this configuration](https://lupyuen.github.io/articles/touch2#lvgl-calls-our-driver). Touch Input works correctly on PinePhone, which has a GT917S Touch Panel:
   
   - [Demo Video](https://www.youtube.com/shorts/APge9bTt-ho)
   
   - [Test Log](https://gist.github.com/lupyuen/fc88153b915894dbdaefcb5a916232fe)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8101: drivers/input: Add driver for Goodix GT9XX Touch Panel

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #8101:
URL: https://github.com/apache/nuttx/pull/8101#issuecomment-1381299191

   @lupyuen it will be better to reuse the touchscreen upper half driver: 
   https://github.com/apache/nuttx/blob/master/drivers/input/touchscreen_upper.c


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] xiaoxiang781216 merged pull request #8101: drivers/input: Add driver for Goodix GT9XX Touch Panel

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #8101:
URL: https://github.com/apache/nuttx/pull/8101


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] lupyuen commented on pull request #8101: drivers/input: Add driver for Goodix GT9XX Touch Panel

Posted by GitBox <gi...@apache.org>.
lupyuen commented on PR #8101:
URL: https://github.com/apache/nuttx/pull/8101#issuecomment-1381301144

   Thanks @xiaoxiang781216 I'll fix that for the next update!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org