You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/04/29 09:48:05 UTC
[GitHub] [cordova-plugin-inappbrowser] Heshyo opened a new issue #870: iOS Location bar is transparent
Heshyo opened a new issue #870:
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/870
# Bug Report
## Problem
On iOS, the location bar is transparent, meaning the app is visible behind.
### What is expected to happen?
The location bar has the same background color as the toolbar, hiding the app behind and making the visited URL visible.
### What does actually happen?
The location bar is transparent.
The green rectangle shows the location bar. It's transparent, and as the background of the app is white, just like the location, the location isn't visible.
Changing `toolbarcolor` or `toolbartranslucent` doesn't have any effect on the location
## Information
I don't know if this is linked with https://github.com/apache/cordova-plugin-inappbrowser/issues/801 as it's reported to be caused by the notch. I've tested it on real devices with notch, as well as in the simulator on an iPhone 8 that has no notch, and I always have the issue.
Looking at the code it seems normal that this issue occurs, as the label has a [transparent background](https://github.com/apache/cordova-plugin-inappbrowser/blob/3b6757fc4407aa5cd9d5cbda3ff2f8174ecdae1a/src/ios/CDVWKInAppBrowser.m#L858) color.
Doing the following fixes my issue mostly
```
self.addressLabel.backgroundColor = [UIColor blackColor];
```
This only mostly fixes the issue because
- Instead of `blackColor` it would be best to be able to reuse the color of the toolbar. Setting it to `self.toolbar.barTintColor` works, but only if a `toolbarcolor` option was used.
- There's still a small space on the left of the label, corresponding to the [label inset](https://github.com/apache/cordova-plugin-inappbrowser/blob/3b6757fc4407aa5cd9d5cbda3ff2f8174ecdae1a/src/ios/CDVWKInAppBrowser.m#L850). It would be best to be able to remove that inset while still having some padding.
### Command or Code
```
cordova.InAppBrowser.open('https://github.com', '_blank', 'location=yes,closebuttoncaption=Fermer');
```
### Environment, Platform, Device
```
System:
ios-deploy : 1.11.3
ios-sim : 8.0.2
NodeJS : v14.15.4 (/Users/user/.nvm/versions/node/v14.15.4/bin/node)
npm : 6.14.10
OS : macOS Big Sur
Xcode : Xcode 12.3 Build version 12C33
```
### Version information
```
Ionic:
Ionic CLI : 6.13.1 (/Users/user/.nvm/versions/node/v14.15.4/lib/node_modules/@ionic/cli)
Ionic Framework : @ionic/angular 5.6.3
@angular-devkit/build-angular : 0.1102.5
@angular-devkit/schematics : 11.2.5
@angular/cli : 11.2.5
@ionic/angular-toolkit : 3.1.1
Cordova:
Cordova CLI : 10.0.0
Cordova Platforms : ios 6.2.0
Cordova Plugins : cordova-plugin-ionic-keyboard 2.2.0, cordova-plugin-ionic-webview 4.2.1, (and 17 other plugins)
cordova-plugin-inappbrowser 5.0.0
Utility:
cordova-res : 0.15.3
native-run : 1.3.0
```
## Checklist
<!-- Please check the boxes by putting an x in the [ ] like so: [x] -->
- [x] I searched for existing GitHub issues
- [x] I updated all Cordova tooling to most recent version
- [x] I included all the necessary information above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] nosTa1337 commented on issue #870: iOS Location bar is transparent
Posted by GitBox <gi...@apache.org>.
nosTa1337 commented on issue #870:
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/870#issuecomment-886932924
same here. using iOS 14.5
I have the problem on simulator with notch and real iPhone without notch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] codeconsole commented on issue #870: iOS Location bar is transparent
Posted by GitBox <gi...@apache.org>.
codeconsole commented on issue #870:
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/870#issuecomment-917469417
https://github.com/apache/cordova-plugin-inappbrowser/issues/901
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] Amal9562 commented on issue #870: iOS Location bar is transparent
Posted by GitBox <gi...@apache.org>.
Amal9562 commented on issue #870:
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/870#issuecomment-1060249436
i think we need to fork this plugin and edit CDVWKinAppbrowser.m => self.addressLabel.backgroundColor at the line 859 to
= [UIColor Black]; and just make the build on ios will be set url bar background to black. when ever we make the build it automaticaly fetch details from the main plugin branch from git so our customised code from the project can do nothing .just try it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] Maks113 commented on issue #870: iOS Location bar is transparent
Posted by GitBox <gi...@apache.org>.
Maks113 commented on issue #870:
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/870#issuecomment-892963441
same issue on iPhone 11 ios 14.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] jmalfatto edited a comment on issue #870: iOS Location bar is transparent
Posted by GitBox <gi...@apache.org>.
jmalfatto edited a comment on issue #870:
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/870#issuecomment-1067074691
> Hi. Is there any news about this problem? Is a fix planned? Thanks
Same question
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] tdfeslo commented on issue #870: iOS Location bar is transparent
Posted by GitBox <gi...@apache.org>.
tdfeslo commented on issue #870:
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/870#issuecomment-1014887481
Hi. Is there any news about this problem? Is a fix planned? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] Qlfvr commented on issue #870: iOS Location bar is transparent
Posted by GitBox <gi...@apache.org>.
Qlfvr commented on issue #870:
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/870#issuecomment-906180422
Hello, I arrive here from #801 . I am having a similar issue even with hideurlbar=yes.
(iOS 14.7.1)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] Maks113 commented on issue #870: iOS Location bar is transparent
Posted by GitBox <gi...@apache.org>.
Maks113 commented on issue #870:
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/870#issuecomment-892963441
same issue on iPhone 11 ios 14.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] Qlfvr edited a comment on issue #870: iOS Location bar is transparent
Posted by GitBox <gi...@apache.org>.
Qlfvr edited a comment on issue #870:
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/870#issuecomment-906180422
Hello, I arrive here from #801 . I am having a similar issue even with hideurlbar=yes.
(iOS 14.7.1 ; iPhone 8; using ionic 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] jmalfatto commented on issue #870: iOS Location bar is transparent
Posted by GitBox <gi...@apache.org>.
jmalfatto commented on issue #870:
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/870#issuecomment-1067074691
> Hi. Is there any news about this problem? Is a fix planned? Thanks
Same question, two months later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] bhandaribhuminpfizer removed a comment on issue #870: iOS Location bar is transparent
Posted by GitBox <gi...@apache.org>.
bhandaribhuminpfizer removed a comment on issue #870:
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/870#issuecomment-865985987
same issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] bhandaribhuminpfizer commented on issue #870: iOS Location bar is transparent
Posted by GitBox <gi...@apache.org>.
bhandaribhuminpfizer commented on issue #870:
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/870#issuecomment-865985987
same issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] bhandaribhumin commented on issue #870: iOS Location bar is transparent
Posted by GitBox <gi...@apache.org>.
bhandaribhumin commented on issue #870:
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/870#issuecomment-906940013
@Qlfvr @Maks113
I observe URL bar is present but we have to change the font colour for the visible font, problem: bar colour is the same as the URL text font colour which is white!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org