[jira] [Commented] (ROCKETMQ-96) Rename tmp variable

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ROCKETMQ-96?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15865178#comment-15865178 ] 

ASF GitHub Bot commented on ROCKETMQ-96:
----------------------------------------

GitHub user Jaskey opened a pull request:

    https://github.com/apache/incubator-rocketmq/pull/60

    [ROCKETMQ-96]Rename some temp variable and field

    JIRA: https://issues.apache.org/jira/browse/ROCKETMQ-96

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Jaskey/incubator-rocketmq ROCKETMQ-96

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rocketmq/pull/60.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #60
    
----
commit 7455bdf093762c5ab248d18e0788d3c42d6639b5
Author: Jaskey <li...@gmail.com>
Date:   2017-02-14T06:37:24Z

    rename some temp variable and field

----


> Rename tmp variable 
> --------------------
>
>                 Key: ROCKETMQ-96
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-96
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>          Components: rocketmq-client
>    Affects Versions: 4.0.0-incubating
>            Reporter: Jaskey Lam
>            Assignee: Xiaorui Wang
>            Priority: Minor
>
> Some variable is named with tmp which is very difficult to read and understand its usage.
> For exampe:
> 1. in sendDefaultImpl, when select message queue, the variable is named with 
>     
>       MessageQueue tmpmq = this.selectOneMessageQueue(topicPublishInfo, lastBrokerName);
> 2. In process queue, a field is named `msgTreeMapTemp`, which takes me minutes to understand why it is desgined for, which should be rename to some name like consumeingOrderlyMsgTreeMap



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)