You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/03/03 03:30:26 UTC
[GitHub] [incubator-mxnet] access2rohit opened a new pull request #19974: [DO NOT MERGE][v1.x]Migrating all CD pipelines to Ninja build + fix cu112 pipeline
access2rohit opened a new pull request #19974:
URL: https://github.com/apache/incubator-mxnet/pull/19974
## Description ##
Migrates all cd build to `ninja` from `make` and fixes CUDA11.2 pipeline for `v1.x`
## Checklist ##
### Essentials ###
- [ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage
- [ ] Code is well-documented
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on pull request #19974: [FEATURE]Migrating all CD pipelines to Ninja build + fix cu112 CD pipeline
Posted by GitBox <gi...@apache.org>.
access2rohit commented on pull request #19974:
URL: https://github.com/apache/incubator-mxnet/pull/19974#issuecomment-797021440
Will disable flaky tests #20011 in this PR too if the current run fails.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on a change in pull request #19974: [DO NOT MERGE][v1.x]Migrating all CD pipelines to Ninja build + fix cu112 CD pipeline
Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #19974:
URL: https://github.com/apache/incubator-mxnet/pull/19974#discussion_r587144689
##########
File path: cmake/Modules/FindCUDNN.cmake
##########
@@ -23,7 +23,7 @@ find_path(CUDNN_INCLUDE cudnn.h
PATHS ${CUDNN_ROOT} $ENV{CUDNN_ROOT}
DOC "Path to cuDNN include directory." )
-find_library(CUDNN_LIBRARY NAMES libcudnn.so cudnn.lib # libcudnn_static.a
+find_library(CUDNN_LIBRARY NAMES libcudnn.so cudnn.lib cudnn
Review comment:
Can you explain why this change is needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on pull request #19974: [DO NOT MERGE][WIP][FEATURE]Migrating all CD pipelines to Ninja build + fix cu112 CD pipeline
Posted by GitBox <gi...@apache.org>.
access2rohit commented on pull request #19974:
URL: https://github.com/apache/incubator-mxnet/pull/19974#issuecomment-796164998
Latest CD successful build: https://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/restricted-mxnet-cd%2Fmxnet-cd-release-job-1.x-rohit/detail/mxnet-cd-release-job-1.x-rohit/58/pipeline
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit edited a comment on pull request #19974: [FEATURE]Migrating all CD pipelines to Ninja build + fix cu112 CD pipeline
Posted by GitBox <gi...@apache.org>.
access2rohit edited a comment on pull request #19974:
URL: https://github.com/apache/incubator-mxnet/pull/19974#issuecomment-797021440
Will disable flaky tests #20011 in this PR too if the current CI run fails.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on pull request #19974: [DO NOT MERGE][WIP][v1.x][FEATURE]Migrating all CD pipelines to Ninja build + fix cu112 CD pipeline
Posted by GitBox <gi...@apache.org>.
access2rohit commented on pull request #19974:
URL: https://github.com/apache/incubator-mxnet/pull/19974#issuecomment-794520881
@leezu : can you review ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #19974: [DO NOT MERGE][v1.x]Migrating all CD pipelines to Ninja build + fix cu112 CD pipeline
Posted by GitBox <gi...@apache.org>.
access2rohit commented on a change in pull request #19974:
URL: https://github.com/apache/incubator-mxnet/pull/19974#discussion_r587835974
##########
File path: cmake/Modules/FindCUDNN.cmake
##########
@@ -23,7 +23,7 @@ find_path(CUDNN_INCLUDE cudnn.h
PATHS ${CUDNN_ROOT} $ENV{CUDNN_ROOT}
DOC "Path to cuDNN include directory." )
-find_library(CUDNN_LIBRARY NAMES libcudnn.so cudnn.lib # libcudnn_static.a
+find_library(CUDNN_LIBRARY NAMES libcudnn.so cudnn.lib cudnn
Review comment:
Added it while testing. Forgot to remove it. Will do
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19974: [FEATURE]Migrating all CD pipelines to Ninja build + fix cu112 CD pipeline
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19974:
URL: https://github.com/apache/incubator-mxnet/pull/19974#issuecomment-796998243
Jenkins CI successfully triggered : [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit edited a comment on pull request #19974: [FEATURE]Migrating all CD pipelines to Ninja build + fix cu112 CD pipeline
Posted by GitBox <gi...@apache.org>.
access2rohit edited a comment on pull request #19974:
URL: https://github.com/apache/incubator-mxnet/pull/19974#issuecomment-796707981
Apparently, unable to download MNIST dataset from http://yann.lecun.com/exdb/mnist/ so added backup URL to`data.sh` to stablize unix-gpu CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit closed pull request #19974: [DO NOT MERGE][v1.x]Migrating all CD pipelines to Ninja build + fix cu112 pipeline
Posted by GitBox <gi...@apache.org>.
access2rohit closed pull request #19974:
URL: https://github.com/apache/incubator-mxnet/pull/19974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] Zha0q1 merged pull request #19974: [FEATURE]Migrating all CD pipelines to Ninja build + fix cu112 CD pipeline
Posted by GitBox <gi...@apache.org>.
Zha0q1 merged pull request #19974:
URL: https://github.com/apache/incubator-mxnet/pull/19974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on pull request #19974: [FEATURE]Migrating all CD pipelines to Ninja build + fix cu112 CD pipeline
Posted by GitBox <gi...@apache.org>.
access2rohit commented on pull request #19974:
URL: https://github.com/apache/incubator-mxnet/pull/19974#issuecomment-796998183
@mxnet-bot run ci [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19974: Cd ninja
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19974:
URL: https://github.com/apache/incubator-mxnet/pull/19974#issuecomment-789389496
Hey @access2rohit , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [sanity, miscellaneous, windows-gpu, edge, centos-cpu, unix-gpu, centos-gpu, windows-cpu, unix-cpu, website, clang]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on pull request #19974: [FEATURE]Migrating all CD pipelines to Ninja build + fix cu112 CD pipeline
Posted by GitBox <gi...@apache.org>.
access2rohit commented on pull request #19974:
URL: https://github.com/apache/incubator-mxnet/pull/19974#issuecomment-796707981
Apparently http://yann.lecun.com/exdb/mnist/ is down so added backup URL to`data.sh` to stablize unix-gpu CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on pull request #19974: [DO NOT MERGE][WIP][v1.x][FEATURE]Migrating all CD pipelines to Ninja build + fix cu112 CD pipeline
Posted by GitBox <gi...@apache.org>.
access2rohit commented on pull request #19974:
URL: https://github.com/apache/incubator-mxnet/pull/19974#issuecomment-795876752
@leezu @josephevans @mseth10 @Zha0q1 @waytrue17 can you review ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org