You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/30 16:25:23 UTC

[GitHub] [arrow-datafusion] cpcloud opened a new pull request #1508: Ship Cargo.lock in the source distribution

cpcloud opened a new pull request #1508:
URL: https://github.com/apache/arrow-datafusion/pull/1508


   # Which issue does this PR close?
   
   It doesn't close an issue as far as I know.
   
   # Rationale for this change
   
   Build systems like `nix` need `Cargo.lock` to build reproducible Rust packages.
   
   The `Cargo.lock` file is necessary to generate a hash for a crate's dependencies.
   
   Without the 
   
   # What changes are included in this PR?
   
   - Updates to `Cargo.lock` resulting from running `maturin build`
   - Required changes to `pyproject.toml` to ship the `Cargo.lock` in the source distribution
   
   # Are there any user-facing changes?
   
   No API changes.
   
   Does user-facing mean only API changes?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-datafusion] cpcloud commented on pull request #1508: Ship Cargo.lock in the source distribution

Posted by GitBox <gi...@apache.org>.
cpcloud commented on pull request #1508:
URL: https://github.com/apache/arrow-datafusion/pull/1508#issuecomment-1006165021


   Closing in favor of datafusion-contrib/datafusion-python#7


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-datafusion] cpcloud commented on pull request #1508: Ship Cargo.lock in the source distribution

Posted by GitBox <gi...@apache.org>.
cpcloud commented on pull request #1508:
URL: https://github.com/apache/arrow-datafusion/pull/1508#issuecomment-1004216889


   Ok, thanks. I'll just proactively move it over 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-datafusion] cpcloud commented on a change in pull request #1508: Ship Cargo.lock in the source distribution

Posted by GitBox <gi...@apache.org>.
cpcloud commented on a change in pull request #1508:
URL: https://github.com/apache/arrow-datafusion/pull/1508#discussion_r777145887



##########
File path: .github/workflows/python_build.yml
##########
@@ -77,6 +77,9 @@ jobs:
       - name: Build Python package
         run: maturin build --release --no-sdist --strip
 
+      - name: Check that the lock file is up to date
+        run: git diff --exit-code Cargo.lock

Review comment:
       Yep, great idea. Thanks 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-datafusion] Jimexist commented on a change in pull request #1508: Ship Cargo.lock in the source distribution

Posted by GitBox <gi...@apache.org>.
Jimexist commented on a change in pull request #1508:
URL: https://github.com/apache/arrow-datafusion/pull/1508#discussion_r777084798



##########
File path: .github/workflows/python_build.yml
##########
@@ -77,6 +77,9 @@ jobs:
       - name: Build Python package
         run: maturin build --release --no-sdist --strip
 
+      - name: Check that the lock file is up to date
+        run: git diff --exit-code Cargo.lock

Review comment:
       can you use `--frozen` and `--locked` per [doc][1]
   
   [1]: https://doc.rust-lang.org/cargo/commands/cargo-install.html




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-datafusion] cpcloud closed pull request #1508: Ship Cargo.lock in the source distribution

Posted by GitBox <gi...@apache.org>.
cpcloud closed pull request #1508:
URL: https://github.com/apache/arrow-datafusion/pull/1508


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-datafusion] cpcloud commented on pull request #1508: Ship Cargo.lock in the source distribution

Posted by GitBox <gi...@apache.org>.
cpcloud commented on pull request #1508:
URL: https://github.com/apache/arrow-datafusion/pull/1508#issuecomment-1003399635


   Hm, it looks like github actions hasn't been set up for that repo, so I'll leave this PR open for now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-datafusion] Jimexist commented on pull request #1508: Ship Cargo.lock in the source distribution

Posted by GitBox <gi...@apache.org>.
Jimexist commented on pull request #1508:
URL: https://github.com/apache/arrow-datafusion/pull/1508#issuecomment-1004167073


   after https://github.com/apache/arrow-datafusion/pull/1518 is merged please consider merging to that repo instead. thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-datafusion] cpcloud commented on pull request #1508: Ship Cargo.lock in the source distribution

Posted by GitBox <gi...@apache.org>.
cpcloud commented on pull request #1508:
URL: https://github.com/apache/arrow-datafusion/pull/1508#issuecomment-1003390627


   Alright, I'll reopen the PR over there, thanks @alamb!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-datafusion] alamb commented on pull request #1508: Ship Cargo.lock in the source distribution

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1508:
URL: https://github.com/apache/arrow-datafusion/pull/1508#issuecomment-1003378037


   Makes sense to me , but I defer to the python experts such as @Jimexist 
   
   Note some of this code is being moved to a separate repo -- see https://github.com/apache/arrow-datafusion/issues/1324 for more details


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org