You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Giridharan Kesavan (JIRA)" <ji...@apache.org> on 2009/02/18 12:47:01 UTC
[jira] Created: (HADOOP-5279) test-patch.sh scirpt should just call
the test-core target as part of runtestcore function.
test-patch.sh scirpt should just call the test-core target as part of runtestcore function.
-------------------------------------------------------------------------------------------
Key: HADOOP-5279
URL: https://issues.apache.org/jira/browse/HADOOP-5279
Project: Hadoop Core
Issue Type: Improvement
Reporter: Giridharan Kesavan
Assignee: Giridharan Kesavan
checkReleaseAuditWarnings function just calls the releaseaudit target.
checkFindbugsWarnings function just calls findbugs.
runCoreTests function is calling docs tar and test-core.
If we just want to execute the test-core target then we should skip calling docs and tar target ..
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HADOOP-5279) test-patch.sh scirpt should just
call the test-core target as part of runtestcore function.
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nigel Daley resolved HADOOP-5279.
---------------------------------
Resolution: Fixed
Fix Version/s: 0.21.0
Hadoop Flags: [Reviewed]
Yes, you're right Giri. I just committed this. Thanks!
> test-patch.sh scirpt should just call the test-core target as part of runtestcore function.
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-5279
> URL: https://issues.apache.org/jira/browse/HADOOP-5279
> Project: Hadoop Core
> Issue Type: Improvement
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Fix For: 0.21.0
>
> Attachments: HADOOP-5279.patch
>
>
> checkReleaseAuditWarnings function just calls the releaseaudit target.
> checkFindbugsWarnings function just calls findbugs.
> runCoreTests function is calling docs tar and test-core.
> If we just want to execute the test-core target then we should skip calling docs and tar target ..
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5279) test-patch.sh scirpt should just
call the test-core target as part of runtestcore function.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675936#action_12675936 ]
Hudson commented on HADOOP-5279:
--------------------------------
Integrated in Hadoop-trunk #763 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/763/])
> test-patch.sh scirpt should just call the test-core target as part of runtestcore function.
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-5279
> URL: https://issues.apache.org/jira/browse/HADOOP-5279
> Project: Hadoop Core
> Issue Type: Improvement
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Fix For: 0.21.0
>
> Attachments: HADOOP-5279.patch
>
>
> checkReleaseAuditWarnings function just calls the releaseaudit target.
> checkFindbugsWarnings function just calls findbugs.
> runCoreTests function is calling docs tar and test-core.
> If we just want to execute the test-core target then we should skip calling docs and tar target ..
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5279) test-patch.sh scirpt should just call
the test-core target as part of runtestcore function.
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Giridharan Kesavan updated HADOOP-5279:
---------------------------------------
Attachment: HADOOP-5279.patch
this patch cannot be tested with hudson as it patches the test-patch.sh script itself.
> test-patch.sh scirpt should just call the test-core target as part of runtestcore function.
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-5279
> URL: https://issues.apache.org/jira/browse/HADOOP-5279
> Project: Hadoop Core
> Issue Type: Improvement
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Attachments: HADOOP-5279.patch
>
>
> checkReleaseAuditWarnings function just calls the releaseaudit target.
> checkFindbugsWarnings function just calls findbugs.
> runCoreTests function is calling docs tar and test-core.
> If we just want to execute the test-core target then we should skip calling docs and tar target ..
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5279) test-patch.sh scirpt should just
call the test-core target as part of runtestcore function.
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674723#action_12674723 ]
Nigel Daley commented on HADOOP-5279:
-------------------------------------
+1.
> test-patch.sh scirpt should just call the test-core target as part of runtestcore function.
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-5279
> URL: https://issues.apache.org/jira/browse/HADOOP-5279
> Project: Hadoop Core
> Issue Type: Improvement
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Attachments: HADOOP-5279.patch
>
>
> checkReleaseAuditWarnings function just calls the releaseaudit target.
> checkFindbugsWarnings function just calls findbugs.
> runCoreTests function is calling docs tar and test-core.
> If we just want to execute the test-core target then we should skip calling docs and tar target ..
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5279) test-patch.sh scirpt should just
call the test-core target as part of runtestcore function.
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674911#action_12674911 ]
Giridharan Kesavan commented on HADOOP-5279:
--------------------------------------------
checkJavacWarnings function which is getting called after applying the patch which calls the tar ant target and which in turn has dependency on docs target. so I think we are good here.
> test-patch.sh scirpt should just call the test-core target as part of runtestcore function.
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-5279
> URL: https://issues.apache.org/jira/browse/HADOOP-5279
> Project: Hadoop Core
> Issue Type: Improvement
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Attachments: HADOOP-5279.patch
>
>
> checkReleaseAuditWarnings function just calls the releaseaudit target.
> checkFindbugsWarnings function just calls findbugs.
> runCoreTests function is calling docs tar and test-core.
> If we just want to execute the test-core target then we should skip calling docs and tar target ..
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5279) test-patch.sh scirpt should just
call the test-core target as part of runtestcore function.
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674899#action_12674899 ]
Nigel Daley commented on HADOOP-5279:
-------------------------------------
Ah, I remember why this was done. It's the *only* place in test-patch.sh that call the docs and tar target *after* the patch has been applied. Perhaps we need a runTar function that runs docs and tar targets. That would make a clearer failure if the patch breaks the build.
> test-patch.sh scirpt should just call the test-core target as part of runtestcore function.
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-5279
> URL: https://issues.apache.org/jira/browse/HADOOP-5279
> Project: Hadoop Core
> Issue Type: Improvement
> Reporter: Giridharan Kesavan
> Assignee: Giridharan Kesavan
> Attachments: HADOOP-5279.patch
>
>
> checkReleaseAuditWarnings function just calls the releaseaudit target.
> checkFindbugsWarnings function just calls findbugs.
> runCoreTests function is calling docs tar and test-core.
> If we just want to execute the test-core target then we should skip calling docs and tar target ..
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.