[jira] [Comment Edited] (MNG-6435) DefaultSettingsBuilder assumes all SettingsReader/Writer impls will use XML

["Karl Heinz Marbaise (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MNG-6435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564211#comment-16564211 ] 

Karl Heinz Marbaise edited comment on MNG-6435 at 7/31/18 7:01 PM:
-------------------------------------------------------------------

Ok you have given an example which can cause problems which means the design is simply not good....so the question is can we fix/improve that in a way without breaking compatibility and maybe making your life (implementing) easier ? Do you have suggestions or a patch ? 


was (Author: khmarbaise):
Ok you have given an example where can cause problems which means the design is simply not good....so the question is can we fix/improve that in a way without breaking compatibility and maybe making your life (implementing) easier ? Do you have suggestions or a patch ? 

> DefaultSettingsBuilder assumes all SettingsReader/Writer impls will use XML
> ---------------------------------------------------------------------------
>
>                 Key: MNG-6435
>                 URL: https://issues.apache.org/jira/browse/MNG-6435
>             Project: Maven
>          Issue Type: Improvement
>          Components: Settings
>    Affects Versions: 3.5.3
>            Reporter: Laird Nelson
>            Priority: Minor
>
> On or around line 234, interpolation of settings assumes XML:
> {code}
> interpolator.addPostProcessor( new InterpolationPostProcessor()
> {
>   @Override
>   public Object execute( String expression, Object value )
>   {
>     if ( value != null )
>     {
>       // we're going to parse this back in as XML so we need to escape XML markup
>       value = value.toString().replace( "&", "&amp;" ).replace( "<", "&lt;" ).replace( ">", "&gt;" );
>       return value;
>     }
>     return null;
>   }
> } );
> {code}
> The value being interpolated here is the result of a {{SettingsWriter}}'s output.  Obviously this kind of escaping doesn't make any sense if the {{SettingsWriter}} in question is not XML-based.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)