You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/07/04 14:31:26 UTC
[GitHub] [airflow-openldap] potiuk opened a new pull request #1: Add Airflow-specific modifications - image can be build on its own
potiuk opened a new pull request #1:
URL: https://github.com/apache/airflow-openldap/pull/1
It uses only officially released code.
Part of https://github.com/apache/airflow/issues/9401
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-openldap] potiuk commented on pull request #1: Add Airflow-specific modifications - image can be build on its own
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #1:
URL: https://github.com/apache/airflow-openldap/pull/1#issuecomment-653779075
Correct @turbaszek - I split it into two commits. The first brings in the "base-image", the second adds airflow modifications.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-openldap] potiuk merged pull request #1: Add Airflow-specific modifications - image can be build on its own
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #1:
URL: https://github.com/apache/airflow-openldap/pull/1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-openldap] turbaszek commented on pull request #1: Add Airflow-specific modifications - image can be build on its own
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #1:
URL: https://github.com/apache/airflow-openldap/pull/1#issuecomment-653774618
Would it be a good idea to split this into two commits? (if I correctly understand)
- base code from osixia/openldap:1.2.0
- airflow specific changes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow-openldap] turbaszek commented on a change in pull request #1: Add Airflow-specific modifications - image can be build on its own
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #1:
URL: https://github.com/apache/airflow-openldap/pull/1#discussion_r449778462
##########
File path: .idea/docker-openldap.iml
##########
@@ -0,0 +1,9 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<module type="JAVA_MODULE" version="4">
+ <component name="NewModuleRootManager" inherit-compiler-output="true">
+ <exclude-output />
+ <content url="file://$MODULE_DIR$" />
+ <orderEntry type="inheritedJdk" />
+ <orderEntry type="sourceFolder" forTests="false" />
+ </component>
+</module>
Review comment:
We probably don't want any `.idea` content in the repo, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org